Support Drupal 10

Hello, applying the patch, it still doesn't work for drupal 10.0.8.
The text field of the "caption field" when adding an image does not appear.
In drupal 9.5.8 the module works perfectly but I need to use it in drupal 10.0.8. Any solution? Thx

It looks like the maintainer have to change the info.yml.
When you apply composer install it took the remote file.
Other solution is to fork the module.

Baher

Some other deprecated code:

image_field_caption_field_widget_form_alter
is now:
image_field_caption_field_widget_single_element_form_alter

https://www.drupal.org/node/3180429 →

Ambient.Impact → made their first commit to this issue’s fork.

Committed the patch from #3; ignore the 8.x-1.x branch, that was a brain fart.

@Baher Add the fork repository to your root composer.json's "repositories" before the Drupal.org one:

   {
      "type": "vcs",
      "url": "https://git.drupalcode.org/issue/image_field_caption-3355337.git"
   }

Then add to the "require" section:

    "drupal/image_field_caption": "dev-3355337-support-drupal-10@dev as 1.2"

And then run composer update drupal/image_field_caption and it should work. It does for me.

Is there an estimated release date for the D10 version of this module?

In Drupal 10 Ckeditor 5 propose caption in image. Maybe for this reason the contributor is not interested to upgrade it.

Baher

@octaviosch Like @Nathaniel mentioned there is still a deprecated hook used (image_field_caption_field_widget_form_alter), I changed
this to image_field_caption_field_widget_single_element_form_alter and commited this on the 3355337-support-drupal-10 branch.
I'll also attach a remake of the existing patch with this change included.

The caption field should be usable now.

I'll mark this as needs review.

I can confirm that the caption field is available with the current d-10 hook (#12). The module seems to be d10 ready.

Can confirm the issue fork works. Marking as RTBC.

Neither the patch nor the merge request diff is working for me. I'm adding a new patch.

Actually, that didn't work. I'm now using dev, pointing to commit d5b61749820c0838b5fec7605f402041421cf72e . That commit is the last one as well in 8.x-1.2, so it's a bit strange that the patch doesn't apply.

Patch #13 working fine for me. But this is not working with the Media Image widget. Just working with default image widget.

I re-re-rolled the patch as it was not applying. I believe the issue is these patches remove the dependencies of image, but leave the dependencies: line in the info file, with nothing below it, causing it to fail.

Well, it seems the last patch does not include a version update.
Provided updated patch.

Rerolled to support 8-1.2 version.

I guess the right status would be Needs review since there is 4 patch since RTBC...

Good catch Andriy. I can confirm (again) this is RTBC as patch install cleanly against code line.

With the Drupal 10 release, I'm happy to help maintain the module to get this release out: https://www.drupal.org/project/image_field_caption/issues/3396404 💬 Offer to help Maintain Needs review

The patch in #21 did not apply for me using Composer, I think because of the problem described in 🐛 Packaging info from .info.yml often creates conflicts when patching Active . Merge request #7, however, does successfully apply, so leaving this as RTBC. The only difference I see between the two is that drupal/image is not removed as a dependency in MR #7, but I think its removal was unintentional anyway based on the patches and comments in #16 and #19 here, so that seems fine to me.

Bumping ...

Drupal 9 has been EOL for three weeks now and as #25 notes, composer complains if you try to require the current version.

Could we get a new release ASAP?

TIA

Is there an estimated release date for the D10 version of this module?

Created 1.0.x branch and commit this. Created 1.0.0 tag that has this. Will be creating a 1.0.1 tag with the 4 other RBTC issues.

Automatically closed - issue fixed for 2 weeks with no activity.

Why was the image dependency removed here? ImageCaptionItem still extends the ImageItem class, which is provided by the Image module. Also, field_widget_single_element_form_alter was introduced in Drupal 9.2, so the minimum version should be set to that.