πŸ‡ΊπŸ‡ΈUnited States @rclemings

Account created on 5 September 2010, over 13 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States rclemings

Patch for those who prefer the old-fashioned way (including me).

πŸ‡ΊπŸ‡ΈUnited States rclemings

rclemings β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States rclemings

I tried that but got an out-of-memory error. I didn't investigate but I suspect there could be a problem if there are four or more newlines in a row.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Bullets are stripped and not replaced with anything meaningful either, so I added another line to handle that:

        $output = str_replace("</p>\n<p>", "\n\n", $output, $count);
        $output = str_replace("<li>", "  * ", $output, $count);
        $output = trim(PlainTextOutput::renderFromHtml($output));
πŸ‡ΊπŸ‡ΈUnited States rclemings

FWIW, I agree with removing the "Strip first line" code unless there a good reason for it that isn't stated here. It's causing me problems with a lot of notifications.

I also agree with @eelkeblok that double line breaks can be a good and necessary thing for readability, so I've made this change:

//          $output = str_replace(["\n ", "\n\n"], "\n", $output, $count);
          $output = str_replace("\n ", "\n", $output, $count);

Meanwhile, I think I found a third issue related to this block of code.

For one content type, I want to send the full body field in the notification. The body field is composed with the Restricted HTML text format, unmodified except that CKEditor5 is the text editor and the "Correct faulty and chopped off HTML" filter is added. The order of the filters is "Limit allowed HTML tags and correct faulty HTML", "Convert URLs into links", "Convert line breaks into HTML (i.e. <br> and <p>)", and "Correct faulty and chopped off HTML."

In the editor and on the page, there's a blank line between each paragraph. But in the notification, it's all one block, with no spaces between the paragraphs. It's hard to read, at least for my aging eyes.

What I think is happening is this:

$output = trim(PlainTextOutput::renderFromHtml($output));

That line is stripping the HTML tags from the content. As a result, what was "</p>\n<p>" becomes just "\n." That means there are no spaces between paragraphs (i.e. it needs to be "\n\n" instead of "\n").

My quick and dirty fix is to add a str_replace just before the "renderFromHtml" line, basically stripping the paragraph tags and replacing them with "\n\n" before the strip_tags is called.

$output = str_replace("</p>\n<p>", "\n\n", $output, $count);
$output = trim(PlainTextOutput::renderFromHtml($output));

I doubt that's the best way to do it, but it's working so I thought I'd add it to the discussion.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Works for me too. Setting to RTBC.

πŸ‡ΊπŸ‡ΈUnited States rclemings

New version. First one didn't work right.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Done, I think. Let me know if anything is wrong. First time doing it this way.

Actually I think "gets" could be changed to "is" to save a couple of characters. I'm probably going to make that change and a few others on my site, but I'll save them for another issue, because they may not suit everybody.

πŸ‡ΊπŸ‡ΈUnited States rclemings

All it took in my case (Drupal 10.1.7 => 10.2.1 via composer) was a cache rebuild (drush cr since the site was down).

πŸ‡ΊπŸ‡ΈUnited States rclemings

Am I missing something or does this NOT migrate subscriptions?

I'm able to migrate newsletters, issues, and subscribers, but not the corresponding subscriptions. All of the boxes on /admin/people/simplenews/edit/NNN are unchecked.

Probably not related, but I did have to apply this RTBC core patch to get it to work, possibly because of some orphaned newsletter tids in the source:

https://www.drupal.org/project/drupal/issues/3365895 πŸ› When sub_process encounters a row skip, it should skip its internal row, and not bubble up to the outer row RTBC

πŸ‡ΊπŸ‡ΈUnited States rclemings

I've migrated one site from this module to Wysiwyg/CKEditor4 and it works (at least for now) except for a few gotchas:

1. There are some classes in css/ckeditor.css that won't (naturally) be available in Wysiwyg. We noticed this when some centered type was suddenly flush-left because the browser couldn't find the "rtecenter" class. The fix was to copy those classes to the css in our custom theme.

2. On the "cleanup and output" tab of each Wysiwyg profile, there's a box labelled "Apply simple source formatting." If that box is not checked, then all of the line breaks are removed from the source code view (using the "Disable rich-text" link), making it hard to read.

3. We had to remove the filter "Convert line breaks into HTML (i.e.
and

)" from the text formats that use Wyswiyg/CKEditor. Otherwise, line breaks in the text are doubled when the node is displayed ("

" instead of "
").

That's it so far, except that CKEditor4 is still EOL.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Wysiwyg still seems to work with CKeditor 4, for now.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Thanks. The downgrade appears to have worked, although composer put up a bit of a fight so I had to downgrade pf_email 2.3.0 => 2.1.2.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Changing version tag to reflect newest Drupal 9/10 beta.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Another vote for #15. That makes seven so I'll set it to RTBC.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Ignore previous. It was missing a new file.

πŸ‡ΊπŸ‡ΈUnited States rclemings

This updates the #2 patch to fix a couple of significant bugs. Making this change configurable remains on my list, but I wanted to post this in case anyone wants to go ahead and use this patch as is.

πŸ‡ΊπŸ‡ΈUnited States rclemings

I've just installed this on Drupal 10.1.5 with the patch from #7 and everything seems to be working fine. Since Drupal 9 has been EOL for more than a month now, it would be nice to get this committed, so I will set it to RTBC.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Here's another duplicate that I filed and closed after discovering this was the cause. The patch in #31 worked.

https://www.drupal.org/project/eca_vbo/issues/3354722 πŸ› Error in EcaVboBulkForm Closed: duplicate

πŸ‡ΊπŸ‡ΈUnited States rclemings

Looks as if the issue is in contact_storage and there's an RTBC patch: https://www.drupal.org/project/contact_storage/issues/3191567#comment-14... πŸ› Notice: Undefined index: entity:delete_action:contact_message in contact_storage_action_info_alter() RTBC

This wasn't easy to figure out. I ended up dumping all of the defs using this snippet adapted from https://www.drupal.org/project/views_bulk_operations/issues/3171938: β†’

$am = \Drupal::service('plugin.manager.views_bulk_operations_action');
$defs = $am->getDefinitions([
  'skip_actions_permissions' => TRUE,
  'nocache' => TRUE,
]);
dump($defs);

With that I saw, at the bottom of a long list:

  "entity:unpublish_action:paragraph" => array:9 [β–Ά]
  "message_delete_action" => null

Well, now, there's our null.

Dr. Google then led me to https://www.drupal.org/project/contact_storage/issues/3306684 β†’ and https://www.drupal.org/project/contact_storage/issues/3191567 πŸ› Notice: Undefined index: entity:delete_action:contact_message in contact_storage_action_info_alter() RTBC and all is now well.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Bumping ...

Drupal 9 has been EOL for three weeks now and as #25 notes, composer complains if you try to require the current version.

Could we get a new release ASAP?

TIA

πŸ‡ΊπŸ‡ΈUnited States rclemings

I was able to get it updated to v3 successfully by following EXACTLY the steps listed here:

https://www.drupal.org/project/commerce_license/releases/8.x-2.0 β†’

It's complicated. It took more than one try, But it worked. The updb step is critical.

Maybe the same steps should be listed on https://www.drupal.org/project/commerce_license/releases/3.0.0 β†’ as well, just so nobody misses it?

πŸ‡ΊπŸ‡ΈUnited States rclemings

I found a similar error when importing errors. Patch attached. I suppose I could open a new issue but this one seems to be languishing so I'll just add it here for the benefit of future googlers.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Most of the above seems to be for v8.x-1.x. In case it helps anybody else, here's how I was able to change the group type for a simple group (no entity references, etc.) in v2.2.1:

1. Create the new group type if it does not already exist.
2. Install the appropriate content plugin/s ("set available content" from dropdown on /admin/group/types).
3. Add/edit group roles ("edit group roles" dropdown) as needed.
4. Set permission ("edit permissions" dropdown) as needed.
5. In database, in the "groups" and "groups_field_data" tables, change "type" field to new type for the relevant group/s.
6. Cross fingers, rebuild cache.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Here's a patch for the merge request mentioned by @steven-jones in #33. It strikes me as the better approach given the comments by @TR in #6. I'll mark it as needs review to get the testbot involved.

πŸ‡ΊπŸ‡ΈUnited States rclemings

@lucasvm: This issue is closed but the issue mentioned in comments #16 and #17 πŸ› Update to support path redirect import migrate_tools 6.0.2 RTBC has an identical patch and is RTBC, so it might be better to post any further comments there.

πŸ‡ΊπŸ‡ΈUnited States rclemings

@sebasgd: It was a block problem for me too. Only difference: In my case the block config(s) had both "node_type" and "entity_bundle:node" sections under "visibility." Removing the "node_type" sections appears to have fixed it.

Because my D10 site was not coming up at all and I didn't have drush working (yet), I made that change on the old D9 site (/admin/config/development/configuration/single/export, edit, then /admin/config/development/configuration/single/import). Then I exported the two affected blocks from the config table in the D9 database, and imported them into the same table in the D10 database.

πŸ‡ΊπŸ‡ΈUnited States rclemings

So you skipped this part, right?

composer require 'drupal/recommended-project:^10' --update-with-dependencies --no-update

That's what gives me the "Root package 'drupal/recommended-project' cannot require itself in its composer.json" error. I guess that's composer's obtuse way of saying -- what -- that it's redundant?

Yet https://www.drupal.org/docs/upgrading-drupal/upgrading-from-drupal-8-or-later/upgrading-a-composer-based-site β†’ is pretty clear about including that step.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Could we get a new release with the Drupal 10 updates? Neither 3.0.2 nor the most recent (older) dev includes them. Drupal 9 EOL is now just two months away.

πŸ‡ΊπŸ‡ΈUnited States rclemings

@nkoporec In that case, given the approaching EOL for Drupal 9, may I suggest there needs to be a new 3.0 release. The current one (beta2) is listed as "core_version_requirement: ^8.8 || ^9" and not everybody will/can use the dev.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Patch 3298001-15.patch applies successfully to 8.x-1.x-dev but not 8.x-1.1.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Still preparing for Drupal 10 and patch in #8 applies with no problems.

Drupal core 9.5.10
Private Message 3.0.0-beta2
PHP 8.1.0

πŸ‡ΊπŸ‡ΈUnited States rclemings

Closing a 3-year-old issue.

From the description, I'm wondering it if might be related to https://www.drupal.org/project/user_mailman_register/issues/2557909 πŸ› old mail address is subscribed again after mail address change Closed: outdated .

Anyway, if it is still a problem for Drupal 9/10 (version 1.0.x), please open a new issue there.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Closing a 5-year-old issue. If it is still a problem, please open a new issue for Drupal 9/10 (version 1.0.x).

πŸ‡ΊπŸ‡ΈUnited States rclemings

Closing an 8-year-old issue. If it is still a problem, please open a new issue for Drupal 9/10 (version 1.0.x).

πŸ‡ΊπŸ‡ΈUnited States rclemings

Closing an 8-year-old issue for non-response to maintainer's patch request.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Closing an 8-year-old issue. From the description it sounds as if the issue is just a duplicate message. If so and if it persists in the Drupal 9/10 version, it can be fixed in a new issue.

πŸ‡ΊπŸ‡ΈUnited States rclemings

At this point, the Drupal 7 version probably should be closed to new features in favor of Drupal the 9/10 (development) version.

πŸ‡ΊπŸ‡ΈUnited States rclemings

OK, I get it now. The merge request was completely rewritten from the latest patch. Sorry for my confusion. (Although, honestly, it is always going to be confusing to have a list of patches followed by a merge that isn't among the patches.)

πŸ‡ΊπŸ‡ΈUnited States rclemings

But ... it looks as if the patch from issue 3208616 Duplicate Files in Different Bundles Get Skipped πŸ› Duplicate Files in Different Bundles Get Skipped Fixed was left out of 2.0.12. Maybe others; that's the only one I was patching for. Intentional?

πŸ‡ΊπŸ‡ΈUnited States rclemings

Update. I rolled MFTM back to 2.0.9 and the problem seems fixed. I'm wondering if the problem isn't somewhere in issue #3279599.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Altered description of "profile module" field to reflect Drupal 7 "profile2" contributed module was supplanted by "profile" contributed module in Drupal 8/9/10.

πŸ‡ΊπŸ‡ΈUnited States rclemings

New upload with one major fix involving Profile module integration for the Mailman "name" field. Also, info.yml files were updated to reflect presumed compatibility with Drupal 10 based on testing.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Add a note about Profile module requirement in certain circumstances.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Nix that -- somehow the old version got uploaded with the new tag. Ill try to fix that today.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Just posted a dev version 1.0.0 for testing in Drupal 9.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Add more detail on limitations for anonymous users.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Drupal 9 version is planned.

πŸ‡ΊπŸ‡ΈUnited States rclemings

I'll try to get something posted (beta? alpha?) in the next couple of weeks.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Yes, it's about ready for some testing, but who are you? You just registered a couple of hours ago.

Reply by private message if you want.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Add link to project page

πŸ‡ΊπŸ‡ΈUnited States rclemings

Add link to project page

πŸ‡ΊπŸ‡ΈUnited States rclemings

Update summary to reflect deprecated status

πŸ‡ΊπŸ‡ΈUnited States rclemings

Add deprecation note

πŸ‡ΊπŸ‡ΈUnited States rclemings

Import tool is not available in the Drupal 7 version of this module.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Updates to reflect current release

πŸ‡ΊπŸ‡ΈUnited States rclemings

Multiple updates to reflect current module release.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Update summary again

πŸ‡ΊπŸ‡ΈUnited States rclemings

Update summary

πŸ‡ΊπŸ‡ΈUnited States rclemings

Complete rewrite to reflect current version of module.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Fix bad links, typos; remove incorrect references to Mailman Manager.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Add that Mailman 3 is not supported.

πŸ‡ΊπŸ‡ΈUnited States rclemings

Light initial editing and updating

πŸ‡ΊπŸ‡ΈUnited States rclemings

Removing redundant content

πŸ‡ΊπŸ‡ΈUnited States rclemings

Reordering pages

πŸ‡ΊπŸ‡ΈUnited States rclemings

Reordering pages

πŸ‡ΊπŸ‡ΈUnited States rclemings

Reordering pages

πŸ‡ΊπŸ‡ΈUnited States rclemings

Reordering pages

πŸ‡ΊπŸ‡ΈUnited States rclemings

Reordering pages

πŸ‡ΊπŸ‡ΈUnited States rclemings

There appear to be some changes in CartEventSubscriber.php as of 8.x-2.36 (or maybe earlier). Here's a reroll against the current 8.x-2.x-dev.

πŸ‡ΊπŸ‡ΈUnited States rclemings

I'm seeing the same thing. The watchdog notice appears to have been added by the patch in issue #3337784.

πŸ‡ΊπŸ‡ΈUnited States rclemings

That would work fine for my case. As for deleting individual messages, would it be possible to store them in a token as a list, then delete them from Messenger and just reload the ones you need into Messenger from the token list?

πŸ‡ΊπŸ‡ΈUnited States rclemings

Patch in #40 works for me using mime_mail but with htmlmail it's the same as without the patch. Not clear why.

Drupal core 9.5.5
Mime Mail 8.x-1.0-alpha5
HTML Mail 8.x-3.0-alpha3

πŸ‡ΊπŸ‡ΈUnited States rclemings

Any update on this? It's been more than a year since the last comment and I've got to decide pretty soon what to do with a pending D7/9 upgrade.

πŸ‡ΊπŸ‡ΈUnited States rclemings

What if there are multiple tokens in the field? In my case the body field is not empty but some of the tokens within it can be empty (or null, rather). I was thinking I'd have to go through the tokens one at a time and changes the nulls to empties.

Production build https://api.contrib.social 0.61.6-2-g546bc20