Purpose of order receipt theme suggestions/overrides

Created on 12 March 2024, 4 months ago

Problem/Motivation

Just want to report that having the `hook_theme_suggestions_HOOK_alter` and receipt template in this module provided a poor DX for me. It took me a minute to realize this module was overriding the commerce (and my theme) templates because of the suggestion. Also, the template appears to be the exact same, so I'm not sure why this exists.

Proposed resolution

Remove the `hook_theme_suggestions_HOOK_alter` and template, let theme decide when and how to override the template.

You can close as designed or provide a reason for this since I'm not seeing. Just reporting that it caused me some extra time.

Thanks,
Andy

πŸ’¬ Support request
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States andyg5000 North Carolina, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @andyg5000
  • πŸ‡ΊπŸ‡ΈUnited States FatherShawn New York

    Hi - thanks for the feedback. I wrote that method 7 years ago, when this was a customization for client and not yet contributed, so my best guess is I needed it for that work.

    Perhaps the best DX solution at this point is to remove the template but leave the suggestion, since Commerce adds the order bundle type but not the gateway ID as a suggestion

Production build 0.69.0 2024