- Issue created by @rclemings
- First commit to issue fork.
- Merge request !18Issue #3469519 by rclemings, jurgenhaas: Restrict access to danse_user_notifications view β (Merged) created by jurgenhaas
- π©πͺGermany jurgenhaas Gottmadingen
I've provided an implementation for this by moving the access control from the SubscriberForm into the service class and then using that as an access control views plugin as well.
Note, you have to run the update script so that the views access control gets updated.
- Status changed to Needs review
3 months ago 8:43am 26 August 2024 - πΊπΈUnited States rclemings
Thanks for this. I was going to try to work on it this week but from the looks of it I don't think I would have gotten very far. It applies cleanly to DANSE v2.3.5 and with the update and a cache rebuild (maybe not needed?) it works. I'll leave it at "needs review" in case somebody else is watching.
- Status changed to RTBC
3 months ago 7:22am 27 August 2024 - π©πͺGermany jurgenhaas Gottmadingen
Thanks @rclemings for testing this. Yes, it turned out to be a bit more complex than I thought because we can't define the access control of a view in the routing file as the view itself overrides that. Therefore, I had to provide a view access plugin.
Happy to merge this as it is unlikely that anyone else came along in the foreseeable future.
-
jurgenhaas β
committed d6db2cb2 on 2.3.x
Issue #3469519 by jurgenhaas, rclemings: Restrict access to...
-
jurgenhaas β
committed d6db2cb2 on 2.3.x
- Status changed to Fixed
3 months ago 7:23am 27 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.