- Issue created by @rclemings
- Merge request !16Issue #3443829 by rclemings: Missing fixes for issue 3425881 (UI changes) β (Closed) created by rclemings
- Issue was unassigned.
- Status changed to Needs review
7 months ago 9:34pm 26 April 2024 - First commit to issue fork.
- Status changed to Needs work
7 months ago 7:43am 30 April 2024 - π©πͺGermany jurgenhaas Gottmadingen
Something was strange with this MR, it didn't look like it was properly based on 2.3.x - I tried to rebase, but I'm not sure if all your proposed changes are still in it. Could you please have another look and fix it, if any of my rebasing broke something for you?
- πΊπΈUnited States rclemings
I'm not sure. I see that 2.3.x-dev already has all of the fixes (except the possibly unneeded "title" argument at line 114). Is that what you needed me to check? Either way, it's working fine for me so I guess you can just ignore this MR. Sorry for the noise. Maybe I based it on 2.3.3 instead of 2.3.x-dev.
- π©πͺGermany jurgenhaas Gottmadingen
No worries, I'll close the MR and this issue. The extra title argument doesn't hurt and I'd rather keep that in, just in case something else needs it eventually.
- Status changed to Closed: works as designed
7 months ago 9:52am 1 May 2024