Contrib.social

Undefined array key "skip_on_nan" with eca_tamper:math

Open on Drupal.org →
Created on 2 March 2025, about 2 months ago

Problem/Motivation

Since upgrading tamper to 8.x-1.0-beta1 from 8.x-1.0-alpha5, I'm seeing this error for a model using the eca_tamper:math plugin:

Warning: Undefined array key "skip_on_nan" in Drupal\eca_tamper\Plugin\Action\Tamper->doTamper() (line 132 of /home/[accountname]/public_html/web/modules/contrib/eca_tamper/src/Plugin/TamperTrait.php)

The "skip_on_nan" key appears to have been introduced in tamper issue #3332785 → . I don't know whether the issue should be addressed there or here so I will flip a coin and post it here. Feel free to move it if it should be addressed in tamper instead.

#0 /home/[accountname]/public_html/web/core/includes/bootstrap.inc(166): _drupal_error_handler_real(2, 'Undefined array...', '/home/[accountname]/p...', 132)
#1 /home/[accountname]/public_html/web/modules/contrib/eca_tamper/src/Plugin/TamperTrait.php(132): _drupal_error_handler(2, 'Undefined array...', '/home/[accountname]/p...', 132)
#2 /home/[accountname]/public_html/web/modules/contrib/eca_tamper/src/Plugin/Action/Tamper.php(39): Drupal\eca_tamper\Plugin\Action\Tamper->doTamper('eca_data', 'eca_token_name')
#3 /home/[accountname]/public_html/web/modules/contrib/eca/src/Entity/Objects/EcaAction.php(107): Drupal\eca_tamper\Plugin\Action\Tamper->execute(NULL)
#4 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(298): Drupal\eca\Entity\Objects\EcaAction->execute(Object(Drupal\eca\Entity\Objects\EcaAction), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#5 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(300): Drupal\eca\Processor->executeSuccessors(Object(Drupal\eca\Entity\Eca), Object(Drupal\eca\Entity\Objects\EcaAction), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#6 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(300): Drupal\eca\Processor->executeSuccessors(Object(Drupal\eca\Entity\Eca), Object(Drupal\eca\Entity\Objects\EcaAction), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#7 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(300): Drupal\eca\Processor->executeSuccessors(Object(Drupal\eca\Entity\Eca), Object(Drupal\eca\Entity\Objects\EcaAction), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#8 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(300): Drupal\eca\Processor->executeSuccessors(Object(Drupal\eca\Entity\Eca), Object(Drupal\eca\Entity\Objects\EcaAction), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#9 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(300): Drupal\eca\Processor->executeSuccessors(Object(Drupal\eca\Entity\Eca), Object(Drupal\eca\Entity\Objects\EcaAction), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#10 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(300): Drupal\eca\Processor->executeSuccessors(Object(Drupal\eca\Entity\Eca), Object(Drupal\eca\Entity\Objects\EcaAction), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#11 /home/[accountname]/public_html/web/modules/contrib/eca/src/Processor.php(222): Drupal\eca\Processor->executeSuccessors(Object(Drupal\eca\Entity\Eca), Object(Drupal\eca\Entity\Objects\EcaEvent), Object(Drupal\commerce_order\Event\OrderEvent), Array)
#12 /home/[accountname]/public_html/web/modules/contrib/eca/src/EventSubscriber/DynamicSubscriber.php(39): Drupal\eca\Processor->execute(Object(Drupal\commerce_order\Event\OrderEvent), 'commerce_order....')
#13 [internal function]: Drupal\eca\EventSubscriber\DynamicSubscriber->onEvent(Object(Drupal\commerce_order\Event\OrderEvent), 'commerce_order....', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#14 /home/[accountname]/public_html/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Drupal\commerce_order\Event\OrderEvent), 'commerce_order....', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#15 /home/[accountname]/public_html/web/modules/contrib/commerce/modules/order/src/OrderStorage.php(139): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object(Drupal\commerce_order\Event\OrderEvent), 'commerce_order....')
#16 /home/[accountname]/public_html/web/modules/contrib/commerce/modules/order/src/OrderStorage.php(86): Drupal\commerce_order\OrderStorage->doOrderPreSave(Object(Drupal\commerce_order\Entity\Order))
#17 /home/[accountname]/public_html/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(529): Drupal\commerce_order\OrderStorage->invokeHook('presave', Object(Drupal\commerce_order\Entity\Order))
#18 /home/[accountname]/public_html/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php(753): Drupal\Core\Entity\EntityStorageBase->doPreSave(Object(Drupal\commerce_order\Entity\Order))
#19 /home/[accountname]/public_html/web/core/lib/Drupal/Core/Entity/EntityStorageBase.php(483): Drupal\Core\Entity\ContentEntityStorageBase->doPreSave(Object(Drupal\commerce_order\Entity\Order))
#20 /home/[accountname]/public_html/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php(806): Drupal\Core\Entity\EntityStorageBase->save(Object(Drupal\commerce_order\Entity\Order))
#21 /home/[accountname]/public_html/web/modules/contrib/commerce/modules/order/src/OrderStorage.php(169): Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object(Drupal\commerce_order\Entity\Order))
#22 /home/[accountname]/public_html/web/core/lib/Drupal/Core/Entity/EntityBase.php(354): Drupal\commerce_order\OrderStorage->save(Object(Drupal\commerce_order\Entity\Order))
#23 /home/[accountname]/public_html/web/modules/contrib/commerce/modules/payment/src/PaymentOrderUpdater.php(104): Drupal\Core\Entity\EntityBase->save()
#24 /home/[accountname]/public_html/web/modules/contrib/commerce/modules/payment/src/PaymentOrderUpdater.php(62): Drupal\commerce_payment\PaymentOrderUpdater->updateOrder(Object(Drupal\commerce_order\Entity\Order), true)
#25 /home/[accountname]/public_html/web/modules/contrib/commerce/modules/payment/src/PaymentOrderUpdater.php(115): Drupal\commerce_payment\PaymentOrderUpdater->updateOrders()
#26 /home/[accountname]/public_html/web/core/lib/Drupal/Core/DrupalKernel.php(723): Drupal\commerce_payment\PaymentOrderUpdater->destruct()
#27 /home/[accountname]/public_html/web/index.php(22): Drupal\Core\DrupalKernel->terminate(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\TrustedRedirectResponse))
#28 {main}

Steps to reproduce

Upgrade tamper to 8.x-1.0-beta1 and run a model using the eca_tamper:math plugin. At this point, I have seen it only with one model, which adds a year to a current-year token to create a next-year token. If I see it in other models I will update.

Proposed resolution

Can't offer one at this point; it's over my head.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States rclemings

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @rclemings
  • Comment about 2 months ago →
    🇺🇸United States rclemings

    I should add that the model still seems to work fine. The error just appears in the watchdog log.

  • Comment about 2 months ago →
    🇩🇪Germany jurgenhaas Gottmadingen

    Did you run drush eca:update? It looks like the tamper module has added a new config parameter and that requires existing models to be updated for that.

  • Comment about 2 months ago →
    🇺🇸United States rclemings

    Thanks, that worked.

    I'm not clear, though, on how I should have known to do that. Should I just run it routinely after any module is updated? (No ECA module was updated in this round.) Is there something I missed in the UI? Or should the tamper module have included an update hook?

  • Comment about 2 months ago →
    🇩🇪Germany jurgenhaas Gottmadingen

    There is not really much that can be done when third-party modules are changing themselves. In this case, the tamper module introduces a new config key, but they can't provide an update hook as they can't know what other modules are using them and what requirements they have.

    This is why ECA outputs a warning when it recognises that something got changed. And then the ECA update drush command is always handy. It outputs, if anything has changed and if you were interested in details, you could do a diff between the previous and current config entities.

    This will also be part of the ECA Guide. If you want to make the ECA update a permanent part of your update routine, there is nothing wrong with thath.

  • Comment about 1 month ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024