- Issue created by @zaporylie
- π΅π°Pakistan Qaiser iqbal
My suggestion would be to change the plugin id in https://git.drupalcode.org/project/field_validation/-/blob/3.0.x/src/Plu... to something like SymfonyCurrency (this is the root cause of the conflict) and in https://git.drupalcode.org/project/field_validation/-/blob/3.0.x/src/Plu...β¦]le/CurrencyConstraintFieldValidationRule.php?ref_type=heads make sure the updated constraint ID is utilized
- Merge request !9Issue #3377621: make "field validation rule" plugin support Constraint API,... β (Open) created by Unnamed author
- Status changed to Needs review
7 months ago 10:36am 22 July 2024 - Status changed to RTBC
3 months ago 7:10pm 13 November 2024 - π¨π¦Canada leducdubleuet Chicoutimi QC
I can confirm the fix is working as expected with version 3.0.0-beta4 and current Commerce 2.40.
Without this patch, you cannot put anything in your cart after enabling the module, this is quite major when using Commerce.
Thank you very much!
- π¨π³China g089h515r806
If some site already using "Currency" of Field Validation without commerce, update is a big problem for them if we rename the plugin id.
They will get a fatal error when update Field Validation.
Similar issueοΌ
https://www.drupal.org/project/field_validation/issues/3357511 π PluginNotFoundException: The "blacklist_field_validation_rule" plugin does not exist. Valid plugin IDs Closed: outdatedIF there is no site using "Currency" constraint of Field Validation , then we could rename it directly.
- π¨π¦Canada leducdubleuet Chicoutimi QC
The related issue π Compatibility issue with Address module Fixed had the same fix as this one but did not pose any problem then.
You said in comment #8 of the related issue :
> g089h515r806 commented 3 January 2024 at 01:27
> This change does not need a update path. But people need clear cache if they using this plugin.Why do this one is problematic now?
- π¨π¦Canada leducdubleuet Chicoutimi QC
What do you mean? I do not see your point?
Why only a clear cache was needed then and now it won't work?
This version is in beta, shouldn't people expect some potential breaking changes for exception like this one?
- π¨π³China g089h515r806
See issue :
https://www.drupal.org/project/field_validation/issues/3357511 π PluginNotFoundException: The "blacklist_field_validation_rule" plugin does not exist. Valid plugin IDs Closed: outdated
https://www.drupal.org/project/field_validation/issues/3281484 π Replace the term "blacklist" with "block list" FixedIf some site already using "Currency" constraint of Field validation, not use commerce. They will get fatal error, if the plugin name renamed.
- π¨π³China g089h515r806
You can write a update doc for them, then I commit this change, and add the doc link in the next release notes.
They need copy the old constraint to the new version of field validation, then re-config it using the rename version plugin.
- π¨π³China g089h515r806
An error occurred while merging.
The MR not works with latest code.
- π¨π³China g089h515r806
I read the source code of 3.x ,It seems that this is right:
"
This change does not need a update path. But people need clear cache if they using this plugin.
"
I try to merge it. But the MR can not be merged. - Status changed to Needs review
6 days ago 10:56pm 17 February 2025 - πΊπΈUnited States rclemings
Just bumping this because it's been almost three months since the last activity and v3.0.0 is needed for Drupal 11 compatibility. Happy to try to assist with testing or other needs, but the simple (one line in each of two files) patch from the merge request works fine for me with 3.0.0-beta4 .
Also changing priority to major because, as noted in comment #5:
Without this patch, you cannot put anything in your cart after enabling the module, this is quite major when using Commerce.
Also changing status to "needs review" because I can't see what work is left except the issue in comment #11, which if valid, might be handled with a change record.