Don't hide permissions local tasks on bundles when no permissions are defined

Just to get things started.

Seems not having a return caused a CC failure.

I think instead of this we should stop using EntityPermissionsRouteProvider and deprecate it entirely. in 11.x, only comment and contact still do that, block_content now always has permissions, so I think that most people who had this issue did so because they had a lot of block content types, and that's already gone in 11.x.

The parent class already has the permission check, we just added that as a duplicate condition so we wouldn't run the extra access checks when we knew that access is going to be denied.

Oh that makes more sense. Something like this.

Yeah. I expect we should see some test fails with this which we have to update and then add an empty message to the permission table.

For test update.

Promoting this to a bug after discussion on 🐛 Don't hide permissions local tasks on bundles when no permissions are defined Needs work , this is causing WSOD on some sites.

catch - you linked to this issue instead of what you intended to

The issue that @catch wanted to link to is 🐛 [Config] Warning: Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies. Active .

I added an empty message to the page and updated to test to check for that instead of an access denied response.

I also updated the call in \Drupal\user\Form\EntityPermissionsForm::permissionsByProvider() to use findConfigEntityDependenciesAsEntities() instead of getConfigEntitiesToChangeOnDependencyRemoval(), which would likely already fix that other issue, but it's IMHO still too heavy as an access operation that's run on possibly dozens of links when using admin_toolbar.

deprecation message versions will need to be updated to 11.0/12.0 I guess. Leaving that for someone else while I get some sleep.

This is an interesting one as the other issue is currently critical and this is kind of the only fix for that, but it introduces deprecations and new UI text as well. The deprecation we could in theory just drop for a 10.3 commit, the empty message seems useful enough to have, although it possibly could be improved a bit.

I don't fully understand what exactly changed in 10.3, this already was an issue back in 9.4 when this stuff was originally added.

As a bug could the issue summary be filled out some please

Patch #5 fixes the problem described in https://www.drupal.org/project/drupal/issues/3306434 🐛 [Config] Warning: Entity view display 'node.article.default': Component 'comment' was disabled because its settings depend on removed dependencies. Active that started happening when updating from 10.2 to 10.3

When trying to apply the patch 3384600-5.patch, it errors out with "can't find file to patch at input line 14". Any idea why?

Left a comment in the MR.