Needs rebasing, but I'll wait for some of the other sibling issues to land before doing so.
Otherwise we're entering rebase-ception land.
HEAD unbroken, rebased
Added missing files to the 10.5.x MR, but that branch seems to have a broken HEAD:
https://www.drupal.org/project/drupal/issues/3488179#comment-15863742
🐛
RecipeConfigurator::getIncludedRecipe() should statically cache recipe objects to avoid performance problems
Active
Looks like this broke HEAD of 10.5.x: https://git.drupalcode.org/project/drupal/-/pipelines/343235
In an unrelated MR elsewhere I'm also consistently hitting the exact same error
In InputConfigurator.php line 137:
Input values cannot be changed once they have been set.
recipe [-i|--input INPUT] [--] <path>
in both core/tests/Drupal/FunctionalTests/Core/Recipe/CoreRecipesTest.php and core/tests/Drupal/FunctionalTests/Core/Recipe/StandardRecipeTest.php.
Didn't check but I can imagine the same thing happening in 10.4.x?
Opened MR!10246 to add the missing JS files to 11.x, hoping that it's a 1-on-1 backport to 11.1.x.
I've changed my local, faulty .gitignore so this won't happen again.
All credits for finding out about this distaster-in-progress to @nod_!
Discussed this with @nod_ in Slack, and, of course he was right.
Adding an MR with the MIA files now.
hang on, yarn vendor-update was not run on 11.x, lots of new languages were added. So we're missing translation files
yarn build was run on 11.x here:
https://git.drupalcode.org/project/drupal/-/merge_requests/10190/diffs?c...
yarn build includes yarn vendor-update.
So I'm confused now, what files are missing and do they turn up when you do a yarn build on 11.x?
Do the turn up if you do a yarn vendor-update on 11.x?
If the first question is answered with a yes, I messed it up.
Anything else, I'm scratching my head.
Oops
Well, the bump in 10.5.x has surprisingly little, as in none at all, effect on the CSS files in there.
So it already landed in 11.1.x, so making an MR for 10.5.x and am pretty hopeful this can be backported to 10.4.x easily.
Personally I think we might wanna backport this to 11.1.x, 10.5.x and 10.4.x
(Oh, the joy off multiple active main branches...)
I'll put MRs up for all three of them and let y'all decide.
Thanks @nod, do we want to backport this down to other branches?
No, bad bot!
Well, that required a lot more elbow grease than I expected/needed, but the errors are gone.
Same happens here. I think it has something to do with the fact I mistakenly started with a $ $ yarn upgrade-interactive, ehich is more/only for yarn 4.x
Let's start with a new MR.
Assuming the word changes are either the file out of sync or maybe cspell updated their internal dictionaries?
The latter for sure, that's the main part of each new minor bump in cspell.
The first part: No clue, maybe, maybe not.
IMHO the output on GitLab is what matters, the grimy internal format to get there is less relevant.
The output on GitLab is advertised in its own repo as looking something like this:
Screenshot from repo
And in our own drupal CSS Linting job: https://git.drupalcode.org/issue/drupal-3487817/-/pipelines/340184/codeq...
Do we add test coverage for new features added?
AFAICT we never did with previous bumps. although the idea is not without its merits.
I fear however, if we did, we'd be about just finished with defining and implementing the tests when a new version comes out.
Anyway: n=1, mileage may vary, yada yada.
Postponed on the landing of
📌
stylelint-formatter-gitlab prevents updating stylelint
Active
since leon0399/stylelint-formatter-gitlab does not work with stylelint versions above 15.x.
Mirroring status of parent issue, which became critical.
Mirroring status of parent issue, which became critical.
Mirroring status of parent issue, which became critical.
Mirroring status of parent issue, which became critical.
Mirroring status of parent issue, which became critical.
MR !10129 shows that when there are no errors, stuff doesn't break.
This run of another issue show that it can actually detect and report issues: https://git.drupalcode.org/issue/drupal-3487817/-/pipelines/340184/codeq...
That report does indeed look like the example report given here: https://gitlab.com/gitlab-formatters/stylelint-formatter-gitlab/-/merge_...
Green enough for me!
Updated @ckeditor/*, ckeditor5 and webpack to their latest releases.
smustgrave → credited spokje → .
$ composer-lock-diff --no-links
+---------------------------------+--------------+------------+
| Production Changes | From | To |
+---------------------------------+--------------+------------+
| symfony/console | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/dependency-injection | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/error-handler | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/event-dispatcher | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/filesystem | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/finder | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/http-foundation | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/http-kernel | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/mailer | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/mime | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/process | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/psr-http-message-bridge | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/routing | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/serializer | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/string | v7.1.6 | v7.1.8 |
| symfony/validator | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/var-dumper | v7.2.0-BETA2 | v7.2.0-RC1 |
| symfony/yaml | v7.2.0-BETA1 | v7.2.0-RC1 |
+---------------------------------+--------------+------------+
+----------------------+--------------+------------+
| Dev Changes | From | To |
+----------------------+--------------+------------+
| symfony/browser-kit | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/css-selector | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/dom-crawler | v7.2.0-BETA1 | v7.2.0-RC1 |
| symfony/lock | v7.2.0-BETA1 | v7.2.0-RC1 |
+----------------------+--------------+------------+
Thanks @andypost!
Of course this is an ongoing battle: https://github.com/symfony/symfony/releases/tag/v6.4.15
Updated MR and #4 📌 Update Composer dependencies for 10.4.0-beta1 Active
Here's the upstream issue: https://github.com/mglaman/phpstan-drupal/issues/806
Rebased and updated #4
Rebased and updated #4.
spokje → changed the visibility of the branch 3486550-update-composer-dependencies to active.
edit: crossposted, but this still applied cleanly even after the other issue landed.
Rebased a while before I commented, in between that and your commit was first forgetting about and then frantically rerunning failed tests to get green again.
It all worked out just fine :)
Rebased after 📌 Update to Symfony 7.2.0-BETA2 Active landed.
Thanks for the manual work on 11.x @catch, much appreciated.
TBH: I don't know, but much more important, these are all "automagically" made changes by yarn build:css after I did the update of canisuse.
So even if it is indeed better to make that change, and again, I really am not a FE-person, so I have no clue, I believe that would be something for a follow-up issue?
(And I'm not even really sure about that one either...)
Bad bot, get out!
Also: Do we want/are allowed to make the major jump to 2.x for PHPStan in the 10.x branch?
Seeing the same behaviour as #16, rerolled MR!69 for 3.1.x-dev