[random test failure] BlockCacheTest

https://git.drupalcode.org/issue/drupal-3390360/-/jobs/2484193 shows 4 failures in 1500x only Drupal\Tests\block\Functional\BlockCacheTest::testCachePermissions (MR here: https://git.drupalcode.org/project/drupal/-/merge_requests/9253/diffs).

So it _could_ be happening more often due to timing issues when running along other tests, running this test alone (although *often*) would trigger it.

See also https://git.drupalcode.org/issue/drupal-2630732/-/jobs/3310474 for related fails in BlockCacheTest::testCachePerPage()

spokje → changed the visibility of the branch 3468830-random-test-failure to hidden.

Should be solved by 🐛 [random test failure] LayoutBuilderBlocksTest::testBlockPlaceholder failing Active

spokje → changed the visibility of the branch 11.x to hidden.

MR !10698 (which is basically \Drupal\Tests\block\Functional\BlockCacheTest trimmed down to only contain testCachePermissions() and some pipeline changes to make it, and only it, run 2500 times) gives us 8 fails out of the 2500 runs.
MR !10699 shows that changing \Drupal::state()->set()/get() to Drupal::keyValue()->set()/get(); as suggested in the Slack thread passes a 2500 times run without errors.

Which shows to me that when 🐛 [random test failure] LayoutBuilderBlocksTest::testBlockPlaceholder failing Active lands, this issue should be solved.

Re #7, 🐛 [random test failure] LayoutBuilderBlocksTest::testBlockPlaceholder failing Active also makes changes for that method, so the random failures there also should be gone.

spokje → closed merge request !10698

spokje → closed merge request !10699

Should be fixed with the commit of 🐛 [random test failure] LayoutBuilderBlocksTest::testBlockPlaceholder failing Active

Automatically closed - issue fixed for 2 weeks with no activity.