- Issue created by @spokje
- Merge request !10192Draft: Everything to the max, except eslint which is bumped to the latest ^8 release β (Closed) created by spokje
- π¬π§United Kingdom longwave UK
Thanks for posting this and working on the child issues. Bumping to critical as we really should get this done for rc1.
- π©πͺGermany rkoller NΓΌrnberg, Germany
I've opened π Update to jQuery 1.14.1 and use the newly added option for dialog modal headings Active right after the release of jquery ui 1.14.1. @benjifisher recommended today i should be looking for a "Update JavaScript dependencies" issue, which lead me here. just wanted to note that that the issue i've linked is not only about updating jquery ui to the latest version, but jqueryui introduced a setting that enables choosing into which element the dialog modal title should be wrapped. pre 1.14.1 that was a
span
which is semantically wrong and an accessibility issue. my question is how to proceed? should i rescope the issue i've created and make it only about the addition of that option tocore/misc/dialog/dialog.jquery-ui
but then it wouldnt make it into 11.1 i suppose? for 11.0 there was a similar case where jquery ui 1.14.0 added the option for adding thearia-modal
attribute to dialog modals. that option was added on the issue upgrading to 1.14.0 directly. so just wanted to post here as a headsup. in regards for changing the wrapping element of the title from a span to an h1 @mgifford already commented on π Update to jQuery 1.14.1 and use the newly added option for dialog modal headings Active and is also in the loop of that change. - πΊπΈUnited States benjifisher Boston area
The first line of the issue summary ends with 11.0.0. I am updating it to 11.1.0, to match the title.
- π³πΏNew Zealand quietone
RC! has been released, so changing title
- π³πΏNew Zealand quietone
Changing to fixed here because this was useful for coordinating the work on this topics and in the child issues.
Automatically closed - issue fixed for 2 weeks with no activity.