[random test failure] LanguageNegotiationInfoTest::testInfoAlterations

By changing \Drupal\Tests\language\Functional\LanguageNegotiationInfoTest::testInfoAlterations we also change \Drupal\Tests\comment\Functional\CommentLanguageTest, so we need to include both in our multiple runs.

MR !10733 (which is basically \Drupal\Tests\language\Functional\LanguageNegotiationInfoTest::testInfoAlterations and \Drupal\Tests\comment\Functional\CommentLanguageTest and some pipeline changes to make both, and only both, run 3000 times) gives us 2b fails out of the 3000 runs.

MR !10734 shows that changing \Drupal::state()->set()/get() to Drupal::keyValue()->set()/get(); passes a 3000 times + 5000 times run without errors. (The fail rate as so low that I've ran it twice)

MR !10731 contains the changes we want committed after review.

Based on the other ones and @spokje excellent work in #5 breaking it down, clearly this is a net gain.

Committed to 11.x and backported to 11.1.x - nice one 😎

larowlan → closed merge request !10735

larowlan → changed the visibility of the branch 3496438-multi-run-key-value to hidden.

larowlan → changed the visibility of the branch 3496438-multi-run-as-is to hidden.

To keep in line ay want to backport these random-state-failures as far back as 10.3.x?

We have been doing that we all the other fixes that landed so far.

spokje → changed the visibility of the branch 11.x to hidden.

Ah, I see the MR doesn't cleanly apply to 11.0.x and lower, due to the OOP-ing of hooks.

We've been there before in other issues, and if it's anything similar as those, the 11.0.x MR will backport down to 10.3.x without issues.

For the backport

Committed/pushed to 11.0.x and cherry-picked back through to 10.3.x for hopefully happier branch pipeline runs.

catch → closed merge request !10774