Fix 'Drupal.Commenting.InlineComment.InvalidEndChar' coding standard

Created on 5 May 2016, over 8 years ago
Updated 15 August 2024, 5 months ago

Problem/Motivation

Follow-up to 📌 Fix 'Drupal.Commenting.InlineComment.SpacingAfter' coding standard Active

Part of 🌱 [meta] Fix PHP coding standards in core Active .

In line comments are missing the final final stop to complete the sentence.

Steps to reproduce

Proposed resolution

Enable Fix 'Drupal.Commenting.InlineComment.InvalidEndChar

Remaining tasks

Postponed on Code issue 📌 Improve the cspell exception in Drupal.Commenting.InlineComment.InvalidEndChar Active

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

📌 Task
Status

Postponed

Version

11.0 🔥

Component
Other  →

Last updated 8 minutes ago

Created by

🇫🇷France andypost

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • Status changed to Needs review 6 months ago
  • 🇳🇿New Zealand quietone

    No longer postponed. I rebased onto 11.x

  • Status changed to RTBC 6 months ago
  • 🇺🇸United States smustgrave

    Was a large MR to review but was easy. If anyone curious what the extra deletion is from

    core/modules/pgsql/src/Driver/Database/pgsql/Connection.php deleted a commented out elseif line

  • Status changed to Needs work 5 months ago
  • 🇬🇧United Kingdom longwave UK

    Some feedback where the change makes the comment misleading - generally where we are listing punctuation in some way - plus some nitpicks and some weird cases where only some comments appear to be taken into account (especially in TaxonomyFieldAllTermsTest and EntityQueryTest).

  • Assigned to quietone
  • 🇳🇿New Zealand quietone

    I set this to NR for initial feedback because all I did was create and MR for the latest patch. I didn't expect it to become RTBC. Now that I look more closely the first thing I see is that the sniff is not enabled!

    I will assign to myself and clean this up.

  • 🇳🇿New Zealand quietone

    When autofixing a full stop is added to cspell ignore lines

    // cSpell:ignore TÉXT äöüåøhello aouaohello aeoeueaohello Pácê.

    which results in spelling errors.
    core/modules/file/tests/src/Unit/SanitizeNameTest.php:102:13 - Unknown word (Pácê)

  • 🇳🇿New Zealand quietone

    Found 📌 Improve the cspell exception in Drupal.Commenting.InlineComment.InvalidEndChar Active which explains why only some cspell lines are failing. The sniff ignores lines where cspell is all lower case.

  • Issue was unassigned.
  • Status changed to Postponed 5 months ago
  • 🇳🇿New Zealand quietone

    But there are other problems with the sniff. Therefor postponing on the Coder issue.

  • Pipeline finished with Success
    4 months ago
    Total: 3032s
    #281377
  • Pipeline finished with Success
    4 months ago
    Total: 182s
    #294393
  • Pipeline finished with Failed
    12 days ago
    Total: 744s
    #385095
  • Pipeline finished with Canceled
    12 days ago
    Total: 964s
    #385149
  • Pipeline finished with Failed
    11 days ago
    Total: 751s
    #385161
  • Pipeline finished with Success
    11 days ago
    Total: 1503s
    #385177
  • Pipeline finished with Canceled
    9 days ago
    Total: 139s
    #387345
  • Pipeline finished with Failed
    9 days ago
    Total: 1219s
    #387347
  • Pipeline finished with Failed
    9 days ago
    Total: 648s
    #387371
  • Pipeline finished with Failed
    9 days ago
    Total: 1404s
    #387377
  • Pipeline finished with Success
    9 days ago
    Total: 771s
    #387425
  • Pipeline finished with Canceled
    9 days ago
    Total: 111s
    #387482
  • Pipeline finished with Canceled
    9 days ago
    Total: 450s
    #387484
  • Pipeline finished with Canceled
    9 days ago
    Total: 266s
    #387493
  • Pipeline finished with Success
    9 days ago
    Total: 969s
    #387497
Production build 0.71.5 2024