Fix 'Drupal.Commenting.InlineComment.InvalidEndChar' coding standard

No longer postponed. I rebased onto 11.x

Was a large MR to review but was easy. If anyone curious what the extra deletion is from

core/modules/pgsql/src/Driver/Database/pgsql/Connection.php deleted a commented out elseif line

Some feedback where the change makes the comment misleading - generally where we are listing punctuation in some way - plus some nitpicks and some weird cases where only some comments appear to be taken into account (especially in TaxonomyFieldAllTermsTest and EntityQueryTest).

I set this to NR for initial feedback because all I did was create and MR for the latest patch. I didn't expect it to become RTBC. Now that I look more closely the first thing I see is that the sniff is not enabled!

I will assign to myself and clean this up.

When autofixing a full stop is added to cspell ignore lines

// cSpell:ignore TÉXT äöüåøhello aouaohello aeoeueaohello Pácê.

which results in spelling errors.
core/modules/file/tests/src/Unit/SanitizeNameTest.php:102:13 - Unknown word (Pácê)

Found 📌 Improve the cspell exception in Drupal.Commenting.InlineComment.InvalidEndChar Active which explains why only some cspell lines are failing. The sniff ignores lines where cspell is all lower case.

But there are other problems with the sniff. Therefor postponing on the Coder issue.

No longer postponed.

I rebased and fixed the remaining.

Reviewing this.

Been over 5 days so going to pick

Changes appear to be pretty 1 to 1. The extra deletions coming from core/lib/Drupal/Core/DrupalKernel.php.

Previous threads still appear to be open, 1-2 seem relevant

If you are another contributor eager to jump in, please allow the previous poster at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!

Responded to longwave's feedback.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebase

I think this looks good. It does what it is supposed to do.

There are eight unresolved threads in the MR. So I don't think this should be set to RTBC until those are addressed and closed. In contrib MRs you can set push rules to prevent merging when there are open threads, but I'm not sure if that is done in the Core workflow. But in anycase those comments should be checked, and closed if done. But I don't they all can be closed yet.

I think on every open comment there was a change already, but the comment was still left open.
Only your comment is still open, so I will put it back to needs work

Thanks but many of the comments were not addressed, even if there was a later change. I've been through the entire list of chnages, and opened some more threads. It would be great if those who opened the earlier ones could check their own and close them when solved. Then we can really use the open threads as the driver to finally get this issue fixed.

@jonathan1055, thanks for the detailed review!

I agree it would help if reviewers would resolve comments. Thanks.

Tried to resolve the threads but some wasn't 100% sure on.

Excellent, you've reduced it from 24 unresolved threads to just 9.

One odd thing I commented on is why it appears that the 'Docblock' sniff is being excluded here?
https://git.drupalcode.org/project/drupal/-/merge_requests/505#note_477884

There are different views here about how to format lists in in-line comments. So, I am going to make a child issue to fix the easy one. That child won't be able to enable the sniff but it will reduce the noise on this MR.