- Merge request !505Issue #2719663: Fix 'Drupal.Commenting.InlineComment.InvalidEndChar' coding standard → (Open) created by Spokje
- First commit to issue fork.
- Status changed to Needs review
about 1 month ago 4:35am 27 July 2024 - 🇳🇿New Zealand quietone New Zealand
No longer postponed. I rebased onto 11.x
- Status changed to RTBC
about 1 month ago 2:04pm 29 July 2024 - 🇺🇸United States smustgrave
Was a large MR to review but was easy. If anyone curious what the extra deletion is from
core/modules/pgsql/src/Driver/Database/pgsql/Connection.php deleted a commented out elseif line
- Status changed to Needs work
24 days ago 9:52pm 14 August 2024 - 🇬🇧United Kingdom longwave UK
Some feedback where the change makes the comment misleading - generally where we are listing punctuation in some way - plus some nitpicks and some weird cases where only some comments appear to be taken into account (especially in TaxonomyFieldAllTermsTest and EntityQueryTest).
- Assigned to quietone
- 🇳🇿New Zealand quietone New Zealand
I set this to NR for initial feedback because all I did was create and MR for the latest patch. I didn't expect it to become RTBC. Now that I look more closely the first thing I see is that the sniff is not enabled!
I will assign to myself and clean this up.
- 🇳🇿New Zealand quietone New Zealand
When autofixing a full stop is added to cspell ignore lines
// cSpell:ignore TÉXT äöüåøhello aouaohello aeoeueaohello Pácê.which results in spelling errors.
core/modules/file/tests/src/Unit/SanitizeNameTest.php:102:13 - Unknown word (Pácê) - 🇳🇿New Zealand quietone New Zealand
Found 📌 Improve the cspell exception in Drupal.Commenting.InlineComment.InvalidEndChar Active which explains why only some cspell lines are failing. The sniff ignores lines where cspell is all lower case.
- Issue was unassigned.
- Status changed to Postponed
24 days ago 12:31pm 15 August 2024 - 🇳🇿New Zealand quietone New Zealand
But there are other problems with the sniff. Therefor postponing on the Coder issue.