Add deprecations for update to behat/* dependencies

Created on 13 February 2024, about 1 year ago

Problem/Motivation

This is a follow-up to add deprecations due to updating our behat/* dependencies. This was a tricky update because the dependencies introduced a lot of strict typehinting in a minor version. 📌 Update Behat from 1.10 to 1.11 Active does the minimal change in order to do the updates and have core tests pass. This issue will add deprecations so we can remove overrides of behat methods in a future release.

Proposed resolution

Turn @todo's into deprecations.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component
PHPUnit 

Last updated about 12 hours ago

Created by

🇬🇧United Kingdom alexpott 🇪🇺🌍

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alexpott
  • 🇬🇧United Kingdom alexpott 🇪🇺🌍
  • Status changed to Closed: duplicate 11 months ago
  • Status changed to Active 4 months ago
  • 🇳🇱Netherlands spokje

    Seems 📌 When using drupalGet(), provide an associative array for $headers Fixed went into a different direction as #3 intended, there are still six TODO's left pointing to this issue.

    These TODO's are all about deprecating passing non-string values to string-only parameters.

    This issue will add a deprecation for removal in 12.0.0 to the current BC-layer.

  • 🇳🇱Netherlands spokje

    Not quite sure how to handle the new stronger typing, also some/many methods can be removed from our code and reference the behat-ones in 12.0.0.

  • Merge request !10671First stab → (Open) created by spokje
  • Pipeline finished with Failed
    4 months ago
    Total: 739s
    #378049
  • Pipeline finished with Failed
    4 months ago
    Total: 768s
    #378073
  • Pipeline finished with Failed
    4 months ago
    Total: 478s
    #378354
  • Pipeline finished with Failed
    4 months ago
    #378361
  • Pipeline finished with Failed
    4 months ago
    Total: 555s
    #378396
  • Pipeline finished with Failed
    4 months ago
    Total: 559s
    #378407
  • Pipeline finished with Failed
    4 months ago
    Total: 590s
    #378412
  • Pipeline finished with Failed
    4 months ago
    Total: 814s
    #378426
  • Pipeline finished with Failed
    4 months ago
    Total: 1915s
    #378431
  • Pipeline finished with Failed
    4 months ago
    #378439
  • Pipeline finished with Failed
    4 months ago
    #378449
  • Pipeline finished with Success
    4 months ago
    Total: 3888s
    #378454
  • 🇺🇸United States smustgrave

    Deprecations appear to be correct.

    Question though should follow up be made for tests that had to be typecasted?

  • Pipeline finished with Success
    4 months ago
    Total: 4972s
    #385592
  • 🇳🇿New Zealand quietone

    Yes, this looks correct. But I do think the deprecation messages should be adjusted. The sentence, 'There is no replacement' is better suited to method removal. See the comment in the MR

Production build 0.71.5 2024