- Issue created by @spokje
- Merge request !10731\Drupal::state()-get()/set() to Drupal::keyValue()->get()/set() → (Closed) created by spokje
- 🇳🇱Netherlands spokje
MR !10728 (which is basically
\Drupal\Tests\editor\Functional\EditorSecurityTest::testEditorXssFilterOverrideand some pipeline changes to make it, and only it, run 7500 times) gives us 325 fails out of the 10000runs.MR !10729 shows that changing \Drupal::state()->set()/get() to Drupal::keyValue()->set()/get(); passes a 10000 times run without errors.
MR !10731 contains the changes we want committed after review.
- 🇺🇸United States smustgrave
Reviewed MR 10731 and update to keyValue makes sense
MR !10729 shows that changing \Drupal::state()->set()/get() to Drupal::keyValue()->set()/get(); passes a 10000 times run without errors.
Awesome!
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!
Looks like this needs a backport for 11.0.x/10.5.x.
- 🇳🇱Netherlands spokje
Looks like HEAD broken on 11.0.x: https://www.drupal.org/project/drupal/issues/3490710#comment-15922094 🐛 Catch potential exception when calling Request::create() in PathBasedBreadcrumbBuilder Needs review , so we're stalled here.
- 🇬🇧United Kingdom catch
Committed/pushed to 10.5.x/10.4.x/11.0.x/10.3.x, thanks!
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Replace calls to State with calls to KeyValue.
The root cause of this issue is discussed in 🐛 Race conditions/bad lock logic in CacheCollector/State Active
🤯
As a fellow maintainer of the
editormodule, I reviewed this commit. And I don't understand what the change is about. I'll follow that issue then 😳 Automatically closed - issue fixed for 2 weeks with no activity.
