- Issue created by @mstrelan
- 🇦🇺Australia mstrelan
- 🇦🇺Australia mstrelan
mstrelan → changed the visibility of the branch 11.x to hidden.
- Status changed to Needs work
about 1 year ago 3:59am 18 January 2024 - 🇦🇺Australia mstrelan
Not sure the best way to split this, so just started working on it. We can cherry-pick each fix to separate issues if we need to split it.
- 🇦🇺Australia mstrelan
I don't think we need
checkArgumentsPassedByReference
here as that isn't affected by strict types (AFAIK). - 🇦🇺Australia mstrelan
Removed the bit about excluding tests. Tests call out to non-test code, and there can exist errors.
- 🇦🇺Australia mstrelan
I rebased the MR hoping to see the number of errors go down since 📌 Fix more var and param docs identified by phpstan Active , but it's actually gone up from 381 to 436.
- 🇳🇱Netherlands spokje
@mstrelan: Meh! Are the new additions all in the var/param docs region? Or were there a lot of additions to the baseline during that period?
- 🇦🇺Australia mstrelan
@spokje I didn't look at what they were. It wouldn't have been baseline additions, because these issues are only reported once the config is changed as per the MR here.