- Issue created by @mstrelan
- @mstrelan opened merge request.
- Status changed to Needs review
2 months ago 5:55am 10 September 2024 - Status changed to RTBC
2 months ago 4:31pm 13 September 2024 - 🇺🇸United States smustgrave
Seems pretty straight forward
Checked an older pipeline from the parent issue https://git.drupalcode.org/issue/drupal-3404246/-/jobs/2138635 and see the issues mentioned.
- 🇦🇺Australia mstrelan
I don't necessarily agree that this needs a follow up, it's more that a random issue was identified in the course of working on this issue, and it would be a good thing to do to create the follow up.
So here it is 📌 Remove $message param from \Drupal\Tests\comment\Functional\CommentTestBase::setCommentSettings Active .
- 🇳🇿New Zealand quietone
Good point and I will choose my words more carefully next time.
- 🇦🇺Australia mstrelan
Rebased and addressed feedback. Let's see if tests pass using empty strings where we had NULLs. It might be better to put the machine name as the label, or a human readable name, but it doesn't seem like the label is useful for these tests.
- 🇺🇸United States smustgrave
Sorry for the noise of assigning/un-assigning accidentally clicked the button. Cleaned up the threads some.
Believe feedback from @larowlan has been addressed
