- Issue created by @mstrelan
- 🇦🇺Australia mstrelan
Actually, it would be better if there is an existing "remove unused params" issue. Maybe that already exists.
- Merge request !97453478418: Remove param from setCommentSettings → (Open) created by samit.310@gmail.com
- 🇮🇳India samit.310@gmail.com
Hi @mstrelan,
I tried to find existing "remove unused params" issue related to this, not gets succeeded.
So i have created PR for the same.
Thanks
Samit K. - 🇺🇸United States smustgrave
Should deprecate the variable from setCommentSettings then.
- 🇮🇳India samit.310@gmail.com
Hi @smustgrave,
I have update my code to Deprecate the
$messageproperty, Update the title as well.Also create the change record page https://www.drupal.org/node/3479310 → .
Thanks
Samit K. - 🇦🇺Australia mstrelan
Do we need to deprecate params in tests? I found a few contribs that would be affected, so I guess it would be useful.
https://git.drupalcode.org/search?group_id=2&scope=blobs&search=%22setCo...
- 🇺🇸United States smustgrave
Would agree
But think the tests need to be fixed and not just adding expectDeprecation to every test failure. This feels we are losing a good amount of coverage.