- Issue created by @mstrelan
- Status changed to Needs review
about 2 months ago 10:21pm 23 July 2024 - π¦πΊAustralia mstrelan
Annotated the MR to make it easy to understand why each of the param docs needed changing.
- Status changed to RTBC
about 1 month ago 1:52pm 29 July 2024 - πΊπΈUnited States smustgrave
Much appreciate @mstrelan for doing the review also :)
I agree the type updates are correct in the comments. Now if the functions really shouldn't accept these types believe those can all be follow ups as your findings show code uses them in a certain way.
- Status changed to Fixed
about 1 month ago 2:24pm 6 August 2024 - Status changed to RTBC
about 1 month ago 10:30pm 6 August 2024 - π¬π§United Kingdom longwave UK
IMHO as a docs fix this can be backported down, to help make future cherry-picks easier.
- π«π·France nod_ Lille
actually one change doesn't conform to our coding standard, reverting for now.
- Status changed to Needs work
about 1 month ago 11:16pm 6 August 2024 - Status changed to RTBC
about 1 month ago 11:23pm 6 August 2024 - π¦πΊAustralia mstrelan
Curious which change was non-conformant? I'm guessing maybe
array<string, string|false>
. If that's the case, we need to change our coding standards, or rather, we shouldn't be the ones dictating how to write @param docs, we should rely on what phpcs and phpstan accepts. - Status changed to Needs work
24 days ago 2:07am 15 August 2024 - π³πΏNew Zealand quietone New Zealand
Setting to NW for another look at one comment.
- Status changed to Needs review
24 days ago 3:30am 15 August 2024 - π¦πΊAustralia mstrelan
Opened #3468236: Adopt phpstan phpdoc types as canonical reference of allowed types β for follow up. Left some responses on the MR. Personally I feel it should go in as-is and anything else should be a follow-up.
- Status changed to RTBC
20 days ago 1:55pm 18 August 2024 - πΊπΈUnited States smustgrave
If I'm understanding correct there is no official coding standard around the one change in question. So would agree that probably makes sense to go in as is to get some net improvement. And if the rule gets adopted can update, would assume there would then be a whole other set of files that will need to be updated. Just my 2cents.
- Status changed to Fixed
16 days ago 2:33pm 22 August 2024 - π«π·France nod_ Lille
Discussed on slack, +1 from longwave for commit. Follow-up for coding standard is created.
Committed and pushed fa418559a4 to 11.x and 948c93276e to 11.0.x and 224c7ea5f0 to 10.4.x and c7a2f29450 to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.