Fix param docs identified by phpstan

Annotated the MR to make it easy to understand why each of the param docs needed changing.

Much appreciate @mstrelan for doing the review also :)

I agree the type updates are correct in the comments. Now if the functions really shouldn't accept these types believe those can all be follow ups as your findings show code uses them in a certain way.

nod_ → closed merge request !8898

Committed e07e27a and pushed to 11.x. Thanks!

IMHO as a docs fix this can be backported down, to help make future cherry-picks easier.

actually one change doesn't conform to our coding standard, reverting for now.

nod_ → reopened merge request !8898

sorry for the noise, last update

Curious which change was non-conformant? I'm guessing maybe array<string, string|false>. If that's the case, we need to change our coding standards, or rather, we shouldn't be the ones dictating how to write @param docs, we should rely on what phpcs and phpstan accepts.

Setting to NW for another look at one comment.

Opened #3468236: Adopt phpstan phpdoc types as canonical reference of allowed types → for follow up. Left some responses on the MR. Personally I feel it should go in as-is and anything else should be a follow-up.

If I'm understanding correct there is no official coding standard around the one change in question. So would agree that probably makes sense to go in as is to get some net improvement. And if the rule gets adopted can update, would assume there would then be a whole other set of files that will need to be updated. Just my 2cents.

nod_ → closed merge request !8898

Discussed on slack, +1 from longwave for commit. Follow-up for coding standard is created.

Committed and pushed fa418559a4 to 11.x and 948c93276e to 11.0.x and 224c7ea5f0 to 10.4.x and c7a2f29450 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.