- Issue created by @kaipipek
- πΊπΈUnited States rclemings
This looks like the problem -- committed but not released yet.
https://www.drupal.org/project/commerce/issues/3464144 π Replace UserAuthInterface with UserAuthenticationInterface for Drupal 11 Support Fixed
- πΊπΈUnited States rclemings
I'm on Drupal 3.1 and mail_login 3.0 still seems to work. You just get a warning on /admin/modules/update.
I'm using Composer for updates and I'm not comfortable hacking it as a workaround.
- First commit to issue fork.
- Status changed to Needs review
4 months ago 3:12am 1 August 2024 - π³πΏNew Zealand jlscott
The problem is that Drupal 10.3 implemented a revised User Authentication Interface, and Commerce Checkout is still using the old one. There is very little difference between the old and the new so the solution is to update the User Authentication decorator service in mail_log to implement both the old and the new interfaces.
A new PR has been created and the update applied. This works for me.
- Merge request !16Issue #3456996 by rajdip_755: Use UserAuthenticationInterface instead of... β (Open) created by jlscott
- Merge request !17Enhance the Auth decorator to implement both the old and the new User Authentication Interfaces β (Open) created by jlscott
- Status changed to RTBC
3 months ago 10:37am 15 August 2024 - π¬π§United Kingdom c_archer Cumbria
Can confirm the MR resolves the issue.
- Status changed to Needs work
3 months ago 3:56pm 22 August 2024 - π³π΄Norway zaporylie
I looked at https://git.drupalcode.org/project/mail_login/-/merge_requests/17 and while the approach of adding an extra interface is correct IMHO, the legacy method doesn't support this module's functionality. So you don't get the error but you can't login with the email address either. Furthermore upon successful login (when the username is used, not mail), the
authenticate
method should return the uid of logged-in user, but it does return a bool. - π³π΄Norway zaporylie
zaporylie β changed the visibility of the branch 3464301-compatibility to hidden.
- π³π΄Norway zaporylie
zaporylie β changed the visibility of the branch 3464301-compatibility to active.
- Status changed to Needs review
3 months ago 4:10pm 22 August 2024 - π³π΄Norway zaporylie
https://git.drupalcode.org/project/mail_login/-/merge_requests/19 is to address the comment in #13.
- π³π΄Norway zaporylie
Tested against Commerce 2.x and 3.x. While 2.x works 3.x needed some work done in π Login checkout pane doesn't fully support UserAuthenticationInterface Needs review . With provided fix both versions are supported.
-
zaporylie β
committed 267088ed on 4.0.x
Issue #3464301 by zaporylie, jlscott, kaipipek, rclemings: AuthDecorator...
-
zaporylie β
committed 267088ed on 4.0.x
- Status changed to Fixed
3 months ago 7:29pm 22 August 2024 - Status changed to Fixed
3 months ago 6:34pm 23 August 2024