🇳🇿New Zealand @jlscott

When generating a views report involving paragraphs after upgrading to PHP8.3, I get the following error:

Deprecated function: Creation of dynamic property Drupal\entity_reference_revisions\Plugin\views\relationship\EntityReferenceRevisions::$first_alias is deprecated in Drupal\entity_reference_revisions\Plugin\views\relationship\EntityReferenceRevisions->query() (line 88 of /var/www/html/web/modules/contrib/entity_reference_revisions/src/Plugin/views/relationship/EntityReferenceRevisions.php)

Convert the dynamic property "$this->first_alias" into a standard PHP variable "$first_alias", as it is not used anywhere else.

I have updated the existing merge request with this change.

OK - RESOLVED.

I had a patch from 🐛 Views doesn't recognize relationship to host Needs review applied. This patch had created the new class that had the deprecation error.

Fix is applied to the push request in that issue.

jlscott → made their first commit to this issue’s fork.

WHAT IS GOING ON????

The class "Drupal\entity_reference_revisions\Plugin\views\relationship\EntityReferenceRevisions", which has the error and is is installed in my codebase by composer as part of the tagged version "8.x-1.12", is not present in the 8.x-1.x git repository when I checkout tag 8.x-1.12?

This make it difficult to generate a patch or pull request to fix the problem.

jlscott → created an issue.

I have just run into this issue when trying to upgrade my site from Group 2 to Group. I have group 2.3.0 going to group 3.3.0 (along with subgroup from 2.0.2 to 3.0.2 and ginvite from 3.0.0-rc3 to 4.0.0-rc3).

Looks like the module has been updated in release 8.x-3.3 to include the change proposed here.

jlscott → made their first commit to this issue’s fork.

I have this error too. While there is a work-around, it makes the upgrade unnecessarily time consuming. Maintainer should not have removed old version 2.x db update functions until branch 3.x.

Problem can be solved temporarily by creating a symbolic link from "docroot/profiles/varbase" to "docroot/profiles/contrib/varbase"

jlscott → created an issue.

The problem is that Drupal 10.3 implemented a revised User Authentication Interface, and Commerce Checkout is still using the old one. There is very little difference between the old and the new so the solution is to update the User Authentication decorator service in mail_log to implement both the old and the new interfaces.

A new PR has been created and the update applied. This works for me.

jlscott → made their first commit to this issue’s fork.

jlscott → created an issue.

Can you please provide additional information on the view and fields you were using. I cannot reproduce this problem.

I think that if one of the fields is empty then you need to decide whether that result should be included or excluded. Views itself provides the ability to have a separate filter group to allow such scenarios to be implemented. It would be just repeating the core views functionality to implement your request, so sorry, but I will close this without changing anything.

@aaron.ferris Thanks for finding this and suggesting a fix. However, the solution for 🐛 Error message The username contains an illegal character. Needs review has removed the use of the password generator service, so this issue no longer needs a separate fix.

@Liam Morland: is this still a problem now that 📌 Refactor legacy code and fix phpcs issues Active has been committed?

Tanks everyone for your contributions in improving the module. Changes committed.

Thanks for this simple improvement :) Merge request committed.

jlscott → made their first commit to this issue’s fork.

Thanks for the work to implement this additional function. Fixed and merged.

jlscott → made their first commit to this issue’s fork.

Note: The algorithm for finding duplicates can be refactored to be more efficient in version 2.0.

jlscott → made their first commit to this issue’s fork.

When working with Group v2 or Group v3, the query will need to be updated to:

    $group_roles = $this->entityTypeManager->getStorage('group_role')->loadByProperties([
      'group_type' => 'my_group_type',
      'scope' => 'individual',
    ]);

Patch attached.

jlscott → created an issue.

jlscott → created an issue.

Aagh... Missing semicolon from the replacement user statement. Fixed.

The patch #46 is creating a new class Drupal\conditional_fields\Routing\RouteEnhancer which contains the use statement:
use Symfony\Cmf\Component\Routing\RouteObjectInterface;
That class has been deprecated, so the use statement needs to be replaced with:
use Drupal\Core\Routing\RouteObjectInterface;

In addition, the patch also creates the class Drupal\conditional_fields\Routing\RouteSubscriber, which contains the method getSubscribedEvents(). The method signature needs to be changed to match the signature of the method in RouteSubscriberBase which is being extended:
public static function getSubscribedEvents(): array

This issue is my mistake, and I have found the problem, which is the patch in 📌 Not working for entity types other than node types Needs work that had been applied, was creating the Class referred to, so needs to be updated. I will fix that.

Not sure what is going on here.

The class Drupal\conditional_fields\Routing\RouteEnhancer id present in my codebase after Composer has loaded the relase "drupal/conditional_fields:4.0.0-alpha5", but is not present in the git repository of the module on branch 4.x after cloning as per version history?

This makes generation of a patch or pull request very difficult???

jlscott → created an issue.

I am also experiencing this issue. I have a number of views that were displaying charts correctly in charts 3.5 and charts 5.0.0-alpha3 using the billboardjs library with Drupal 9.5.11, but do not display anything after the upgrade to Drupal 10.0.11 and charts 5.0.8.

I have enabled the debug display of generated json (using advanced settings) and find that there is no json generated using the billboard library. If I switch to the google library, then I get generated json, but still no chart display. I can switch the view to a table display and get the table with all the rows and correct data displayed.

I am using a local copy of the charting libraries, and followed the instructions in the README file in charts and the library sub-module to install the local copy.

I don't know it it is relevant, but there is a conflict with the README instructions for chart_billboard and the included composer.json file. The README file in the sub-module specifies that the root composer.json should be manually configured by requiring billboardjs/billboard:3.4.1 while the sub-module composer.json file (included via the merge-plugin recommended in the charts module README) requires billboardjs/billboard:1.6.2. This is the version that was used in the earlier releases of charts, that are working.

I have tried both versions of the billboardjs/billboard library, with equal lack of success.

It may also be worth noting, that the earlier releases of charts (up to 3.0.0-alpha3) were using the library d3v4/d3:4.9.1 in preference to d3/d3:4.9.1, but that library is no longer available.

I note that the google library also does not work with the earlier release of charts. I have not tried any other charting library.

I have been experiencing this problem when trying to save display settings for various entities.

I have bootstrap and ds installed.

The problem occurs when the display layout is set to "--None--" in the UI. This then comes through to line 367 (function ds_field_ui_layouts_save() ) as a $layout value of "_none", which throws the error when the library value is being set.

Manually setting the value of $layout to "" at that point prevents the error and the display updates correctly. This is what the provided patch is doing.

@roxflame That sounds like a useful extension. I will look at what is involved in making an exposed filter for this functionality and whether that feature can be selected via configuration.

@g.mustapha Thanks for the offer, but the reason that the patch will not be in the 2.0.x branch is that D10 does not support older versions of PHP. It requires at least PHP 8.1, with 8.1.6 and above recommended.

This issue has been continued in 🐛 Update existing 'node' entity while changing the ID is not supported Needs review where an updated patch is available.

It turns out that the patch referred to from issue 🌱 Support [node:nid] token | specially for prefilled option Fixed does not fix the error for all use cases. I was still encountering the reported error in some instances.

The solution for all cases is to avoid doing an update and save of the entity in hook_insert, but to register a shutdown function and perform the update and save during shutdown.

An updated patch, including the changes from #2920695, is attached.

jlscott → created an issue.

The issue has arisen because the current release of field_permissions_group has been developed and tested against field_permissions 8.x-1.2 but with a patch from ✨ Implement field permissions per-bundle (field instance) Needs work applied.

I will check whether this is necessary for the general case (I required for my use case when developing the module :). If it is not required, then I will refactor the field_permissions_group module to use the unpatched field_permissions module.

@bachbach: I am unable to replicate the error you report. Can you please advise what version of Drupal, PHP, etc you are using?

@j_ten_man. Thanks for picking this up and for supplying a patch. I have tested and applied the patch.

@Rudi Teschner: Thanks for picking this up and for the patch. I have accepted and committed the patch.

@g.mustapha. Thanks for picking this up. I will apply this to the existing 8.x-1.x branch, but this change will not be in the 2.0.x branch that is being created to support D10 development.

Update has been applied.

@
Striknin. Thanks for picking this up. Patch applied and committed.

jlscott → created an issue.

jlscott → created an issue.

Hi. Just a note. To get full Drupal 10 compatibility, then the jquery_ui_effects module, which is a dependency on term_reference_fancytree and is locked to ~1.0, needs to be updated by using the following line in the "require" section of your root (or project) composer.json file:
"drupal/jquery_ui_effects": "2.0.0 as 1.3"

Note: This patch is no longer needed with release 8.x-2.0-rc8, as the required changes have been committed in #6c1a177.

@Rinku Jacob 13: I found a minor error with one of the changes to the libraries specification. Update made and pushed to merge.

The patch does not work in Group-2.x as it references a non-existing entity. Probably just a small mistake, but "$entity->" should be "$this->entity->" in a couple of places. Updated patch, which fixes the duplicate membership issue attached.

Note that my application has a form-alter function that processes the wizard two-step form, altering what is displayed and adding a custom validation function.

Sorry: I have not created the requested tests :(

The problem was a couple of unnecessary spaces in a yaml file. I have removed those and it now appears OK.

Thanks for the report. This is my oversight as I had fixed the issue some time back but had failed to ag it and make a new release. Done now.

@coredumperror: Thanks for fixing this. @heddn can now make the updates necessary.

As far as I know, it requires someone with super-admin privileges to change to owner of a project before the original owner can be removed from the list of maintainers. I guess a request to the appropriate list (the same one used for access to abandoned projects) would be the way to go.

Changes made and pushed to issue fork.

Need to update the core_version_requirements and fix a few twig templates to be compatible with twig v3 (refer https://www.drupal.org/node/3256890 → ).

jlscott → created an issue.

@heddn. Sorry. I don't have the required permission to add you. We need @coredumperror → to action this.

@heddn. Delighted to have your help with this. Unfortunately I no longer work on any systems using S3 files storage, so don't get much opportunity to keep up with this module. I would be delighted for you to take the D10 migration off my hands so I can focus on some of the other projects in my list. I have given you co-maintainer rights so you can work on this. James

I have just upgraded my Varbase system from 9.0.10 to 9.0.11, which uses Drupal core 9.5.2. That was fine, but on switching Php from 8.0 to 8.1 I get several instance of the error when viewing the status report.

Deprecated function: hash(): Passing null to parameter #2 ($data) of type string is deprecated in Drupal\Core\Entity\Sql\DefaultTableMapping->generateFieldTableName() (line 632 of core/lib/Drupal/Core/Entity/Sql/DefaultTableMapping.php).

Drupal\Core\Entity\Sql\DefaultTableMapping->generateFieldTableName(Object, 1) (Line: 602)
Drupal\Core\Entity\Sql\DefaultTableMapping->getDedicatedRevisionTableName(Object) (Line: 253)
Drupal\Core\Entity\Sql\DefaultTableMapping::create(Object, Array, '') (Line: 381)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->getCustomTableMapping(Object, Array) (Line: 356)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->getTableMapping() (Line: 203)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->initTableLayout() (Line: 188)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->__construct(Object, Object, Object, Object, Object, Object, Object, Object) (Line: 156)
Drupal\Core\Entity\Sql\SqlContentEntityStorage::createInstance(Object, Object) (Line: 269)
Drupal\Core\Entity\EntityTypeManager->createHandlerInstance('Drupal\Core\Entity\Sql\SqlContentEntityStorage', Object) (Line: 258)
Drupal\Core\Entity\EntityTypeManager->getHandler('block_content', 'storage') (Line: 192)
Drupal\Core\Entity\EntityTypeManager->getStorage('block_content') (Line: 323)
Drupal\Core\Entity\EntityDefinitionUpdateManager->requiresEntityStorageSchemaChanges(Object, Object) (Line: 261)
Drupal\Core\Entity\EntityDefinitionUpdateManager->getChangeList() (Line: 88)
Drupal\Core\Entity\EntityDefinitionUpdateManager->getChangeSummary() (Line: 956)
system_requirements('runtime')
call_user_func_array(Object, Array) (Line: 426)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'system') (Line: 405)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('requirements', Object) (Line: 433)
Drupal\Core\Extension\ModuleHandler->invokeAll('requirements', Array) (Line: 109)
Drupal\system\SystemManager->listRequirements() (Line: 49)
Drupal\system\Controller\SystemInfoController->status()
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 713)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)