Account created on 5 July 2014, almost 10 years ago
#

Merge Requests

Recent comments

πŸ‡©πŸ‡ͺGermany gnuschichten

A solution in the frontend would be an attribute selector, like [href ~="foo"]

Since the url is the same in all languages. But that's not elegant. Twig filters don't work here and are not a good solution.
{{ url | split('/') | last }}

I think this should be solved via a variable in the module if you don't want me to throw javascript on it. :)

πŸ‡©πŸ‡ͺGermany gnuschichten

@saschaeggi - I will test the icon bug with another language and create a new issue if necessary.

πŸ‡©πŸ‡ͺGermany gnuschichten

Finding, maybe related: There is a css class, that is tranlsated into german, last class: toolbar-link toolbar-link--has-icon toolbar-link--inhalt

I haven't checked the stylesheet yet because I just took a look at the project for the first time today, but it's probably the selector for the different menu icons?

πŸ‡©πŸ‡ͺGermany gnuschichten

@saschaeggi I cleared both the Drupal cache and the images cached in the browser. Result: Menu Icons

  • are still missing, but now the svgs for the sidebar collapse and the chevrons in the after elements are visible.
  • πŸ‡©πŸ‡ͺGermany gnuschichten

    Patch#9 is working for me (minimal profile). And yes, I can confirm that the Icons are missing - only the fallback "icon" applies:

    .toolbar-link--has-icon {
      --icon: icon("fallback"); /* Default icon, aka --basic */
    }
    πŸ‡©πŸ‡ͺGermany gnuschichten

    I always start with the minimal profile. After I added the Ckeditor button for drupal media, I also got the WSOD.
    However, since only experienced people generally use the minimal profile, it can actually be assumed that they will check the logs when a WSOD appears in the frontend.

    I think "minor priority" should be enough

    πŸ‡©πŸ‡ͺGermany gnuschichten

    I applied the tome_drush12-support.patch and drush "tome" is now a defined namespace. I have successfully tested the following commands: drush tome:static and drush tome:export

    Tested with Drupal 10.1.2 and Drush 12.1.3

    πŸ‡©πŸ‡ͺGermany gnuschichten

    I can confirm that the caption field is available with the current d-10 hook (#12). The module seems to be d10 ready.

    πŸ‡©πŸ‡ͺGermany gnuschichten

    gnuschichten β†’ made their first commit to this issue’s fork.

    Production build 0.69.0 2024