- Issue created by @Divyanshi
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:32am 5 July 2023 - First commit to issue fork.
- @gnuschichten opened merge request.
- ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Hmm, haven't run into this on our subthemes but this issue does not surprise me; Bulma's handling of switching from dark to light backgrounds is not nearly as robust as i'd hoped.
As for the fix though we would really want something that does not hard-code a color, as
!important
in overrides no lessโฆHope that the issue is solved for you by using the patch, and thank you for the screenshots and patch, but leaving this for others to review, confirm the issue, and perhaps suggest a less aggressive way to fix.
Oh and as of now/soonish new work goes in 3.0.x.
- Status changed to RTBC
over 1 year ago 1:11pm 4 September 2023 - ๐ฎ๐ณIndia shubham_jain
Hi, I used this patch's css and the issue was resolved. So, moving to the RTBC.
- Status changed to Needs work
about 1 year ago 12:58am 25 October 2023 - ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Sorry but we are not adding a color that is not even one of the bulma variables colors with !importantโ this still needs work.
- Status changed to Needs review
about 1 year ago 9:59am 25 October 2023 - thakurnishant_06 India
Hello @mlncn,
I hope you are doing well. I have added a patch to fix some CSS issues in the 3.0.x version. This includes fixing the view option and spacing issues on the buttons below the text format options. I have also attached a screenshot for a more comprehensive view. - ๐ฎ๐ณIndia Preeti.chawla
HI @thakurnishant_06, I have applied patch#10 and applied succesfully.
But I want to highlight something related to this
View tab is visible but it's not matching with the design, As per theme the colour of tab should be green and background colour should be white.I am attaching Current screenshot after patch and another for what we exactly need. Please check
- thakurnishant_06 India
Thanks @Preeti.chawla for the review
added another patch with changes suggested in #11. Kindly review the changes.
Thanku. - Status changed to RTBC
about 1 year ago 5:53am 6 November 2023 - ๐ฎ๐ณIndia Preeti.chawla
HI @thakurnishant_06, Patch#12 applied successfully and color of View field working fine as per design. Moving to RTBC
- ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Is this fixed by the more targeted approach in ๐ Bulma CSS inherits white colour for local tasks menu links in .hero region, making them invisible. RTBC (committed to both 8.x-1.x and 3.0.x-dev branches)?