Bulma CSS inherits white colour for local tasks menu links in .hero region, making them invisible.

Open on Drupal.org →

Created on 1 August 2018, over 6 years ago

Updated 19 July 2024, 4 months ago

Since bulma version 5, you cannot view the text of contextual links in the Hero region.

This is because the font colour is white, but also the contextual menu background is white.
This is the bulma css causing the issue:

.hero.is-primary a:not(.button), .hero.is-primary strong {
    color: inherit;
}

I suggest we simply add something like:

.contextual-region .contextual .contextual-links a {
	color: #333;
}

somewhere below the bulma css declaration in the css.

🐛 Bug report

Status

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom medden

Live updates comments and jobs are added and updated live.

hero links invisible

Incomplete comments

Sign in to follow issues

Merge Requests

!16Bulma CSS inherits white colour for local tasks menu links in .hero region, making them invisible.
Merged
🇮🇳India jaydeep_patel
updated 4 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 4 months ago →
🇮🇳India jaydeep_patel Ahmedabad
jaydeep.jdb@gmail.com → made their first commit to this issue’s fork.
Merge request !16Contextual menu links color issue has been fixed → (Merged) created by jaydeep_patel
Status changed to Needs review 4 months ago2:02pm 11 July 2024
Comment 4 months ago →
🇮🇳India jaydeep_patel Ahmedabad
Contextual menu links color issue resolved. I've attached the screenshots for the same. Thanks!!!
Comment 4 months ago →
🇮🇳India chandansha
i have tested MR 16. Now contectual menu links color is white and looking good as per design.
I moved forward it to RTBC.
THANKS!!

Comment 4 months ago →

mlncn → committed 46e22e19 on 3.0.x

Issue #2990011 by Jaydeep_patel, Chandansha, medden: Bulma CSS inherits...

Status changed to RTBC 4 months ago3:53am 19 July 2024
Comment 4 months ago →
🇺🇸United States mlncn Minneapolis, MN, USA
Thank you Jaydeep for fixing this without using !important!

Added to 8.x-1.x-dev and 3.0.x-dev, further testing welcome before releases are made!

This should be able to be done with a CSS variable also; followups welcome for that.

Also, do we need a countervailing fix for dark mode? (Using a CSS variable may solve that at the same time.)

In the future i appreciate separate commits for SCSS and compiling the CSS— easier to cherry-pick across branches, among other things.

Thanks all!

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024