- Issue created by @saschaeggi
- @saschaeggi opened merge request.
- Status changed to Needs review
about 1 year ago 9:03am 26 October 2023 - π©πͺGermany gnuschichten
saschaeggi β credited gnuschichten β .
- First commit to issue fork.
- π·πΊRussia kostyashupenko Omsk
New before/after. Added some padding for the texts to prevent interflow
Before:
After:
- πͺπΈSpain ckrina Barcelona
Thanks for the proposal @saschaeggi! But from my understanding not displaying the full label in menu items is not a good practice. I would expect it to break into 2 lines to not leave out important information a site admin/editor might need instead of forcing ~20 characters on the label. I would assume, also, that somebody using a bigger font-size would see even less characters.
I can be wrong so I'll do some research, but feel free to point to any resource that proves it's a good practice. Meanwhile I'll leave this as NR so some other people takes a look to it. - πΊπΈUnited States gdd Portland, OR
I agree this is a bad idea. Truncating text can lead to unfortunate wordings that are embarassing and/or damaging for customers (think about the ways in which analyze or associate might be truncated as an example.) This problem would only be made worse when we consider all the non-English options.
The best choice would be to break to multiple lines and show the complete text of the menu item.
- π¨πSwitzerland saschaeggi Zurich
I totally agree that showing the full item name would be better π Let's proceed with this π
- Status changed to Needs work
about 1 year ago 7:59am 27 October 2023 - πͺπΈSpain ckrina Barcelona
Thank all! Then moving this to Needs Work to update adjust to the current styles in 2 lines for the first level item in a similar way to @kostyashupenko's work on the sub-menu items.
- Status changed to Needs review
about 1 year ago 8:55am 1 November 2023 - Status changed to Needs work
about 1 year ago 4:48pm 1 November 2023 - πͺπΈSpain ckrina Barcelona
Thanks @kostyashupenko! I've just reviewed it and I think the sub-levels are missing the
flex-shrink: 0;
part you've added on the top one: - Status changed to Needs review
about 1 year ago 5:06am 2 November 2023 - Status changed to Fixed
about 1 year ago 1:23pm 2 November 2023 - Status changed to Needs work
about 1 year ago 10:22am 15 November 2023 - π·πΈSerbia finnsky
After refactor this feature is gone.
We need some work here - @kostyashupenko opened merge request.
- Status changed to Needs review
about 1 year ago 5:33am 16 November 2023 - Status changed to RTBC
about 1 year ago 9:13am 16 November 2023 - Status changed to Fixed
about 1 year ago 1:35pm 16 November 2023 - πͺπΈSpain ckrina Barcelona
I've just merged it, thanks! For the next time if you open a new issue (because it's new work that came up) I'll be able to give you the proper credits for it :)
Automatically closed - issue fixed for 2 weeks with no activity.