ChatGPT
The empty() function already checks for null, false, empty strings, empty arrays, and zero values, so there's no need to check for false and empty separately.
So it looks like we can just simplify this.
Books is no longer part of Drupal Core for Drupal 11. This should be spin off into a separate module.
Closing the issue as you said, it works after clicking the button. I am not happy about the button either, but that's a different UI issue
I don't know this module at all, and I don't have time to test it right now. However, I know that with ✨ Support identifiers other than nid Needs review , Draggableviews should work with entity references.
I have tested M36, and everything looks fine. Can we update the documentation (Readme) before this gets committed?
Two things I can think of right now to include:
- "Show: Fields" vs "Show: Content"
- no support for hierarchy
Duplicated of ✨ Add Ajax Checkbox/Option like 7.x-2.x Needs review
I added !33 and also made my own modified README.md. I have committed them to 2.1.x and am going to mark this as Fixed. Feel free to create a new issue if you want to modify README.md again.
This is interesting. I believe draggableviews will have to have two (or multiple) options just like 7.x-2.x. DraggableListBuilderTrait seems to add a weight to an entity. This works for 90% of use cases. The other 10% are when you involve arguments (and filters) and groupings.
Drupal 7 had 2 methods. Weights and Native. Native used its own table, where it saved the weight/order value along with all the arguments (as a javascript object).
I am going to mark this as fixed because of https://git.drupalcode.org/project/draggableviews/-/commit/d1a4a588dceae...
It adds the "Use" of viewExecutable and adds function draggableviews_views_pre_render(ViewExecutable $view) {
Oddly, I checked and did not see draggalbeviews_views_pre_render in any of the last tag versions (2.0.2->2.1.4). This makes me think everyone uses a patched version (some people hinted at it). Going from the patch version to 2.1.4 will remain broken. Going from the patched version to the next release (2.1.5, maybe) will not be an issue.
Is this the same as 🐛 [regression] Schema changed incorrectly. Active ? I believe this only affected the draggableviews demo; I didn't think it affected anything else.
I fixed things up a little. I renamed everything 'base view entity id' cause that's what it is. This should support any entity type that can be a view. The only thing that might be a problem is crossing different type of relationships in the view. I am not too worried about this though, as that is probably already broken.
istryker → changed the visibility of the branch 2.1.x to hidden.
I don't believe we should be calling the _entity function. ✨ Support identifiers other than nid Needs review solution is better. Closing as duplicate.
Problems with merge requests. Fixed the coding standards but still had problems with PHPUnit. Pushing manually
D7, will not fix. Fix for D10/11 pushed up today to 2.1.x-dev.
Merged
We have been using it on all university sites for 11 months. I re-reviewed it. It works.
Looks like you are correct. I click the merge button, but it fails. I will take a look at why.
Is this a duplicate of 🐛 Allow any entity in DraggableViews::getIndex() Needs review . To me it looks the same, but this one tries to make hierarchery work
Merged.
Merged
I was able to reproduce it on a fresh Drupal 11 installation with draggableviews demo submodule installed. Viewing the demo table order table, I did not see any problems as described. I did see it broken on the view edit "preview". MR fixed it. Merged.
This is an excellent start. A few changes are needed.
- Dependency Injections in the classes
- Use taxonomy_presave() hook to save the values. (Currently, this only works if you are in the GUI)
- Fix up the few D8 -> D10 functions that were missed
- Permissions? (I need to make sure there are some).
We need this at work, so I will attempt to rework everything.
Not really a bug but more of a feature request. I have reviewed this, and it works as desired.
MR12 Created - needs review
MR10 makes the error message go away. I like the message; however, all the submit buttons still show. One actually throws an Ajax error if you click on it. I'm creating a new MR that stops and returns the form with just the message.
istryker → made their first commit to this issue’s fork.
#32 works. Committed
I can confirm this removes the error. This fix removes the "Order View" contextual link.
How to reproduce the removal
- Install 2.1.x draggableviews
- Install the draggableviews_demo module (with it having the default Draggable Views Data of "Order Page")
- GoTo the draggableviews display page (/draggableviews-demo)
- Check the contextual links....you will see Order View
Now
- Git Checkout 3316975-contextual-link-error
- Clear cache
- GoTo the draggableviews display page (/draggableviews-demo)
- Check the contextual links....you will NOT see Order View
reroll patch
Rerolled #10
The image has been pushed to 2.1.x-dev; however, the image looks terrible. There is too much white space around the image. It needs to be stretched to the outer edges.
iStryker → created an issue.
Re-roll for 4.x
Done!
Attach is patch to remove aria and alertdialog from the javascript files
iStryker → created an issue.
Works reroll for 4.x
Closing all 7.x issues.
Closing all 7.x issues
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
This is pretty cool thought, but 7.x development has ended
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
The module also has no stable release.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Probably a really good patch. Looks like you spent a good amount of time on it. Too bad we never got around to committing it. Sadly no further additions are getting added to 7.x
Marking all 7.x as out of date. If the problem persists, then only a new issue.
There is currently a 8.x-1.x-dev ticket for this...which I just read. This should be bumped to D10 when someone gets a chances.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
So this is adding html support I believe.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
You can use figcaption tags by override template in your theme
Marking all 7.x as out of date. If the problem persists, then only a new issue.
I'll apply as you should get credit for this.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Quick search in 2.0.x and this is no longer the way things are done.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
I feel like this could break things. If people have css for this then it would break, as all elements would change
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Let me know if this is still a feature request in D10
Deleted - done.
Master last commit was 2013
commit 6f829a556fb16d2f46bf7edd023d51a7b8034412 (HEAD -> master, origin/master)
Author: Tyler Frankenstein <tjfrank@umich.edu>
Date: Thu Feb 7 15:19:00 2013 -0500
Cleared out the master branch in favor of the 7.x-1.x branch.Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
...after reading the comments, this could be a feature request in D10. Again if you want then open a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of date. If the problem persists, then only a new issue.
Marking all 7.x as out of dated. If problem persist, then only a new issue.
Marking all 7.x as out of dated. If problem persist, then only a new issue.
Dont know why this ticket is still open. This was done. Drupal 8 is unsupported now and there is Drupal 10 release. Marking as fixed as this was actually done.
(FYI I have not read all the comments)
Drupal 10 support of module has been completed.
Committed
Comitted #9
Modified it a little before committing to the 1.0.x branch.
This needs to be Drupal 10 compatible
module_load_include('inc', 'image', 'image.field'); line needs to change
there might be a few others
This is super close
Reroll due to other patches being applied.
Commit to 1.0.x branch. Will be released shortly with 1.0.1 tag.
Created 1.0.x branch and commit this. Created 1.0.0 tag that has this. Will be creating a 1.0.1 tag with the 4 other RBTC issues.
Closing in favour of 🐛 Caption required incorrectly based on alt field required RTBC with patch
I am reviewing at DrupalCon Pittsburgh
Looks good @anblee.
I suggest Linkit_logo_1.png → inside an autocomplete box. See attached the autocomplete box that the module spins up.
I am reviewing this at DrupalCon Pittsburg
I can confirm image meets require.
I like Dragable_views_1, however I suggest that the arrows switch, see attached. This reflects how the module functions better.