- 🇺🇸United States joshuasosa
#11 breaks the page if there are no table headers. This case can happen if fields are added and their labels are removed. I had this happen when I had another view display that has fields but no labels. I cloned the display and re-arranged the new page so that it could act as a reordering page using the same fields as the original display. But since it had no labels to make into table headers, it white-screened the reordering page and gave an error.
Notice: Undefined index: draggableviews in draggableviews_preprocess_views_view_table() (line 90 of /drupal/web/modules/contrib/draggableviews/draggableviews.module)
Attached is an updated patch to check if
$variables['header']['draggableviews']['attributes']
is set. - 🇺🇸United States ThanksNeco
#12 patch works perfectly in Drupal 10 as of Jan 2024.
Also, if you don't want to patch the module, you can use #10 example in your site's admin theme and that will fix the issue as well.
Thank you everyone for your fixes with this issue!
- Status changed to Needs review
7 months ago 12:23am 19 April 2024 - last update
7 months ago 1 pass - last update
7 months ago 1 pass - Status changed to RTBC
7 months ago 12:26am 19 April 2024 - 🇺🇸United States joegraduate Arizona, USA
We've been using the patch from #11 on a large number of sites successfully since September 2023.
- 🇭🇷Croatia devad
Patch #12 fixed the issue for me.
DraggableViews 2.1.4
D10.3.1
PHP 8.1 - Merge request !44Issue #3252365: Row weights not displaying on sort view → (Closed) created by voleger
- 🇨🇦Canada iStryker
I was able to reproduce it on a fresh Drupal 11 installation with draggableviews demo submodule installed. Viewing the demo table order table, I did not see any problems as described. I did see it broken on the view edit "preview". MR fixed it. Merged.
- 🇺🇦Ukraine voleger Ukraine, Rivne
It is merged in the wrong branch, which is already unsupported. So, the main branch is still not fixed.
- 🇨🇦Canada iStryker
Looks like you are correct. I click the merge button, but it fails. I will take a look at why.
-
istryker →
committed 7d1bec78 on 2.1.x
Issue #3252365 by voleger: Row weights not displaying on sort view
-
istryker →
committed 7d1bec78 on 2.1.x
- 🇨🇦Canada iStryker
Problems with merge requests. Fixed the coding standards but still had problems with PHPUnit. Pushing manually
Automatically closed - issue fixed for 2 weeks with no activity.