🇺🇸United States @joegraduate

Arizona, USA
Account created on 22 April 2010, almost 15 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States joegraduate Arizona, USA

@skrug Could you create a new issue with as many details as possible?

🇺🇸United States joegraduate Arizona, USA

Hi @damienmckenna. We had a site that was repeatedly throwing this error (on every web request) until we applied this patch and cleared cache, but unfortunately we still don't understand exactly why and haven't identified steps to reproduce the error. We're suspicious that some bad/incomplete render data was cached on the site and that was causing the error but we're not totally sure about that.

We aren't using any other patches on the site but the Schema Metatag module and several of its submodules had recently been installed on the site before we saw this error.

Here is the full stack trace from one of the instances of this error on our site:

Backtrace
#0 /code/web/modules/contrib/metatag/src/MetatagManager.php(284): uasort(NULL, Array)
#1 /code/web/modules/contrib/metatag/src/MetatagManager.php(609): Drupal\metatag\MetatagManager->sortedTags()
#2 /code/web/modules/contrib/metatag/src/MetatagManager.php(565): Drupal\metatag\MetatagManager->generateRawElements(Array, Object(Drupal\node\Entity\Node))
#3 /code/web/modules/contrib/metatag/metatag.module(508): Drupal\metatag\MetatagManager->generateElements(Array, Object(Drupal\node\Entity\Node))
#4 /code/web/modules/contrib/metatag/metatag.module(262): metatag_get_tags_from_route()
#5 /code/web/modules/contrib/metatag/metatag.module(222): _metatag_remove_duplicate_entity_tags(Array)
#6 /code/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(552): metatag_entity_view_alter(Array, Object(Drupal\node\Entity\Node), Object(Drupal\Core\Entity\Entity\EntityViewDisplay))
#7 /code/web/core/lib/Drupal/Core/Entity/EntityViewBuilder.php(305): Drupal\Core\Extension\ModuleHandler->alter('node_view', Array, Object(Drupal\node\Entity\Node), Object(Drupal\Core\Entity\Entity\EntityViewDisplay))
#8 /code/web/core/lib/Drupal/Core/Entity/EntityViewBuilder.php(239): Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array)
#9 [internal function]: Drupal\Core\Entity\EntityViewBuilder->build(Array)
#10 /code/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(113): call_user_func_array(Array, Array)
#11 /code/web/core/lib/Drupal/Core/Render/Renderer.php(870): Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_ren...', 'exception', 'Drupal\\Core\\Ren...')
#12 /code/web/core/lib/Drupal/Core/Render/Renderer.php(432): Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array)
#13 /code/web/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender(Array, false)
#14 /code/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(238): Drupal\Core\Render\Renderer->render(Array, false)
#15 /code/web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
#16 /code/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(231): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#17 /code/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(128): Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
#18 /code/web/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\CurrentRouteMatch))
#19 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#20 /code/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func(Array, Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher))
#21 /code/vendor/symfony/http-kernel/HttpKernel.php(186): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object(Symfony\Component\HttpKernel\Event\ViewEvent), 'kernel.view')
#22 /code/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#23 /code/web/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /code/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /code/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#26 /code/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(191): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /code/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(128): Drupal\page_cache\StackMiddleware\PageCache->fetch(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#28 /code/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(82): Drupal\page_cache\StackMiddleware\PageCache->lookup(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#29 /code/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#30 /code/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#31 /code/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#32 /code/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#33 /code/web/core/lib/Drupal/Core/DrupalKernel.php(741): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#34 /code/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#35 {main}
🇺🇸United States joegraduate Arizona, USA

Created a MR based on proposed resolution in IS. Attaching as a patch usable for composer as well.

🇺🇸United States joegraduate Arizona, USA

Increasing priority to major since it is impossible to save module config currently.

🇺🇸United States joegraduate Arizona, USA

Manually triggered the "tests only" pipeline on the MR and saw that the new test added passes even without the other MR changes which I don't think is the expected result.

Spoke to @trackleft2 about this on Slack and he mentioned that he thinks he needs to add something to the test that verifies the generated file is still actually a multiframe image.

🇺🇸United States joegraduate Arizona, USA

joegraduate created an issue.

🇺🇸United States joegraduate Arizona, USA

Merged.

🇺🇸United States joegraduate Arizona, USA

joegraduate created an issue.

🇺🇸United States joegraduate Arizona, USA

Confirmed that there were no CSS changes between 15.5.1 and 15.8.1

🇺🇸United States joegraduate Arizona, USA

Some tests won't pass until the D11 compatibility changes from 📌 Automated Drupal 11 compatibility fixes for masquerade_log Needs review are committed.

🇺🇸United States joegraduate Arizona, USA

@elc, this is a Drupal module project that defines Drupal libraries usable by other modules (Drupal libraries that wrap the leongersen/noUiSlider Javascript library). The noslider_js project is a general project that "mirrors" the Javascript library.

IMHO, the d.o. community guidelines for creating new project(s) vs co-maintaining existing project(s) were not followed very well when the nouislider_js project was created because:

  • No one reached out to me or created an issue requesting changes or co-maintainer access to this existing project before creating nouislider_js project
  • I created this project in order to contribute to the efforts to replace the jquery_ui_slider dependency in the Better Exposed Filters module 2-3 years ago (see 📌 Remove dependency on jquery_ui_slider Fixed and an associated comment thread in GitLab) but unfortunately wasn't able to follow the progress of the issue as closely when new BEF module maintainers were finally able to get involved to resolve that issue almost a year later.

There are valid reasons for why a module project like this might be preferable to the general project version like the ones described by @trackleft in Demonstrate a better noui slider library integration. Active so I don't think it makes sense to deprecate this project.

🇺🇸United States joegraduate Arizona, USA

Created a new MR targeting 3.x branch.

🇺🇸United States joegraduate Arizona, USA

joegraduate changed the visibility of the branch 3.x to hidden.

🇺🇸United States joegraduate Arizona, USA

joegraduate changed the visibility of the branch 3395397-3.x to hidden.

🇺🇸United States joegraduate Arizona, USA

MR needs to be updated to target 3.x branch.

🇺🇸United States joegraduate Arizona, USA

Never mind. 🐛 Can't save image widget crop settings in Drupal 11 Active is not a D11-specific issue (see closed duplicate 🐛 ImmutableConfigException Active ).

Also, I noticed that the 3.0.0 tag was already created in this module's Git repo. A d.o. release just needs to be created for that tag.

🇺🇸United States joegraduate Arizona, USA

Closed 🐛 ImmutableConfigException Active as a duplicate of this issue. Ideally this should be fixed in 3.0.x-dev first but also backported to 8.x-2.x. @sweetchuck contributed to the closed issue and should also be credited here.

🇺🇸United States joegraduate Arizona, USA

Indeed, this is a duplicate of 🐛 Can't save image widget crop settings in Drupal 11 Active . Closing as such.

🇺🇸United States joegraduate Arizona, USA

Looks like this is blocked by 🐛 Can't save image widget crop settings in Drupal 11 Active getting commited.

🇺🇸United States joegraduate Arizona, USA

Merged 3.x into MR branch and addressed merge conflicts. Should be ready for review.

🇺🇸United States joegraduate Arizona, USA

Merged. Setting back to active for future updates.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

Merged. Thanks! Setting back to active in case project update bot has more changes in the future.

🇺🇸United States joegraduate Arizona, USA

Merged. Further config validation will be explored in Schema for user expire rules by role is difficult to validate. Active .

🇺🇸United States joegraduate Arizona, USA

joegraduate changed the visibility of the branch 3429477-automated-drupal-11 to active.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

Production build 0.71.5 2024