🇺🇸United States @joegraduate

Arizona, USA
Account created on 22 April 2010, almost 15 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States joegraduate Arizona, USA

Merged.

🇺🇸United States joegraduate Arizona, USA

joegraduate created an issue.

🇺🇸United States joegraduate Arizona, USA

Confirmed that there were no CSS changes between 15.5.1 and 15.8.1

🇺🇸United States joegraduate Arizona, USA

Some tests won't pass until the D11 compatibility changes from 📌 Automated Drupal 11 compatibility fixes for masquerade_log Needs review are committed.

🇺🇸United States joegraduate Arizona, USA

@elc, this is a Drupal module project that defines Drupal libraries usable by other modules (Drupal libraries that wrap the leongersen/noUiSlider Javascript library). The noslider_js project is a general project that "mirrors" the Javascript library.

IMHO, the d.o. community guidelines for creating new project(s) vs co-maintaining existing project(s) were not followed very well when the nouislider_js project was created because:

  • No one reached out to me or created an issue requesting changes or co-maintainer access to this existing project before creating nouislider_js project
  • I created this project in order to contribute to the efforts to replace the jquery_ui_slider dependency in the Better Exposed Filters module 2-3 years ago (see 📌 Remove dependency on jquery_ui_slider Fixed and an associated comment thread in GitLab) but unfortunately wasn't able to follow the progress of the issue as closely when new BEF module maintainers were finally able to get involved to resolve that issue almost a year later.

There are valid reasons for why a module project like this might be preferable to the general project version like the ones described by @trackleft in Demonstrate a better noui slider library integration. Active so I don't think it makes sense to deprecate this project.

🇺🇸United States joegraduate Arizona, USA

Created a new MR targeting 3.x branch.

🇺🇸United States joegraduate Arizona, USA

joegraduate changed the visibility of the branch 3.x to hidden.

🇺🇸United States joegraduate Arizona, USA

joegraduate changed the visibility of the branch 3395397-3.x to hidden.

🇺🇸United States joegraduate Arizona, USA

MR needs to be updated to target 3.x branch.

🇺🇸United States joegraduate Arizona, USA

Never mind. 🐛 Can't save image widget crop settings in Drupal 11 Active is not a D11-specific issue (see closed duplicate 🐛 ImmutableConfigException Active ).

Also, I noticed that the 3.0.0 tag was already created in this module's Git repo. A d.o. release just needs to be created for that tag.

🇺🇸United States joegraduate Arizona, USA

Closed 🐛 ImmutableConfigException Active as a duplicate of this issue. Ideally this should be fixed in 3.0.x-dev first but also backported to 8.x-2.x. @sweetchuck contributed to the closed issue and should also be credited here.

🇺🇸United States joegraduate Arizona, USA

Indeed, this is a duplicate of 🐛 Can't save image widget crop settings in Drupal 11 Active . Closing as such.

🇺🇸United States joegraduate Arizona, USA

Looks like this is blocked by 🐛 Can't save image widget crop settings in Drupal 11 Active getting commited.

🇺🇸United States joegraduate Arizona, USA

Merged 3.x into MR branch and addressed merge conflicts. Should be ready for review.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

Thanks all. Merged.

🇺🇸United States joegraduate Arizona, USA

Merged. Setting back to active for future updates.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

Merged. Thanks! Setting back to active in case project update bot has more changes in the future.

🇺🇸United States joegraduate Arizona, USA

Merged. Further config validation will be explored in Schema for user expire rules by role is difficult to validate. Active .

🇺🇸United States joegraduate Arizona, USA

joegraduate changed the visibility of the branch 3429477-automated-drupal-11 to active.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

I like the idea of caching the config comparisons and changelists.

I think we might just need to add a "refresh" button to the config distro form so make manual cache invalidation possible.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

Changed the target branch of the MR to 2.0.x. Now it has cspell failures that need to be addressed.

🇺🇸United States joegraduate Arizona, USA

joegraduate made their first commit to this issue’s fork.

🇺🇸United States joegraduate Arizona, USA

Never mind. Just needed to update the MR with the latest changes from 2.0.x

🇺🇸United States joegraduate Arizona, USA

Looks like we have new PHPCS failures

🇺🇸United States joegraduate Arizona, USA

LGTM. Thanks @trackleft2!

Production build 0.71.5 2024