Merged.
LGTM. Thanks @trackleft2!
Never mind. Just needed to update the MR with the latest changes from 2.0.x
Looks like we have new PHPCS failures
Merged.
LGTM. Thanks @trackleft2!
Merged.
LGTM. Thanks @rohan_singh!
Merged.
joegraduate → created an issue.
FWIW, support for some of the newer configuration validation constraints (including FullyValidatable) wasn't added to Drupal core until 10.3.x:
https://www.drupal.org/node/3404425 →
Merged.
Created new branch from existing MR (duplicate MR) to trigger tugboat.
joegraduate → changed the visibility of the branch 2836514-2.x to hidden.
Merged.
joegraduate → made their first commit to this issue’s fork.
MR looks good to me.
LGTM
Created new branch from existing MR (duplicate MR) to trigger tugboat.
Merged.
joegraduate → created an issue. See original summary → .
Release created:
https://www.drupal.org/project/user_expire/releases/2.0.1 →
Merged
MR !82 seems like the correct fix to me. +1 for RTBC on that MR.
Changes look good to me. Thanks @trackleft2!
Merged.
Proposed schema looks good to me. Can we use machine name as the type for the Role ID?
LGTM. Thanks.
Remaining GitLab CI composer test failure is blocked by the require-dev dependency on drupal/entity_embed not having a D11 compatible release yet.
joegraduate → made their first commit to this issue’s fork.
joegraduate → created an issue.
Made some more improvements to the new settings in the settings form and the overall implementation of when the warnings are sent. This ready for final review now IMHO.
LGTM. Applied on minor nitpick commit suggestion. Thanks!
joegraduate → made their first commit to this issue’s fork.
Merged.
We might want to save the feature request issues for a 2.1.0 release (?)
joegraduate → changed the visibility of the branch 2855005-reset-expiry-on-reactivation to hidden.
joegraduate → changed the visibility of the branch user_expire-2836514/8.x-1.x to hidden.
Created a new MR targeting 2.x branch that includes rebased changes from original 8.x-1.x MR + the config schema changes and DB update described in #19.
Merged.
Merged.
joegraduate → changed the visibility of the branch 3491786-address-phpunit-next to hidden.
joegraduate → made their first commit to this issue’s fork.
Merged.
Fixes test failure. Thanks @trackleft2!
Merged
LGTM. Thanks @trackleft2!
This change has been made. Thanks @trackleft2.
Most of the testing I've done with this patch was with the functionality for disabling email notifications. Taking a closer look at the functionality for customizing the notification email subject and message I see a potential config schema improvement that we may want to address before merging this.
I think we should replace the new mail.subject and mail.body config settings with a single setting of the mail config schema type consistent with how the core user module mail configuration settings work.
I also wonder if we need to include a database update function to apply the default mail config setting(s) to existing sites.
Folks who would be interested in assisting as co-maintainers from our organization:
We also have a shared/organization user account → for project ownership if that's helpful/needed.
joegraduate → created an issue.
We've tested the MR/patch with good results and are hoping this change will be committed soon as we'd like to use this module on several sites.