MR is ready for review.
Merged.
joegraduate → created an issue.
Merged.
joegraduate → created an issue. See original summary → .
Confirmed that there were no CSS changes between 15.5.1 and 15.8.1
Some tests won't pass until the D11 compatibility changes from 📌 Automated Drupal 11 compatibility fixes for masquerade_log Needs review are committed.
joegraduate → made their first commit to this issue’s fork.
joegraduate → created an issue.
@elc, this is a Drupal module project that defines Drupal libraries usable by other modules (Drupal libraries that wrap the leongersen/noUiSlider Javascript library). The noslider_js project → is a general project that "mirrors" the Javascript library.
IMHO, the d.o. community guidelines for creating new project(s) vs co-maintaining existing project(s) → were not followed very well when the nouislider_js project was created because:
- No one reached out to me or created an issue requesting changes or co-maintainer access to this existing project before creating nouislider_js project
- I created this project in order to contribute to the efforts to replace the jquery_ui_slider dependency in the Better Exposed Filters module 2-3 years ago (see 📌 Remove dependency on jquery_ui_slider Fixed and an associated comment thread in GitLab) but unfortunately wasn't able to follow the progress of the issue as closely when new BEF module maintainers were finally able to get involved to resolve that issue almost a year later.
There are valid reasons for why a module project like this might be preferable to the general project version like the ones described by @trackleft in ✨ Demonstrate a better noui slider library integration. Active so I don't think it makes sense to deprecate this project.
Created a new MR targeting 3.x branch.
joegraduate → changed the visibility of the branch 3.x to hidden.
joegraduate → changed the visibility of the branch 3395397-3.x to hidden.
MR needs to be updated to target 3.x branch.
Never mind. 🐛 Can't save image widget crop settings in Drupal 11 Active is not a D11-specific issue (see closed duplicate 🐛 ImmutableConfigException Active ).
Also, I noticed that the 3.0.0
tag was already created in this module's Git repo. A d.o. release just needs to be created for that tag.
Closed 🐛 ImmutableConfigException Active as a duplicate of this issue. Ideally this should be fixed in 3.0.x-dev first but also backported to 8.x-2.x. @sweetchuck contributed to the closed issue and should also be credited here.
Indeed, this is a duplicate of 🐛 Can't save image widget crop settings in Drupal 11 Active . Closing as such.
Looks like this is blocked by 🐛 Can't save image widget crop settings in Drupal 11 Active getting commited.
Merged 3.x into MR branch and addressed merge conflicts. Should be ready for review.
joegraduate → made their first commit to this issue’s fork.
Was addressed in 📌 GitLabCI: Fix existing PHPCS issues Active
Thanks all. Merged.
Waiting on 📌 GitLabCI: Fix existing PHPCS issues Active .
Merged. Setting back to active for future updates.
joegraduate → made their first commit to this issue’s fork.
Merged. Thanks! Setting back to active in case project update bot has more changes in the future.
Moved method deprecations changes to 📌 Deprecate ConfigProviderBase drupalGetPath() and drupalGetProfile() methods Active .
joegraduate → created an issue.
Merged.
joegraduate → created an issue.
joegraduate → created an issue.
Release created:
https://www.drupal.org/project/user_expire/releases/2.1.0 →
Merged. Further config validation will be explored in ✨ Schema for user expire rules by role is difficult to validate. Active .
Oops, we already did this in ✨ Increase minimum core version to ^10.3 Active .
joegraduate → created an issue.
Merged.
joegraduate → created an issue.
Merged more changes.
joegraduate → changed the visibility of the branch 3429477-automated-drupal-11 to active.
joegraduate → made their first commit to this issue’s fork.
Release created:
https://www.drupal.org/project/config_snapshot/releases/2.0.0 →
Fixed in 📌 Automated Drupal 11 compatibility fixes for config_snapshot Active and other issues.
joegraduate → made their first commit to this issue’s fork.
I like the idea of caching the config comparisons and changelists.
I think we might just need to add a "refresh" button to the config distro form so make manual cache invalidation possible.
joegraduate → made their first commit to this issue’s fork.
Changed the target branch of the MR to 2.0.x. Now it has cspell failures that need to be addressed.
joegraduate → made their first commit to this issue’s fork.
Merged.
LGTM. Thanks @trackleft2!
Never mind. Just needed to update the MR with the latest changes from 2.0.x
Looks like we have new PHPCS failures
Merged.
LGTM. Thanks @trackleft2!