Breaking API change in #3457459 broke config_sync

Created on 5 March 2025, 28 days ago

Problem/Motivation

Originally reported by @skrug and @tadean in πŸ“Œ GitLabCI: Fix existing PHPCS issues Active :

skrug
27 February 2025 at 02:16
I know this is closed but for some reason this commit breaks the ability to use the "--update-mode" option for "drush cd-update". It's not available anymore.

tadean
27 February 2025 at 10:26
@skrug @joegraduate It appears that the changes in this commit to ConfigCollector which adds ExtensionPathResolver as a final argument are breaking this feature within config_sync, because config_sync subclasses ConfigCollector via Drupal\config_sync\Plugin\SyncConfigCollector.

Without that API change of the additional argument also being present in config_sync in the config_sync.collector service, the drush command gives the following errors:

drush cd-update --update-mode=1
                                              
  The "--update-mode" option does not exist.

and:

drush cd-update

In Container.php line 149:
                                                                                                                      
  Circular reference detected for service "config_sync.lister", path: "config_sync.lister -> config_sync.collector".

Steps to reproduce

Proposed resolution

Revert breaking change. Introduce new ConfigCollector constructor argument as optional instead with deprecation warning.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States joegraduate Arizona, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024