- Issue created by @joegraduate
- Merge request !14Issue #3511302: Breaking API change in #3457459 broke config_sync β (Merged) created by joegraduate
- First commit to issue fork.
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
I've tested the changes in Merge Request !14 and they do appear to resolve the issue.
How I tested.(with the patch applied)
- I changed the update mode to "Full Reset"
- I randrush cd-update --update-mode=1
- I saw that the update mode was overridden via the drush command to merge mode.I removed the patch
- I ran
drush cd-update --update-mode=1
I saw
The "--update-mode" option does not exist.
Should we keep the type hint of
ExtensionPathResolver
and make it nullable,?ExtensionPathResolver
? A symptom of the change in the MR removing the type hint is that you can now pass anything you want the final argument and it works, with a somewhat unexpected deprecation warning:Passing Drupal\Core\Config\ConfigFactory to the $extension_path_resolver parameter of ConfigCollector::__construct() is deprecated in config_provider:3.0.0-alpha2
I believe that NULL default arguments are also deprecated in PHP 8.4
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
I think that makes sense.
- πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
trackleft2 β changed the visibility of the branch 3.0.x to hidden.
-
joegraduate β
committed 17ca8091 on 3.0.x
Issue #3511302 by joegraduate, trackleft2, tadean, skrug: Add BC for...
-
joegraduate β
committed 17ca8091 on 3.0.x
Automatically closed - issue fixed for 2 weeks with no activity.