🇺🇸United States @trackleft2

trackleft2 → created an issue.

Converted to merge request for easier review. We' plan on using this patch in production soon, but have yet to roll it out yet. I'll report back once we have more real world feedback. Otherwise I think this should be OK to merge at any time.

trackleft2 → made their first commit to this issue’s fork.

4.1.0-alpha1 → released.
4.1.0-beta1 → released.

trackleft2 → created an issue.

Was your site not letting you uninstall search_exclude because it would WSOD?

Once you were able to clear the error your site was experiencing, were you able to uninstall search_exclude?

You know what that might be? There are two exports in the entity definition: https://git.drupalcode.org/project/environment_indicator/-/blob/5.0.x/sr...

I am not sure why that is appearing, but for me the fix for errors like that for other entity types was to run
drush entity:save <entity_type>

Example:
drush entity:save environment_indicator

https://www.drupal.org/project/user_expire/releases/2.1.2 →

Thank you for the quick fix! Let's get this in 🌱 [Meta] Release Plan for User Expire Patch Release 2.1.2 (bugfix) Active

:facepalm: @devkinetic thanks!

I've added.a draft merge request that creates a new token that can be used in the configurable email body. That way people can change the message to suit their needs. Please review.

Woah! that's a pretty cool use case. I can certainly post a link to your module on this project's homepage. We can also look into adding an automated test to test the integration of. your module if you are interested.

Hi @mc0e, you can now turn off the favicon functionality if you are still interested.

I think it is pretty clear actually.

This cannot be merged unless we change the minimum Drupal core version to 11.1.2 because Drupal\Core\Entity\Attribute\ConfigEntityType was not backported to 10.5.

Luckily we have until Drupal Core 13 to remove it.

trackleft2 → created an issue.

Moving ✨ Support for core navigation experimental module Active to 🌱 Draft: Release Plan for Environment Indicator Minor Release 5.0.0-beta1 Active

trackleft2 → created an issue.

OK, I've updated the CSS in https://git.drupalcode.org/project/environment_indicator/-/merge_request.... Let me know what you think.

Thanks for this contribution, I've added some PHPUnit functional tests that pass, and also ran the "Test Only Changes" test https://git.drupalcode.org/project/environment_indicator/-/jobs/6049858 which failed successfully

I'll create patches for the 4.0.x, 4.1.x and 5.0.x release branches.

trackleft2 → changed the visibility of the branch 4.x to hidden.

trackleft2 → changed the visibility of the branch 3535382-version-identifier-fallback-with-tests to hidden.

trackleft2 → made their first commit to this issue’s fork.

Hi @holo96,

In light of ✨ Performance Improvements Active , I think we should take a slightly different approach.

Rather than putting hasAccess() on the service, I’d propose a new helper in environment_indicator.module that calls less heavy functions like this:

/**
 * Check if user has access to environment indicator.
 *
 * This function checks both the traditional permission and the new
 * unrestricted access setting.
 *
 * @return \Drupal\Core\Session\AccountProxyInterface|false
 *   The current user account if access is granted, FALSE otherwise.
 */
function _environment_indicator_has_access() {
  $account = \Drupal::currentUser();

  // Check if unrestricted access is enabled in settings.php.
  if (Settings::get('environment_indicator_unrestricted_access', FALSE)) {
    return $account;
  }

  // Fall back to traditional permission check.
  if ($account->hasPermission('access environment indicator')) {
    return $account;
  }

  return FALSE;
}

See https://git.drupalcode.org/project/environment_indicator/-/merge_request...

Additionally, I think we should find a way to let users know that they have this setting set in settings.php.

From my perspective, site admins will likely not remember they have this setting set in settings.php and will begin pulling their hair out.

I think we should add a notice on the `/admin/config/development/environment-indicator` page if the setting is enabled.

Additionally, I think we should add some PHPUnit tests so we can feel confident about the feature functioning as expected in future updates.

Hi @jennypanighetti,

Thank you for opening this issue, the hard-coded color setting actually lives in the Claro theme, however as you can see in this file https://git.drupalcode.org/project/drupal/-/blob/11.x/core/themes/claro/... and your screenshot, the background color is also set there, and the environment_indicator module overrides that.

With that being said, I wonder if we could do something similar for the color that this module is doing for background color.

trackleft2 → changed the visibility of the branch 3524015-remove-gin-admin to hidden.

trackleft2 → changed the visibility of the branch 4.x to hidden.

trackleft2 → changed the visibility of the branch 3530667-remove-code-deprecated to hidden.

Updated core version requirements for environment_indicator and its submodules to require Drupal ^10.5 or >=11.1.2 dropping support for Drupal versions that do not support hook_navigation_content_top().

trackleft2 → changed the visibility of the branch 3537504-drop-support-for to hidden.

Hi @vlyalko, how are you attempting to update.

We've been using the 2.0.0 version with masquerade 2.0 for quite some time now.

        "drupal/masquerade": "2.0.0",
        "drupal/masquerade_log": "2.0.0",

Could your issue be that you are updating the composer.json file by hand without deleting the composer.lock file after?

Have you tried
composer require 'drupal/masquerade_log:^2.0' --with-all-dependencies
Or

composer require 'drupal/masquerade:^2.0' --with-all-dependencies

This issue may already be fixed in 4.1.0-alpha1.

Hi @steveoriol this issue remains open because we aren't sure if it has already been resolved or not by the merged fix in 📌 Update module to use CSS variables instead of adding inline CSS. Active

There is a possibility that all issues discussed here have already been resolve in 4.1.0-alpha1.

If you discover more that needs to be done, please report back the steps needed to reproduce what you are seeing. Thank you so much for your interest in helping out.

Hi @pwolanin, thanks for filing this issue, I've created a new patch that hopefully resolves this issue.

To create the patch (and merge request), I simply duplicated logic from within the ToolbarHandler class within the hook functions that were previously calling the deprecated service.

Moving all of this code does feel somewhat risky so we'll definitely need to test that this doesn't cause a regression.

If the patch for 4.0.x suffices, I can also add a new patch and merge request for the 4.1.x version.

Have you seen any errors in your log that may be related?

trackleft2 → made their first commit to this issue’s fork.

trackleft2 → changed the visibility of the branch rebuild-tugboat to hidden.

4.1.0-alpha1 released! →

trackleft2 → created an issue.

I am updating this so we can add an alpha release cycle, meaning we can release now, and then add the planned features as they become ready.

We may want to kick the navigation module integration into 5.x in order to set the new minimum Drupal core version to core_version_requirement: '^10.5 || ^11.1.2'.

@svendecabooter & @jrb we could make it configurable simply be creating a new library with a new css file, and then only add the new library if the setting to color the logo is selected.

That said, let's move this feature request into a new issue to enhance the navigation integration[#3537419]. At the moment, I don't think we are thinking through all of the implications of coloring the logo, and it would be easier to test in isolation once this issue has been fixed.

For instance, how does it work for the other logo settings available in the navigation configuration?
What about custom logos?

trackleft2 → created an issue.

trackleft2 → changed the visibility of the branch 3536522-insufficient-permission-check to hidden.

trackleft2 → created an issue.

I've created a Merge Request, and a patch for use in the meantime. Please test, and let me know if it works for you, and we can create a new release.

OK, I'll backport the fix to the 4.0.x branch and create a new 4.0.25 release.

I was finally able to get all the tests to pass.

Removing ✨ use DraggableListBuilder Active from this release and moving to the next one. 🌱 Draft: Release Plan for Environment Indicator Minor Release 5.0.0-beta1 Active