🇺🇸United States @trackleft2

trackleft2 → created an issue.

trackleft2 → changed the visibility of the branch 2.x to hidden.

Tested on Drupal Core 10.2 and 10.3.

Field formatters were not selectable in the display configuration interface in Drupal Core 10.2 but they were, useable in 10.3

Hey there @anicho01 I've updated the merge requests, however it is difficult to test without a Drupal 11 compatible version of features...

@bjared I pushed a MR branch that adds a setting to use a hyphen (-) as the separator.

When you get a minute, please review the automated tests in that branch—they include a bunch of examples of the expected formatted dates with the hyphen across common cases (single dates, ranges, with/without year).

I certainly agree with that!

OK, I've updated your branch, what do you think about the test?

Thank you, how do you feel about adding a phpunit test to cover this change?
I was thinking we could just add the PHPUnit test that was failing and found this bug in the first place.

We changed our PHPUnit tests in this commit to make sure the year was always the current year.

https://git.drupalcode.org/project/date_ap_style/-/merge_requests/26/diffs

If you don't feel comfortable adding a test, I could do it also. However you want to handle it is fine by me.

@jacob.embree bootstrap definitely dropped affix, it says so in their docs.

trackleft2 → created an issue.

trackleft2 → created an issue.

minimum drupal core requirement 10.2 See https://www.drupal.org/node/3395575 →

trackleft2 → created an issue.

How do you feel about adding a new option so people can choose to upgrade?

- to
- endash
- hyphen

See https://git.drupalcode.org/search?search=endash&nav_source=navbar&projec...

I went ahead and updated the fork. We fixed all test failures upstream. Now all failures are from this merge request.

patch in #21 didn't apply to 5.5.20, adding new patch that applies on 5.5.20

New patch fixing z-index and toast colors

I think we need to update the tabledrag.js to always include toasts.js when toasts is the theme setting.

Thanks, looks like your MR added these new PHPCS issues.

 260 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
     |         |     parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
 262 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
     |         |     parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)
 264 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters (Drupal.Files.LineLength.TooLong)
 264 | ERROR   | [x] Comments may not appear after statements (Drupal.Commenting.PostStatementComment.Found)
 264 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
     |         |     parentheses (Drupal.Commenting.InlineComment.InvalidEndChar)

See https://git.drupalcode.org/issue/date_ap_style-3542969/-/jobs/6329113

What would you like to see happen here, @liam.morland?

For my projects, requiring Drupal 10.5+ is fine. Are you suggesting we maintain two release branches? For example:
• 2.0.x – supporting the previous CKEditor in Drupal 10 before 10.5
• 2.1.x – requiring 10.5+

Real issue 📌 Drupal 10.5/11.2 compatability Active

trackleft2 → created an issue.

Please update as a merge request: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Needs merge conflicts resolved.

There are still some undone tasks.

On initial module install, this is what I see when I run the config_inspector module drush config:inspect command

 git:(main) lando drush config:inspect date_ap_style.dateapstylesettings --detail
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ---------------------------------------------------------- ---------------- ------------- ------ 
  Key                                                        Status           Validatable   Data  
 ---------------------------------------------------------- ---------------- ------------- ------ 
  date_ap_style.dateapstylesettings:_core                    missing schema                       
  date_ap_style.dateapstylesettings:date_ap_style_settings   missing schema                       
 ---------------------------------------------------------- ---------------- ------------- ------ 

And on an entity view display using the timestamp_ap_style formatter.

 lando drush config:inspect core.entity_view_display.node.az_news.az_row --detail
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 --------------------------------------------------------------------------------------------------------------- ---------------- ------------- ------ 
  Key                                                                                                             Status           Validatable   Data  
 --------------------------------------------------------------------------------------------------------------- ---------------- ------------- ------ 
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.always_display_year            missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.use_today                      missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.display_day                    missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.use_all_day                    missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.timezone                       missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.cap_today                      missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.display_time                   missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.time_before_date               missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.display_noon_and_midnight      missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.capitalize_noon_and_midnight   missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.hide_date                      missing schema                       
  core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.month_only                     missing schema                       
 --------------------------------------------------------------------------------------------------------------- ---------------- ------------- ------ 

And on the daterange_ap_style formatter.

lando drush config:inspect core.entity_view_display.node.az_event.az_card_alternate --detail
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ---------------------------------------------------------------------------------------------------------------------------- ---------------- ------------- ------ 
  Key                                                                                                                          Status           Validatable   Data  
 ---------------------------------------------------------------------------------------------------------------------------- ---------------- ------------- ------ 
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.always_display_year            missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.use_today                      missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.cap_today                      missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.display_time                   missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.time_before_date               missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.display_noon_and_midnight      missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.use_all_day                    missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.separator                      missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.timezone                       missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.display_day                    missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.month_only                     missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.hide_date                      missing schema                       
  core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.capitalize_noon_and_midnight   missing schema                       
 ---------------------------------------------------------------------------------------------------------------------------- ---------------- ------------- ------ 

Then when I run the database updates I see:

lando drush updatedb:status --format=table
 --------------- ---------------------------- ------------- ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Module          Update ID                    Type          Description                                                                                                                                                                    
 --------------- ---------------------------- ------------- ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  date_ap_style   migrate_and_cleanup_config   post-update   Migrate configuration and fix data types for existing installations.   This comprehensive post-update function handles:  - Migration from old config name                      
                                                             (date_ap_style.dateapstylesettings)    to new (date_ap_style.settings)  - Cleanup of invalid configuration keys  - Conversion of stringinteger values to proper boolean types  
                                                             in main config  - Conversion of stringinteger values to proper boolean types in    entity view display configs  - Handles both fresh installations and existing sites.         
 --------------- ---------------------------- ------------- ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

lando drush updatedb -y                   
 --------------- ----------- ------------- ------------------------------------------- 
  Module          Update ID   Type          Description                                
 --------------- ----------- ------------- ------------------------------------------- 
  date_ap_style   mi          post-update   Migrate configuration and fix data types   
                  gr                        for existing installations.   This         
                  at                        comprehensive post-update function         
                  e_                        handles:  - Migration from old config      
                  an                        name (date_ap_style.dateapstylesettings)   
                  d_                          to new (date_ap_style.settings)  -       
                  cl                        Cleanup of invalid configuration keys  -   
                  ea                        Conversion of stringinteger values to      
                  nu                        proper boolean types in main config  -     
                  p_                        Conversion of stringinteger values to      
                  co                        proper boolean types in    entity view     
                  nf                        display configs  - Handles both fresh      
                  ig                        installations and existing sites.          
 --------------- ----------- ------------- ------------------------------------------- 


 // Do you wish to run the specified pending updates?: yes.                                                             

>  [notice] Update started: date_ap_style_post_update_migrate_and_cleanup_config
>  [notice] Migrated configuration from date_ap_style.dateapstylesettings to date_ap_style.settings. Cleaned up main configuration and fixed data types. Fixed data types in 12 entity view display configurations.
>  [notice] Update completed: date_ap_style_post_update_migrate_and_cleanup_config
 [success] Finished performing updates.

 lando drush config:inspect date_ap_style.dateapstylesettings --detail                       
➜  🤖 Analyzing…

 [warning] Undefined variable $all_property_paths InspectorCommands.php:259
 [warning] foreach() argument must be of type array|object, null given InspectorCommands.php:259
 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ----------------------------------- ----------- ------------- ------ 
  Key                                 Status      Validatable   Data  
 ----------------------------------- ----------- ------------- ------ 
  date_ap_style.dateapstylesettings   No schema                       
 ----------------------------------- ----------- ------------- ------ 

lando drush config:inspect date_ap_style.settings --detail
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ------------------------------------------------------ --------- ------------- ------ 
  Key                                                    Status    Validatable   Data  
 ------------------------------------------------------ --------- ------------- ------ 
  date_ap_style.settings                                 Correct   100%          ✅✅  
   date_ap_style.settings:                               Correct   Validatable   ✅✅  
   date_ap_style.settings:always_display_year            Correct   Validatable   ✅✅  
   date_ap_style.settings:cap_today                      Correct   Validatable   ✅✅  
   date_ap_style.settings:capitalize_noon_and_midnight   Correct   Validatable   ✅✅  
   date_ap_style.settings:display_day                    Correct   Validatable   ✅✅  
   date_ap_style.settings:display_noon_and_midnight      Correct   Validatable   ✅✅  
   date_ap_style.settings:display_time                   Correct   Validatable   ✅✅  
   date_ap_style.settings:hide_date                      Correct   Validatable   ✅✅  
   date_ap_style.settings:month_only                     Correct   Validatable   ✅✅  
   date_ap_style.settings:separator                      Correct   Validatable   ✅✅  
   date_ap_style.settings:time_before_date               Correct   Validatable   ✅✅  
   date_ap_style.settings:timezone                       Correct   Validatable   ✅✅  
   date_ap_style.settings:use_all_day                    Correct   Validatable   ✅✅  
   date_ap_style.settings:use_today                      Correct   Validatable   ✅✅  
 ------------------------------------------------------ --------- ------------- ------ 

 lando drush config:inspect core.entity_view_display.node.az_event.az_card_alternate --detail
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ------------------------------------------------------------------------------------------------------------------------------------------------------- --------- ------------- ------ 
  Key                                                                                                                                                     Status    Validatable   Data  
 ------------------------------------------------------------------------------------------------------------------------------------------------------- --------- ------------- ------ 
  core.entity_view_display.node.az_event.az_card_alternate                                                                                                Correct   52%           ✅❓  
   core.entity_view_display.node.az_event.az_card_alternate:                                                                                              Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:_core                                                                                         Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:_core.default_config_hash                                                                     Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:bundle                                                                                        Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content                                                                                       Correct   NOT           ✅❓  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date                                                                   Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.label                                                             Correct   NOT           ✅❓  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.region                                                            Correct   NOT           ✅❓  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings                                                          Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.always_display_year                                      Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.cap_today                                                Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.capitalize_noon_and_midnight                             Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.display_day                                              Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.display_noon_and_midnight                                Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.display_time                                             Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.hide_date                                                Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.month_only                                               Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.separator                                                Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.time_before_date                                         Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.timezone                                                 Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.use_all_day                                              Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_event.az_card_alternate:content.field_az_event_date.settings.use_today                                                Correct   Validatable   ✅✅  

 lando drush config:inspect core.entity_view_display.node.az_news.az_row --detail            
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ---------------------------------------------------------------------------------------------------------------------------------------- --------- ------------- ------ 
  Key                                                                                                                                      Status    Validatable   Data  
 ---------------------------------------------------------------------------------------------------------------------------------------- --------- ------------- ------ 
  core.entity_view_display.node.az_news.az_row                                                                                             Correct   50%           ✅❓  
   core.entity_view_display.node.az_news.az_row:                                                                                           Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:_core                                                                                      Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:_core.default_config_hash                                                                  Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:bundle                                                                                     Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content                                                                                    Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image                                                               Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.label                                                         Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.region                                                        Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.settings                                                      Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.settings.image_link                                           Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.settings.image_loading                                        Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.settings.image_loading.attribute                              Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.settings.image_style                                          Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.third_party_settings                                          Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.type                                                          Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_media_image.weight                                                        Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published                                                                 Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.label                                                           Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.region                                                          Correct   NOT           ✅❓  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings                                                        Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.always_display_year                                    Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.cap_today                                              Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.capitalize_noon_and_midnight                           Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.display_day                                            Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.display_noon_and_midnight                              Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.display_time                                           Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.hide_date                                              Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.month_only                                             Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.time_before_date                                       Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.timezone                                               Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.use_all_day                                            Correct   Validatable   ✅✅  
   core.entity_view_display.node.az_news.az_row:content.field_az_published.settings.use_today                                              Correct   Validatable   ✅✅  

trackleft2 → created an issue. See original summary → .

trackleft2 → created an issue.

trackleft2 → created an issue.

trackleft2 → created an issue.

trackleft2 → created an issue.

trackleft2 → changed the visibility of the branch 3485305-new-alert-component to hidden.

New toast styles to match alerts:

Updated theme configuration schema to  match what was added here:  https://www.drupal.org/docs/develop/theming-drupal/creating-sub-themes#s... →

Adding in how to extend a base theme's config schema, so your theme doesn't need to define it.

I've added a new merge request with a tugboat configuration so we can review this more easily.

trackleft2 → changed the visibility of the branch 3485305-tgboat to hidden.

Looks like 📌 Allow the messages block to skip placeholdering Active was added to Drupal core 11.2.0-alpha1, so we should add that as the minimum drupal core version.

New patch with even better working alerts (both varieties) and toasts

Please review 🐛 New alert component doesn't appear to support classic alerts. Active to see if it resolves the issue.

See if #[3485305] fixes your issue.

I've added in a patch for the three message types.

trackleft2 → made their first commit to this issue’s fork.

This isn’t really a bug since the fixed-position .alert-wrapper is intentional — by design it ensures messages are always visible.

The patch does achieve the desired effect, but since it changes the current behavior for people who may like them the way they are, it probably belongs as a feature request.

A possible resolution would be to allow configuring the default alert positioning (e.g., absolute, fixed, etc.) through a theme setting, so site builders can choose the behavior without needing to patch or override templates.

I am closing, this as works as designed, but feel free to re-open it as a feature request.

trackleft2 → created an issue.

Converted to merge request for easier review. We' plan on using this patch in production soon, but have yet to roll it out yet. I'll report back once we have more real world feedback. Otherwise I think this should be OK to merge at any time.

trackleft2 → made their first commit to this issue’s fork.

4.1.0-alpha1 → released.
4.1.0-beta1 → released.