🇺🇸United States @trackleft2

Hi @vlyalko, how are you attempting to update.

We've been using the 2.0.0 version with masquerade 2.0 for quite some time now.

        "drupal/masquerade": "2.0.0",
        "drupal/masquerade_log": "2.0.0",

Could your issue be that you are updating the composer.json file by hand without deleting the composer.lock file after?

Have you tried
composer require 'drupal/masquerade_log:^2.0' --with-all-dependencies
Or

composer require 'drupal/masquerade:^2.0' --with-all-dependencies

This issue may already be fixed in 4.1.0-alpha1.

Hi @steveoriol this issue remains open because we aren't sure if it has already been resolved or not by the merged fix in 📌 Update module to use CSS variables instead of adding inline CSS. Active

There is a possibility that all issues discussed here have already been resolve in 4.1.0-alpha1.

If you discover more that needs to be done, please report back the steps needed to reproduce what you are seeing. Thank you so much for your interest in helping out.

Hi @pwolanin, thanks for filing this issue, I've created a new patch that hopefully resolves this issue.

To create the patch (and merge request), I simply duplicated logic from within the ToolbarHandler class within the hook functions that were previously calling the deprecated service.

Moving all of this code does feel somewhat risky so we'll definitely need to test that this doesn't cause a regression.

If the patch for 4.0.x suffices, I can also add a new patch and merge request for the 4.1.x version.

Have you seen any errors in your log that may be related?

trackleft2 → made their first commit to this issue’s fork.

trackleft2 → changed the visibility of the branch rebuild-tugboat to hidden.

4.1.0-alpha1 released! →

trackleft2 → created an issue.

I am updating this so we can add an alpha release cycle, meaning we can release now, and then add the planned features as they become ready.

We may want to kick the navigation module integration into 5.x in order to set the new minimum Drupal core version to core_version_requirement: '^10.5 || ^11.1.2'.

@svendecabooter & @jrb we could make it configurable simply be creating a new library with a new css file, and then only add the new library if the setting to color the logo is selected.

That said, let's move this feature request into a new issue to enhance the navigation integration[#3537419]. At the moment, I don't think we are thinking through all of the implications of coloring the logo, and it would be easier to test in isolation once this issue has been fixed.

For instance, how does it work for the other logo settings available in the navigation configuration?
What about custom logos?

trackleft2 → created an issue.

trackleft2 → changed the visibility of the branch 3536522-insufficient-permission-check to hidden.

trackleft2 → created an issue.

I've created a Merge Request, and a patch for use in the meantime. Please test, and let me know if it works for you, and we can create a new release.

OK, I'll backport the fix to the 4.0.x branch and create a new 4.0.25 release.

I was finally able to get all the tests to pass.

Removing ✨ use DraggableListBuilder Active from this release and moving to the next one. 🌱 Draft: Release Plan for Environment Indicator Minor Release 5.0.0-beta1 Active

This fix has been rolled into 📌 Update module to use CSS variables instead of adding inline CSS. Active which has been merged into the 4.x branch and is soon to be released as part of 4.1.0-alpha1 and this release plan 🌱 Draft: Release Plan for Environment Indicator 4.1.0-beta1 Active .

I've updated [!127] with the latest version of 4.x (with the improvements discussed here).

Additionally I've moved credit for this issue over to 📌 Update module to use CSS variables instead of adding inline CSS. Active and created a tugboat build on this issue for easier review. Tugboat builds expire after a few days.

Adding credit from ✨ Improve visibility when using Gin vertical and modern horizontal toolbars Needs work

trackleft2 → changed the visibility of the branch 3362940-improve-visibility-when-tugboat to hidden.

@dhruv.mittal & @nico.b I've merged a merge request on this issue ✨ Performance Improvements Active that should resolve this issue as well. https://git.drupalcode.org/project/environment_indicator/-/commit/324362...,

This is not yet included in a release, but it has been added to the next release plan 🌱 Draft: Release Plan for Environment Indicator 4.1.0-beta1 Active .

trackleft2 → created an issue.

Thank you for your comment @rafal.sereda, should we also check if the user has ever logged in before setting the value?

trackleft2 → created an issue.

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Is this still an issue in the 2.1.x version?

Released https://www.drupal.org/project/user_expire/releases/2.1.1 →

trackleft2 → created an issue. See original summary → .

I've tested this, and it appears to work as expected.

trackleft2 → changed the visibility of the branch 2855005-reset-expiry-on-reactivation-7x to hidden.

trackleft2 → changed the visibility of the branch 3431824-2-0-x to hidden.

Thank you for your interest in contributing to this module, however, your merge request targets an unsupported branch, for this reason I am closing your merge request as won't fix.
Also, this issue is meant for the project update bot to use.

Wow, that's great, thank you for the report!

Adding patch that doesn't update tests

Thanks I've added this to the release plan 🌱 Draft: Release Plan for Environment Indicator 4.1.0-beta1 Active

Update summary:

• I've added a new patch with all changes to be used with 11.x
• I've updated the Issue Summary for clarity
• I've updated the Change Record to add examples.
• Adjusted the constructor signature of MenuTreeStorage:
  • Allowed the $route_provider parameter to accept RouteProviderInterface|array|null for backwards compatibility.
  • Deprecated passing an array (formerly used for $options) or omitting the parameter entirely.
  • This deprecation will be enforced strictly in 12.x.
• Updated WorkspacesMenuTreeStorage::__construct() to pass the route provider explicitly to match the parent constructor changes.
• All tests now pass, including new deprecation coverage added in MenuTreeStorageTest.

I've updated the change record to show a code example, and changed the deprecation target and removal version numbers to reflect updated code.

See https://www.drupal.org/node/3364323 →

Need to update the Merge request against 11.x so that the PHPUnit tests pass and change the deprecation target to the next minor 11.3 and the removal as 12.

Possibly related to 🐛 [regression] missing menu active trail in Drupal 9.5.9 Needs work

I've created a patch for 10.4.x without fixing some of the tests available here.

I've updated the PHPUnit test in order to pass.
Also ran the test only changes.

trackleft2 → made their first commit to this issue’s fork.

The maintainers of this module have said multiple times that they don't want to add drupal:block as a dependency of this module.