🇺🇸United States @trackleft2

Tucson, AZ 🇺🇸
Account created on 2 April 2014, almost 11 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

I've added a bunch of PHPUnit Functional tests to ensure the right libraries load at the right time and that some of the selectors we use exist on the page.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Updated this Merge Request to incorporate upstream changes from 🐛 Gin vertical toolbar submenu's overlap Active
Note:
- This merge request changes fallback variable names to comply with style lint rules (Possibly a breaking change for people using the old variable)

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Needs work, there is an upstream merge conflict now.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Same, I hadn't heard of the date augmenter API until I installed Drupal CMS locally to try it out, and was just watching the list of installed modules.

How do you feel about adding this module's functionality into date_ap_style? Do you think that is a good idea?

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

I've added a "Similar Modules" section to the project page.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 created an issue.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

I've updated nearly every issue in the issue queue, and have updated this with some more fairly straight-forward issues that should be included IMHO.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

I've converted this into a merge request and updated the tests so that they pass.
Please make sure these tests are actually testing what we need.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Will have a merge conflict with 🐛 Address PHPStan Error Active depending on which is merged first as they both change how the searchIndex service is called.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

This can be closed as soon as the maintainers update the description on the module page https://www.drupal.org/project/search_exclude . with the suggestion in #7.

Thanks

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Also I've created a new issue over there: Support additional search page plugins. Active

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

That is because of the way that module works, https://git.drupalcode.org/project/search_current_language/-/blob/1.0.x/...

The tag that module uses is search_node_search

While the tag this module uses is search_exclude_node_search so you would need to update that module to add the new tag.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

FYI I've run the "Test only changes" test in gitlab and it failed with:

There was 1 error:
1) Drupal\Tests\search_exclude\Functional\ExcludedContentTest::testExcludingContent
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for search.page.content_exclude_ with the following errors: search.page.content_exclude_:configuration missing schema

See: https://git.drupalcode.org/issue/search_exclude-3507526/-/jobs/4400503

This means that the schema that I've added has fixed the test, so we can remove the protected $strictConfigSchema = FALSE; from the existing PHPUnit test.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 created an issue.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 created an issue.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 created an issue.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

I'm not able to reproduce this in Drupal 10.4 without the patch though I don't think it hurts anything.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Updated help file with suggested change. (Fixed link)

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Thank you for the screenshots @lavanyatalwar, it looks like the link is not being created.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Fix composer command for pinning to older version.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Drupal console appears to be abandoned and not installable on Drupal 9.5 and later and should not be recommended.

https://github.com/hechoendrupal/drupal-console

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

@solideogloria Thank you for all of your work on this module. It is very much appreciated.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

I have not been able to reproduce this on the 2.0.x branch.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 3450454-logicexception-when-logging to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 3450454-2.0.x to active.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 3450454-2.0.x to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 made their first commit to this issue’s fork.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Merged in 2.0.x

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 8.x-1.x to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 3450457-fix-coding-standards to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 2.0.x to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch project-update-bot-only to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 made their first commit to this issue’s fork.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 3502082-update-gitlab-ci-to to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 3502092-phpunit-test-failing to hidden.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

The state api is no longer being used for this: 🐛 drush migratation with --sync has suboptimal performance (v6) Active

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 made their first commit to this issue’s fork.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Adding more steps to instructions.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Changing title to sentence case.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Change menu link title to sentence case.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

change expire to block

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

less characters

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Update definitions to match module ui 

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Fix broken links

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

Thank you both for this report and merge request, I like the simplicity of the array_filter approach.

I've gone ahead and added some PHPUnit tests to hopefully prevent this issue from coming back once it is fixed.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 made their first commit to this issue’s fork.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

We've been using this patch on 500 sites for over a year. Seems to work.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

I've added a PHPUnit test

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

The patch from #10 works for me, I've create a merge request with the patch so we can continue work on this.
Changing to Needs work, because the maintainer said this needs tests.

🇺🇸United States trackleft2 Tucson, AZ 🇺🇸

trackleft2 changed the visibility of the branch 3295470-convert-image-style-cannot to hidden.

Production build 0.71.5 2024