trackleft2 → made their first commit to this issue’s fork.
trackleft2 → changed the visibility of the branch 3500630-demonstrate-a-better to hidden.
trackleft2 → created an issue.
I've removed the functionality from the field_link plugin as special_menu_items does not apply to link field AFAICT.
Updated the fork with 11.x, and set a new merge target (11.x)
trackleft2 → changed the visibility of the branch issue/drupal-3260219 to hidden.
trackleft2 → changed the visibility of the branch 11.x to hidden.
trackleft2 → changed the visibility of the branch 3426004- to hidden.
trackleft2 → changed the visibility of the branch 3426004-disable-drupal-ci to hidden.
trackleft2 → made their first commit to this issue’s fork.
trackleft2 → changed the visibility of the branch 3260219-allow-migrating-button to hidden.
This functionality came from https://www.drupal.org/project/special_menu_items → which has been discontinued as of Drupal 8 because the functionality was added to core so there is nowhere to put this as far as I can tell.
There is now a module for Associated Press Style dates: https://drupal.org/project/date_ap_style
editor_ckeditor module not ckeditor module
trackleft2 → created an issue.
trackleft2 → made their first commit to this issue’s fork.
trackleft2 → changed the visibility of the branch 3499513-address-spelling-issues to hidden.
trackleft2 → created an issue.
trackleft2 → created an issue.
trackleft2 → created an issue.
@dragos-dumi Interesting, thanks for the report. I'll make an issue for this module to create an automated test for how this module interacts with workspaces module.
We should consider just creating a documentation page and then linking to it instead of cluttering the project page with upgrade advice.
trackleft2 → created an issue.
trackleft2 → created an issue.
Closing this as a duplicate of 📌 Review and improve form field labels and description Active
Here are the definitions as defined in version 2.1.0
trackleft2 → created an issue.
trackleft2 → created an issue.
Update the title to use the new correct default version.
Derp, you're correct, I was on an outdated version of the branch. Once I pull the latest code down it looks good to me. Sorry!
I am on
Drupal version : 11.1.2-dev
That sounds good to me, thanks for the feedback.
trackleft2 → created an issue.
trackleft2 → created an issue.
trackleft2 → changed the visibility of the branch 3463221-review-and-improve-tugboat to hidden.
True, however I do think explicitly saying jQueryUI modules instead of jQuery modules is more accurate.
Feel free to close this issue as won't fix haha
trackleft2 → created an issue.
trackleft2 → created an issue.
This also fixes 📌 Add module description to info.yml Active
trackleft2 → made their first commit to this issue’s fork.
Thank you for your work on this, here is what I am seeing when I test the merge request, which does not appear to match the Figma with respect to the navigation item that does not have an icon.
My opinion is that the sub module issue does not need to block progress here, though I do feel the approach in MR !53 (the non-submodule version) does increase the maintenance burden for this module because of all of the variables needed when testing, but that is for the module maintainers to decide.
This should be blocked by 📌 Remove support for unsupported Drupal Core version in sub modules. Needs review and 🐛 New parameter added to \Drupal\Core\Form\ConfigFormBase::__construct Active
Adding back config_distro_ignore since that module isn't deprecated.
trackleft2 → made their first commit to this issue’s fork.
I've updated the issue to add a merge request that attempts to update the patch with the 2.x version of config_distro in case this helps anyone.
I've also fixed some code style issues.
trackleft2 → created an issue.
Can Config Distro Ignore be replaced by v3 of Config Ignore at this point? My team uses config_ignore to ignore distribution configuration, so I'm not sure if this sub module is necessary.
trackleft2 → created an issue.
trackleft2 → created an issue.
trackleft2 → made their first commit to this issue’s fork.
Similar work was done to remove dependency on config_filter on ✨ Add sub-module which subscribes to the Drupal 8.8 config storage transformation events Active
Looks like you could add the following to the gitlab-ci.yml file
variables:
_CSPELL_WORDS: 'Frenssen, Pescetti, Pieter, ademarco, joegraduate, pescetti, pfrenssen'
See https://project.pages.drupalcode.org/gitlab_templates/jobs/cspell/
trackleft2 → created an issue.
trackleft2 → made their first commit to this issue’s fork.
I like the new approach, also, I've updated the change record to include OOP/attribute example for the hooks.
trackleft2 → made their first commit to this issue’s fork.
Looks good to me.
Not sure if it matters, but it was found that environment indicator module does not need this patch in order to integrate into the navigation module.
See https://git.drupalcode.org/project/environment_indicator/-/merge_request...
Do you think a custom cache bin is in order to do all of this, or do you recommend a specific cache bin? https://api.drupal.org/api/drupal/core%21core.api.php/group/cache/11.x
The main concern I have about invalidating the cache is during automated processes, like site updates for example, how do we ensure the module continues to function the same way (not needing a cache rebuild before drush cd-update) and also cache the comparisons and lists.
What do you propose we actually cache?
In ConfigSyncLister, we could cache:
Configuration Comparisons:
Precomputed differences between active and target configurations (e.g., added, updated, deleted items).
Changelists:
Detailed lists of configuration changes, including metadata like labels, types, and dependencies.
Extension Lists:
Precomputed lists of extensions with configuration to synchronize.
These items are computationally expensive but can be invalidated and recomputed as needed when the underlying data or context changes.
I am not sure if we will be able to detect changes in order to invalidate the cache once we have it, but I could be missing something.