I've added a post update function that just resaves all of the existing cron migrations on the site in order to recalculate dependencies.
I think we need to add a post_update function in order to update existing cron migration config entities to add their dependencies.
trackleft2 → changed the visibility of the branch 2.1.x to hidden.
trackleft2 → changed the visibility of the branch 3451525-add-config-dependency to hidden.
The PHPUnit test introduced in this MR does not appear to adequately test this functionality.
I say this because the https://git.drupalcode.org/project/user_expire/-/jobs/5542470 test passed with or without the fix. Running the "Test Only Changes" test should fail but it does not.
trackleft2 → changed the visibility of the branch 8.x-1.x to hidden.
trackleft2 → created an issue.
Hi sahil.sharma@io-media.com I'll add this to the plan for the next release. Thanks! The patch looks ok to me, so feel free to use it until then.
Sorry for taking so long in creating a release with this in it. We have a lot tied up in our release number at the moment and don't want to back track since our next patch release should drop any day now and it would be a lot of administrative work to sneak in a hotfix.
On the bright side, during the process of creating the new release, we did realize that we should be supporting 7.3 and Drupal 9.3 and changed that to our target.
I've updated this to add dynamic title handling for the edit and delete form pages, and put it in a merge request with a tugboat preview.
trackleft2 → made their first commit to this issue’s fork.
Sounds like this has been resolved, I've added to the documentation: https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
Move Environment switchers link above inline code help.
Adding config split instructions
Update headings
adding links
Add example that would cover multiple environments.
Add link to config split documentation https://www.drupal.org/docs/contributed-modules/configuration-split/crea... →
Bolding the module names to further promote modular architecture.
I've rerolled all of the ideas here into merge request !102
Looks like this:
Additionally, the favicon works in !102
Update wording in a few places and add information about sub modules.
trackleft2 → changed the visibility of the branch 4.x to hidden.
PHPUnit test broken
trackleft2 → changed the visibility of the branch 3484735-move-toolbar-integration to hidden.
This should be ready for final review.
Closing this issue in favor of combining with ✨ Extract Indicator Context logic from ToolbarHandler into new Context service Active
This should also enable this [#3374955]
In the database update, we should check whether the toolbar module is enabled before enabling the environment_indicator_toolbar submodule. If toolbar is not enabled, then environment_indicator_toolbar should not be enabled.
My reasoning:
- If the toolbar_integration config is set to ["toolbar" => "toolbar"] but the toolbar module isn’t enabled, then enabling environment_indicator_toolbar would result in a change in functionality: it would add the environment indicator to the toolbar (instead of #page_top) and also change the color of the toolbar. This could be unexpected or undesired.
- There’s also a risk in the opposite direction: since the libraries have changed, someone may be depending on the old toolbar-related libraries even if the toolbar integration option is not selected. In this case, the module will no longer work for them, and a new issue should be created for an additional integration.
To avoid introducing unexpected behavior, we should only enable environment_indicator_toolbar if the toolbar module is already enabled.
Thanks! Closing as a duplicate.
@indrajithkb is this still an issue in the Dev version of this module? https://www.drupal.org/project/environment_indicator/releases/4.x-dev →
trackleft2 → created an issue.
trackleft2 → created an issue.
Duplicate of 💬 Granular permissions are not working as expected. Active
trackleft2 → created an issue.
Also, it appears that all of the gitlab-ci tests are currently passing due to this issue: 💬 Validate stage may use outdated artifact, leading to flaky test results Active
I've updated the PHPUnit tests so that they pass in all of the gitlab-ci jobs.
While updating the PHPUnit Test I was testing the module using the combination of PHP 8.3 and Drupal Core 11.0.13 as well.
trackleft2 → created an issue.
At the moment, when I enable the gin_toolbar module without the gin them being enabled the javascript breaks because the toolbar id changes from toolbar-bar to gin-toolbar-bar.
Additionally, when enabling the submodule the "default" environment indicator appears.
What should we do about the toolbar integration setting? I think if the environment_indicator_toolbar submodule is enabled, the default indicator should be disabled to keep existing functionality.
Fixed in 4.x to be released in 4.0.22 🌱 [META] Release Plan for Environment Indicator Patch Release 4.0.21 Needs review
Fixed in #3092900: Issue when viewing front page → where I've added credit.
trackleft2 → changed the visibility of the branch 3065135-add-support-for-tugboat to hidden.
FYI I've added instructions to this module's .tugboat configuration file to install gin and gin_toolbar module, set gin as the default admin theme, and three environment switchers in order to help us test.
To view a demo site with a copy of the module installed with this merge request applied, click the view live preview link under this issue's summary.
To log in use these credentials
username: admin
password: admin
I've done the same on 📌 Update module to use CSS variables instead of adding inline CSS. Active If you'd like to review that alternate Merge request.
FYI I've added instructions to this module's .tugboat configuration file to install gin and gin_toolbar module, set gin as the default admin theme, and three environment switchers in order to help us test.
To view a demo site with a copy of the module installed with this merge request applied, click the view live preview link under this issue's summary.
trackleft2 → changed the visibility of the branch 3487973-add-gin-theme to hidden.
Hi there, if this issue is resolved by either 🐛 Gin Compatibility: Account for "open" vertical toolbar Closed: outdated or 📌 Update module to use CSS variables instead of adding inline CSS. Active we could use your review on those issues instead. If so, please close this one as either a duplicate or outdated.
Hi, were you experiencing any console errors on the environment that the favicon is broken on? I noticed that the dependency order of the libraries is weird in this file https://git.drupalcode.org/project/environment_indicator/-/blob/4.x/envi...
If it is a load order thing, the solution in ✨ Separate Tinycon into its own library and use favicon option to determine inclusion. Active may resolve it.
I've converted the patch to a merge request and updated it to integrate any upstream changes that have been merged.
Unfortunately this does not seem to work for me using Lando for local development.
If I enter: /core/themes/olivero/favicon.ico
The Json settings output looks like this
"environmentIndicator":{"name":"Lando","fgColor":"#EFEFEF","bgColor":"#990055","addFavicon":true,"faviconPath":"\/app\/web\/core\/themes\/olivero\/favicon.ico","toolbars":{"toolbar":"toolbar"}}
Seems to be setting the absolute path on the server.
Here is my config
```
name: environment_indicator
recipe: drupal10
config:
php: '8.3'
via: apache:2.4
webroot: web
database: mariadb:10.6
xdebug: false
services:
database:
type: compose
services:
image: mariadb:10.6
command: docker-entrypoint.sh mariadbd
restart: always
ports:
- '3306'
environment:
MARIADB_ALLOW_EMPTY_ROOT_PASSWORD: 'true'
MARIADB_DATABASE: drupal10
MYSQL_DATABASE: drupal10
MARIADB_USER: drupal10
MARIADB_PASSWORD: drupal10
appserver:
overrides:
environment:
SIMPLETEST_DB: 'mysql://drupal10:drupal10@database/drupal10'
SIMPLETEST_BASE_URL: 'http://appserver'
volumes:
# Don't share our host working directory as /app. We want /app empty for composer.
- /app
# Instead share our host working directory as a standalone package.
- .:/usr/local/environment_indicator
build:
# Create a new Drupal project and use the module as a non-packagist repository.
- composer create-project --dev drupal/recommended-project:11.1.x /app
- composer config extra.enable-patching true
- composer config extra.composer-exit-on-patch-failure true
- composer config allow-plugins.cweagans/composer-patches true
- composer require cweagans/composer-patches
- composer config minimum-stability dev
- composer config allow-plugins.phpstan/extension-installer true
- composer require --dev drupal/core-dev:^11.1 drush/drush phpspec/prophecy-phpunit:* phpstan/extension-installer mglaman/phpstan-drupal phpstan/phpstan-deprecation-rules drupal/config_inspector drupal/devel drupal/gin
- composer config repositories.localdev path /usr/local/environment_indicator && composer require drupal/environment_indicator:\*@dev
node:
type: node:20
build:
- yarn install
chromedriver:
type: compose
services:
image: seleniarm/standalone-chromium:4.1.4-20220429
command: /opt/bin/entry_point.sh
tooling:
# Provide a command to install Drupal.
install:
service: appserver
cmd:
- /app/vendor/bin/drush --root=/app/web site:install --account-mail=noreply@example.com --account-name=admin --account-pass=admin --db-url=mysql://drupal10:drupal10@database:3306/drupal10 -y --verbose
- /app/vendor/bin/drush --root=/app/web en -y environment_indicator environment_indicator_ui devel config_inspector
- /app/vendor/bin/drush --root=/app/web theme:enable -y gin
- /app/vendor/bin/drush --root=/app/web config:set -y system.theme admin gin
- /app/vendor/bin/drush --root=/app/web en -y gin_toolbar
- /app/vendor/bin/drush --root=/app/web config:set -y environment_indicator.indicator name 'Lando'
- /app/vendor/bin/drush --root=/app/web config:set -y environment_indicator.indicator bg_color '#990055'
- /app/vendor/bin/drush --root=/app/web config:set -y environment_indicator.indicator fg_color '#EFEFEF'
- /app/vendor/bin/drush --root=/app/web uli -l https://environmentindicator.lndo.site/
# Provide Drush tooling to automatically know the Drupal root.
drush:
service: appserver
cmd: /app/vendor/bin/drush --root=/app/web
phpcs:
service: appserver
cmd: /app/vendor/bin/phpcs -s --colors --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/environment_indicator
# Provide PHPCBF tooling to fix coding standards.
phpcbf:
service: appserver
cmd: /app/vendor/bin/phpcbf -s --colors --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/environment_indicator
# Provide phpstan tooling to check for code quality and deprecated code.
phpstan:
service: appserver
cmd: /app/vendor/bin/phpstan analyse --configuration web/modules/contrib/environment_indicator/phpstan.neon web/modules/contrib/environment_indicator
# Provide phpunit tooling to run unit tests.
phpunit:
service: appserver
cmd: /app/vendor/bin/phpunit --configuration /app/web/core/phpunit.xml.dist --bootstrap /app/web/core/tests/bootstrap.php /app/web/modules/contrib/environment_indicator
yarn:
service: node
cmd: yarn
eslint:
service: node
cmd: yarn run eslint --color
```
trackleft2 → made their first commit to this issue’s fork.
I've set a release target for 🌱 Draft: Release Plan for Environment Indicator Minor Release 5.0.0-beta1 Active
Thank you for your inquiry, I've updated the issue summary. I welcome a merge request