- Issue created by @joachim
- 🇬🇧United Kingdom joachim
> - the render array returned by EnvironmentIndicatorListBuilder looks like it's nonstandard, as switching it to inherit from DraggableListBuilder causes a lot of errors.
Correction -- the problem is that DraggableListBuilder doesn't handle rows the same as its parent class.
- 🇬🇧United Kingdom joachim
Done, but needs 🐛 weight property should be declared as an int in config schema Needs review to be committed first.
- Status changed to Needs review
10 months ago 2:45pm 6 March 2024 - 🇪🇸Spain isholgueras
Hi joachim, 🐛 weight property should be declared as an int in config schema Needs review was released in 4.0.18.
Can this be tested or there is some work left to do?
- First commit to issue fork.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
I reviewed this merge request and found the following issues.
- the $row['label'] property appears to only allow #plain_text, so we can't put markup in there.
- list builder behaves differently for each of the following circumstances
- 1 environment indicator in config, weight column should not be present, drag handle should not be present.
- 0 environment indicators in config, there should be a link to create a new environment indicator
- 2 or more environment indicators in config, weight column should now be present, drag handle should now be present.The preview column will show a visual representation of the selected options in the preview column. The preview shows the Name of the environment indicator with the text color and background color applied.
I've updated the code in the merge request so that all of the above works.