Insufficient permission check for toolbar integration

Opened a MR to fix the issue.

The lint tests seem to fail, but shouldn't be related to the changes from the MR at all. All other tests seem to pass.

Reviewing this

I've checked that issue persist and MR is resolving the issue so moving it to RTBC

@dhruv.mittal & @nico.b I've merged a merge request on this issue ✨ Performance Improvements Active that should resolve this issue as well. https://git.drupalcode.org/project/environment_indicator/-/commit/324362...,

This is not yet included in a release, but it has been added to the next release plan 🌱 Draft: Release Plan for Environment Indicator 4.1.0-beta1 Active .

@trackleft2 While that (when looking at the code changes only) indeed seems to fix the issue, I'm wondering whether a fix for this issue is really something that should wait for a new feature release, especially considering it is a permissions-related issue?

I was experiencing this issue on 4.0.24. While the MR solves the permission check for color, I'm now seeing the Environment Menu in the toolbar for a role that has no permissions related to this module.

This seems to be fixed in the 4.x dev release as indicated by comment #8.

OK, I'll backport the fix to the 4.0.x branch and create a new 4.0.25 release.

I've created a Merge Request, and a patch for use in the meantime. Please test, and let me know if it works for you, and we can create a new release.

trackleft2 → changed the visibility of the branch 3536522-insufficient-permission-check to hidden.

I can confirm that this patch/MR is also resolving the issue, so moving it to RTBC.