@dhruv.mittal

Reviewing it

🐛 | Page Manager | Route "entity.page_variant.edit_form" does not exist.

Comment 2 days ago →

Now I can confirm this issue persists and able to resolve the issue using the patch
Thank you

✨ | Domain | Add views filter "Available on current domain" for users

Please review

✨ | Domain | Add views filter "Available on current domain" for users

Working on it

🐛 | Domain | Domain access: TypeError in hook_node_grants can completely crash site

✨ | Domain | Permission allows access to view domain entity

✨ | Domain | Permission allows access to view domain entity

🐛 | Domain | Domain access: TypeError in hook_node_grants can completely crash site

✨ | Domain | Permission allows access to view domain entity

🐛 | Page Manager | [PHP8.4] Misc null deprecation warning on a few files

Comment 16 days ago →

Changes looks good to me so moving it to RTBC

🐛 | Page Manager | Route "entity.page_variant.edit_form" does not exist.

Comment 16 days ago →

Hey @karavkars
I tried to reproduce the error following the steps to reproduce
But could not able to do so I'm attaching the Video for your reference please have a look and Let me know If I'm missing something
Thank You

🐛 | Page Manager | [PHP8.4] Misc null deprecation warning on a few files

reviewing it

🐛 | Page Manager | Route "entity.page_variant.edit_form" does not exist.

🐛 | Menu Manipulator | Error when navigation to settings form

I'm able to reproduce the error and after applying the MR error is resolved. screenshots are attached FYR
So moving to the RTBC.

🐛 | Menu Manipulator | Error when navigation to settings form

Reviewing it

🐛 | Link checker | Rename config value blacklist to blocklist

Instead of changing the blacklist to blocklist, We can just make a cspell file in which we can ignore blacklist, blacklisted, blacklists, whitelist word
Let me know if this solution sounds good then I'll proceed.

🐛 | Babel | Service Container Anti-Pattern

Changes look good to me as use of \Drupal::service() is not ideal way.
So Moving it to RTBC+.
Thank you

🐛 | Babel | Service Container Anti-Pattern

🐛 | Media file delete | Call to a member function getDisplayName() on null in Drupal\media_file_delete\Form\MediaDeleteForm->buildForm() (line 58 MediaDeleteForm.php)

Reviewing it

🐛 | Link checker | Rename config value blacklist to blocklist

🐛 | Social Auth Roles | user_roles() deprecated in D11.

please review

🐛 | Social Auth Roles | user_roles() deprecated in D11.

✨ | Paragraphs Modal Edit | Make modal dialog width configurable

🐛 | Media file delete | Call to a member function getDisplayName() on null in Drupal\media_file_delete\Form\MediaDeleteForm->buildForm() (line 58 MediaDeleteForm.php)

Added a configuration Form and Modal width configurable.

Comment 18 days ago →

🐛 | JSON:API Resources | Use own _auth if configured

Comment 19 days ago →

✨ | Paragraphs Modal Edit | Make modal dialog width configurable

Comment 19 days ago →

🐛 | Parameters | PHP 8.4 compatibility

Comment 19 days ago →

Please review

🐛 | Parameters | PHP 8.4 compatibility

Comment 22 days ago →

🐛 | Display Suite | PHP 8.4 - Implicitly nullable via default value null deprecation

🐛 | JSON:API Resources | Code results in "array_merge() does not accept unknown named parameters"

Changes looks good to me, so moving it to RTBC

🐛 | JSON:API Resources | Use own _auth if configured

🐛 | Anti-Duplicates | ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct()

Created MR as Remaining task suggested and moving it to needs review

💬 | Paragraphs Previewer | PHP 8.4 compatibility issue

Changes looks good to me, So moving it to RTBC

📌 | Varnish purger | composer require 'drupal/varnish_purge' does not install dependencies

📌 | Varnish purger | composer require 'drupal/varnish_purge' does not install dependencies

🐛 | JSON:API Resources | Code results in "array_merge() does not accept unknown named parameters"

🐛 | Display Suite | PHP 8.4 - Implicitly nullable via default value null deprecation

🐛 | Anti-Duplicates | ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct()

Reviewing it

🐛 | Read-only Field Widget | PHP 8.4 implicit nullable deprecation

Changes looks fine to me.
so moving it to RTBC

💬 | Paragraphs Previewer | PHP 8.4 compatibility issue

Comment 24 days ago →

🐛 | Migrate Plus | ValueError: XMLReader::open(): Argument #1 ($uri) cannot be empty in XMLReader->open()

Reviewing it

Comment 24 days ago →

🐛 | Migrate Plus | ValueError: XMLReader::open(): Argument #1 ($uri) cannot be empty in XMLReader->open()

I mistakenly rerolled onto 6.0.x branch so for the same I've created new clean branch
Apologies

Comment 24 days ago →

dhruv.mittal → changed the visibility of the branch 3284318-valueerror-xmlreaderopen-argument to hidden.

🐛 | Read-only Field Widget | PHP 8.4 implicit nullable deprecation

Reviewing it

📌 | Replicate UI | Fix PHP 8.4 implicit nullable deprecation

🐛 | Migrate Plus | ValueError: XMLReader::open(): Argument #1 ($uri) cannot be empty in XMLReader->open()

Changes looks good to me so moving it to RTBC.

🐛 | Access unpublished | Make accessUnpublishedClipboardCopy js behavior work for buttons too

Created MR as MR is easy to review and patch is deprecated and corrected the issue status.

🐛 | Sitemap | Problem with sitemap_update_8101()

Comment 29 days ago →

Changes look good to me so moving it to RTBC

📌 | Replicate UI | Fix PHP 8.4 implicit nullable deprecation

Comment 29 days ago →

Reviewing it

🐛 | Access unpublished | Make accessUnpublishedClipboardCopy js behavior work for buttons too

🐛 | Wordfilter | TokenWordfilterProcess not implementing ContainerFactoryPluginInterface

Corrected the state and created a MR for easy review
Thanks

🐛 | Wordfilter | TokenWordfilterProcess not implementing ContainerFactoryPluginInterface

🐛 | Layout Builder Symmetric Translations | Argument 1 passed to Drupal\layout_builder_st\EventSubscriber\ComponentPluginTranslate::isTranslation() must implement interface Drupal\layout_builder\SectionStorageInterface, null given

Kindly review

🐛 | Crowdin Translation Plugin | Export approved translations only is ignored

I've rerolled and created MR for easy review
Please review
Thanks

🐛 | Sitemap | Problem with sitemap_update_8101()

Reviewing this

🐛 | Password Separate Form | PHP 8.4 Implicitly marking parameter as nullable is deprecated

🐛 | Crowdin Translation Plugin | Export approved translations only is ignored

🐛 | Config Pages | entity.config_pages.edit_form is never used

Please review

✨ | Entity Print | Add link settings to the views global print link

🐛 | Password Separate Form | PHP 8.4 Implicitly marking parameter as nullable is deprecated

🐛 | Config Pages | entity.config_pages.edit_form is never used

✨ | Entity Print | Add link settings to the views global print link

🐛 | Search API | HtmlFilter mishandling  

Please review

🐛 | Search API | HtmlFilter mishandling  

🐛 | Book PDFs | Exception when used with contrib book

Please review

🐛 | Environment Indicator | Insufficient permission check for toolbar integration

I've checked that issue persist and MR is resolving the issue so moving it to RTBC

🐛 | Environment Indicator | Insufficient permission check for toolbar integration

✨ | User Expire | if a user is activated, deactivated by the module, and reactivated by an admin, reset their expiration period

Reviewing this

✨ | User Expire | if a user is activated, deactivated by the module, and reactivated by an admin, reset their expiration period

I've added test for the changes please review

🐛 | Quick Node Clone | NodeForm namespace has changed

🐛 | Quick Node Clone | NodeForm namespace has changed

I can confirm that NodeForm namespace has changed and moving it to the right state with creating the MR of it and providing
reference link of the changes
https://www.drupal.org/node/3517871 →

🐛 | Entity Print | FileSystemInterface replace behavior constants are deprecated

Updated to the latest and code and removed the merge error.
Kindly review.

🐛 | Entity Print | FileSystemInterface replace behavior constants are deprecated

🐛 | File Delete (D8/D9/D10) | "Adding non-existent permissions to a role is not allowed." error

🐛 | Mailchimp | Error when installing mailchimp_signup module

I followed your instruction to reproduce the error but I didn't get any error while enabling the module using drush.
Please let me know if I'm missing something.
Thank you !!

🐛 | Mailchimp | Error when installing mailchimp_signup module

Reviewing it

🐛 | Taxonomy Menu | Main menu inaccessible after disabling Taxonomy Menu

Please review

🐛 | File Delete (D8/D9/D10) | "Adding non-existent permissions to a role is not allowed." error

🐛 | Taxonomy Menu | Main menu inaccessible after disabling Taxonomy Menu

🐛 | Video | Implicitly marking parameter $site_path as nullable is deprecated

@divyansh.gupta please review I have removed .gitlab-ci.yml file. Now all the changes are only related to this issue.

🐛 | Video | Implicitly marking parameter $site_path as nullable is deprecated

Working on it

✨ | Editor Advanced link | Add 'lang' attribute option

Merge conflicts need to be resolved

✨ | Autofill | Support string replace option on the autofilling

Automated tests are needed to test the feature.

🐛 | Mail Login | Regular login fails if "Enable login by email address" option is not enabled

I tested The MR.
It is working fine and removing error thus moving it to RTBC.

🐛 | Market Wave | Hamburger menu not working

Mentioned issue is present in the theme. After applying the MR issue is getting resolved.
Attaching the screenshot FYR.
Before

After

So Moving it to RTBC.

📌 | Quick Edit | Deprecated trait EntityReferenceTestTrait

I'm not able to see any deprecated Trait related warning.
Would you check it once again or please provide screenshots for the same.
Thanks.

🐛 | Bynder | Add hook for Bynder remote media deletion handling

📌 | Geolocation Field | PHP Deprecated: Drupal\geolocation\LocationInputManager::getForm(): Implicitly marking parameter $default_value as nullable is deprecated, the explicit nullable type must be used instead in geolocation/src/LocationInputManager.php

🐛 | Inline Entity Form | Warning : foreach() argument must be of type array|object, null given dans inline_entity_form_close_all_forms()

🐛 | Client-side Hierarchical Select | PHP 8.4 - Implicitly nullable via default value null deprecation

Thanks for the patch
Working fine for me so moving it to RTBC.

📌 | Quick Edit | Deprecated trait EntityReferenceTestTrait

🐛 | Mail Login | Regular login fails if "Enable login by email address" option is not enabled

🐛 | SAML Authentication | Field description for value_map does not match actual behavior

🐛 | Client-side Hierarchical Select | PHP 8.4 - Implicitly nullable via default value null deprecation

As patch has been deprecated and MR is easier to review so I raised MR.
Please Review

🐛 | Link checker | "Don't treat these response codes as errors" not used

🐛 | SAML Authentication | Field description for value_map does not match actual behavior

🐛 | Link checker | "Don't treat these response codes as errors" not used

MR !102 has Merge conflicts and those need to resolved. So moving it back to Needs work for the same reason.

🐛 | Link checker | "Don't treat these response codes as errors" not used