@dhruv.mittal

I'm not able to see any deprecated Trait related warning.
Would you check it once again or please provide screenshots for the same.
Thanks.

🐛 | Bynder | Add hook for Bynder remote media deletion handling

📌 | Geolocation Field | PHP Deprecated: Drupal\geolocation\LocationInputManager::getForm(): Implicitly marking parameter $default_value as nullable is deprecated, the explicit nullable type must be used instead in geolocation/src/LocationInputManager.php

🐛 | Inline Entity Form | Warning : foreach() argument must be of type array|object, null given dans inline_entity_form_close_all_forms()

🐛 | Client-side Hierarchical Select | PHP 8.4 - Implicitly nullable via default value null deprecation

Thanks for the patch
Working fine for me so moving it to RTBC.

📌 | Quick Edit | Deprecated trait EntityReferenceTestTrait

Comment 5 days ago →

🐛 | Mail Login | Regular login fails if "Enable login by email address" option is not enabled

Comment 8 days ago →

🐛 | SAML Authentication | Field description for value_map does not match actual behavior

Comment 8 days ago →

🐛 | Client-side Hierarchical Select | PHP 8.4 - Implicitly nullable via default value null deprecation

As patch has been deprecated and MR is easier to review so I raised MR.
Please Review

Comment 8 days ago →

🐛 | Link checker | "Don't treat these response codes as errors" not used

🐛 | SAML Authentication | Field description for value_map does not match actual behavior

🐛 | Link checker | "Don't treat these response codes as errors" not used

MR !102 has Merge conflicts and those need to resolved. So moving it back to Needs work for the same reason.

🐛 | Link checker | "Don't treat these response codes as errors" not used

📌 | WebP | Nullable types must be explicit

I agree that Nullable types must be explicit.
And changes looks fine so marking it to RTBC

📌 | WebP | Nullable types must be explicit

🐛 | CAPTCHA | captcha_point_load($id) need to validate the $id

Comment 10 days ago →

🌱 | Patternkit | Patternkit 9.1.2 Release Plan

Comment 11 days ago →

slucero → credited dhruv.mittal → .

🐛 | CAPTCHA | captcha_point_load($id) need to validate the $id

Comment 12 days ago →

📌 | Drupal core | Never bypass validation when saving a config object

Comment 15 days ago →

Please Review.

📌 | Drupal core | Never bypass validation when saving a config object

Comment 15 days ago →

📌 | Geolocation Field | PHP Deprecated: Drupal\geolocation\LocationInputManager::getForm(): Implicitly marking parameter $default_value as nullable is deprecated, the explicit nullable type must be used instead in geolocation/src/LocationInputManager.php

Working on this

Comment 16 days ago →

🐛 | Inline Entity Form | Warning : foreach() argument must be of type array|object, null given dans inline_entity_form_close_all_forms()

Thank you for your contribution @undersound3.
But as Patch is deprecated and MR is easy to review and apply, So I have converted your patch into MR.
Thank you

Comment 17 days ago →

✨ | Text field formatter | Provide the option to specify the element class

Comment 17 days ago →

📌 | Geolocation Field | PHP Deprecated: Drupal\geolocation\LocationInputManager::getForm(): Implicitly marking parameter $default_value as nullable is deprecated, the explicit nullable type must be used instead in geolocation/src/LocationInputManager.php

Comment 17 days ago →

🐛 | Pathauto | Fatal error: Declaration of Drupal\pathauto\PathautoFieldItemList::computeValue() must be compatible with Drupal\path\Plugin\Field\FieldType\PathFieldItemList::computeValue(): void in contrib/pathauto/src/PathautoFieldItemList.php

Comment 18 days ago →

Hey @mkalkbrenner
Thank you for the patch but would you please share the steps to reproduce.

🐛 | Book PDFs | Exception when used with contrib book

Comment 18 days ago →

🐛 | Universal media formatter | Cannot load the "%s" entity with NULL ID

Comment 19 days ago →

🐛 | Universal media formatter | Cannot load the "%s" entity with NULL ID

Comment 22 days ago →

📌 | Language Cookie | Fix php 8.4 deprecations

📌 | Bakery Single Sign-On System | Remove the "restrict access" label from the Bypass Bakery permission

📌 | Language Cookie | Fix php 8.4 deprecations

📌 | Coffee | core_version_requirement: ^10.2 || ^11.0

Please review

📌 | Currency | PHP 8.4 implicit nullable is deprecated

I have successfully reproduced the issue.
And after applying the MR the issue is gone.
so Moving it to RTBC.

🐛 | Conditional Fields | When adding required to textarea with summary, both became required.

Hey impol!
This issue is fixed in the newer version of the conditional_fields and it no more persists.
Thank you !

📌 | Coffee | core_version_requirement: ^10.2 || ^11.0

🐛 | Password Separate Form | Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\change_pwd_page\Form\ChangePasswordForm->validateForm() (line 148 of modules/contrib/change_pwd_page/src/Form/ChangePasswordForm.php)

🐛 | Password Separate Form | Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\change_pwd_page\Form\ChangePasswordForm->validateForm() (line 148 of modules/contrib/change_pwd_page/src/Form/ChangePasswordForm.php)

Created MR against 2.x branch kindly review

🐛 | Password Separate Form | Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\change_pwd_page\Form\ChangePasswordForm->validateForm() (line 148 of modules/contrib/change_pwd_page/src/Form/ChangePasswordForm.php)

🐛 | Password Separate Form | Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\change_pwd_page\Form\ChangePasswordForm->validateForm() (line 148 of modules/contrib/change_pwd_page/src/Form/ChangePasswordForm.php)

Rebased the MR as it was some commit behind. and will create a new MR that will target 2.x

🐛 | Password Separate Form | Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\change_pwd_page\Form\ChangePasswordForm->validateForm() (line 148 of modules/contrib/change_pwd_page/src/Form/ChangePasswordForm.php)

dhruv.mittal → made their first commit to this issue’s fork.

📌 | Currency | PHP 8.4 implicit nullable is deprecated

🐛 | Conditional Fields | When adding required to textarea with summary, both became required.

📌 | Entity Share | set max_length for entity_import_status base fields

✨ | Estimated Read Time | Allow an empty default value

✨ | Password Policy | Allow the ignored routes in the PasswordPolicyEventSubscriber to be alterable

Created MR as it is easy to review.

📌 | Varnish purger | composer require 'drupal/varnish_purge' does not install dependencies

please Review

📌 | Entity Share | set max_length for entity_import_status base fields

✨ | Password Policy | Allow the ignored routes in the PasswordPolicyEventSubscriber to be alterable

📌 | Varnish purger | composer require 'drupal/varnish_purge' does not install dependencies

✨ | Estimated Read Time | Allow an empty default value

Hi @cgoffin,
Thank you so much for the patch — I’ve tested it, and it’s working perfectly on my end!

I just had a small question, if you don’t mind : ) I was wondering about the decision to leave the default value field empty. Would it perhaps make sense to assign a default value instead?

Appreciate your help and insights !
Thanks

🐛 | Bynder | Add hook for Bynder remote media deletion handling

✨ | Estimated Read Time | Allow an empty default value

Reviewing

🐛 | Ultimate Cron | CSRF on entity.ultimate_cron_job.unlock route

Please review

🐛 | Bynder | Add hook for Bynder remote media deletion handling

🐛 | Leaflet | replase <u> with <em> in ui strings

🐛 | Filter Permissions | PermissionsForm should not use overridden permissions

🐛 | Ultimate Cron | CSRF on entity.ultimate_cron_job.unlock route

📌 | DeferJs | Deprecated warning and foreach error in deferjs_js_alter() when installing DeferJS module on Drupal 10.3

📌 | DeferJs | Deprecated warning and foreach error in deferjs_js_alter() when installing DeferJS module on Drupal 10.3

Hello @rohit rana
I have installed the module in the suggested version, but I could not get any warning messages in Logs.
Can you share ss or proper steps to reproduce so that I can review the issue thank you

🐛 | Mailjet | Error: Call to undefined function Drupal\mailjet\Form\drupal_get_path() in Drupal\mailjet\Form\MailjetSettingsForm->buildForm()

🐛 | Mailjet | Error: Call to undefined function Drupal\mailjet\Form\drupal_get_path() in Drupal\mailjet\Form\MailjetSettingsForm->buildForm()

Added dependency injection as asked.
Please review

🐛 | CivicTheme | Remove Shortcut from theme dependency

moved to NR as MR is provided

📌 | Smart Trim | Missing schema 'more_class'

🐛 | Password Policy | Password policy should ignore the current password when attempting to reset the password

I have resolved all the pipeline errors those were occurred by my changes. please review now

🐛 | Password Policy | Password policy should ignore the current password when attempting to reset the password

I've tried to reproduce the issue with the given steps to reproduce but couldn't able to do so.
So unassigned myself for more info

🐛 | Navigation + | The controller for URI "/navigation-plus/load-editable-page" is not callable

🐛 | Business Rules | BusinessRulesBreadcrumb must be compatible with PathBasedBreadcrumbBuilder on Drupal 10.4.0 and above

Hey @trickfun would you please provide steps to reproduce.

@chhavi.sharma Thanks for the MR. However, it seems the phpunit is failing due to this merge request. Please take a look.

📌 | Commerce Gift Card | Add Explicit Return Types and Discussion on Return Value

🐛 | Navigation + | Symfony\Component\Routing\Exception\RouteNotFoundException: Route "navigation_plus.settings" does not exist.

There is merge error please look @lavanyatalwar..

✨ | User registration password | Re-implement hook user_registrationpassword_activated_user

dhruv.mittal → created an issue.

🐛 | Navigation + | The controller for URI "/navigation-plus/load-editable-page" is not callable

✨ | User registration password | Re-implement hook user_registrationpassword_activated_user

🐛 | Hotjar | Fatal error: $typedConfigManager must be Drupal\Core\Config\TypedConfigManagerInterface

🐛 | Error prepend string | Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: Class "Drupal\error_prepend_string\EventSubscriber\ErrorPrependStringEventSubscriber" used for service ".......

I encountered the mentioned error while trying to enable the module. However, after applying the merge request, the error no longer appears. Therefore, I'm moving it to RTBC.
Thanks

🐛 | Error prepend string | Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: Class "Drupal\error_prepend_string\EventSubscriber\ErrorPrependStringEventSubscriber" used for service ".......

🐛 | Error prepend string | Symfony\Component\DependencyInjection\Exception\InvalidArgumentException: Class "Drupal\error_prepend_string\EventSubscriber\ErrorPrependStringEventSubscriber" used for service ".......

dhruv.mittal → changed the visibility of the branch 3519666- to hidden.

📌 | Verify Email | Use hash_equals() function for check of secret

sorry for the delay, Now I've raised the MR with the proposed solution please review.

🐛 | List field predefined options | Deprecated hook in Drupal 11

moving it to the right status.

📌 | Verify Email | Use hash_equals() function for check of secret

🐛 | Civic Cookie Control | 4.5.X typo on 'Reject Text Color'

This issue is persist in 4.5.5 but resolved in 4.5.x as 4.5.5 is not a branch it is a tag so I think I won't be able to create a MR that is targeting 4.5.5 let me know if I'm wrong

🐛 | Civic Cookie Control | 4.5.X typo on 'Reject Text Color'

🐛 | Conditional Fields | [] operator not supported for strings in ConditionalFieldsFormHelper

As patch is deprecated and it is easier to review MR, for that reason I've raised MR from the given patch.
Thanks!

🐛 | Modal | Misspelling in modal-page.js file

Thank you for your kind feedback.
In case you are referring to the location where this class is defined, it can be found in the modal-page-modal.html.twig file, specifically at line number 30.

🐛 | Experience Builder | Img prop constraints require extension to be lower case

It makes sense. I agree that rejecting caps-in-extensions via AJV could lead to a confusing and inconsistent UX, especially since Drupal Core accepts them and users can upload/select those media items without issue.

Normalizing file extensions to lowercase on the client side before sending the PATCH request seems like a practical middle ground. It avoids breaking the backend while keeping things smooth for the user. Since the casing of file extensions doesn’t affect how they’re served or interpreted, this should be safe and non-invasive.

To make it more robust, we could also log a warning or surface a note during validation when a case normalization occurs—just to help with debugging or future maintenance if needed.

Longer term, if XB aims to strictly align with Drupal’s media handling, it might be worth revisiting how validation is handled here to better reflect the broader system behavior.

Open to feedback if anyone sees a downside to that approach!

🐛 | Conditional Fields | [] operator not supported for strings in ConditionalFieldsFormHelper

🐛 | Recurring Events | Fatal error when registering for event without entering email

Please review

🐛 | Modal | Misspelling in modal-page.js file

🐛 | Auctions | auctions_core_tools() service wrong return type and description

please review

🐛 | Experience Builder | Img prop constraints require extension to be lower case

Merge conflicts need to be resolved. so moving back to needs work.

🐛 | Auctions | auctions_core_tools() service wrong return type and description

🐛 | Username | Route "username.admin_form" does not exist.

I'm still not able to reproduce this issue so postponing this issue until someone else finds the same error.
Thanks!!

🐛 | Group | 'db.group_config_wrapper' doesn't exist

🐛 | Experience Builder | Img prop constraints require extension to be lower case