Account created on 27 September 2024, 10 months ago
#

Merge Requests

More

Recent comments

Changes looks good to me, So moving it to RTBC

I mistakenly rerolled onto 6.0.x branch so for the same I've created new clean branch
Apologies

dhruv.mittal changed the visibility of the branch 3284318-valueerror-xmlreaderopen-argument to hidden.

Created MR as MR is easy to review and patch is deprecated and corrected the issue status.

Changes look good to me so moving it to RTBC

I've rerolled and created MR for easy review
Please review
Thanks

I've checked that issue persist and MR is resolving the issue so moving it to RTBC

I can confirm that NodeForm namespace has changed and moving it to the right state with creating the MR of it and providing
reference link of the changes
https://www.drupal.org/node/3517871

Updated to the latest and code and removed the merge error.
Kindly review.


I followed your instruction to reproduce the error but I didn't get any error while enabling the module using drush.
Please let me know if I'm missing something.
Thank you !!

@divyansh.gupta please review I have removed .gitlab-ci.yml file. Now all the changes are only related to this issue.

I tested The MR.
It is working fine and removing error thus moving it to RTBC.

Mentioned issue is present in the theme. After applying the MR issue is getting resolved.
Attaching the screenshot FYR.
Before

After

So Moving it to RTBC.

I'm not able to see any deprecated Trait related warning.
Would you check it once again or please provide screenshots for the same.
Thanks.

As patch has been deprecated and MR is easier to review so I raised MR.
Please Review

MR !102 has Merge conflicts and those need to resolved. So moving it back to Needs work for the same reason.

I agree that Nullable types must be explicit.
And changes looks fine so marking it to RTBC

I have successfully reproduced the issue.
And after applying the MR the issue is gone.
so Moving it to RTBC.

Hey impol!
This issue is fixed in the newer version of the conditional_fields and it no more persists.
Thank you !

Production build 0.71.5 2024