I've tried to reproduce this issue usnig given steps to reproduce but could not able to do it.
I think this issue is fixed in the latest release of trash module. So we should close this ticket.
PHPunit tests are failing so moving this issue to Needs Work
Refactored form button text logic for comment forms. Replaced form_isSave check with $entity_id[0] == 'comment' to handle comments separately. Removed the _edit_form naming for comment forms, treating them consistently as "save" forms. Verified that custom button text is now applied correctly for comment forms. so moving it to RTBC
For me it's is working fine. and looking backward compatible. so moving it to the RTBC
I don't this issue is related to this module.
Let me know if I'm wrong.
As patch is deprecated so Converted patch into MR.
As MR is given so Moving it to NR.
This issue is already resolved and composer.json already has "drupal/commerce": "^2.29 || ^3".
Thanks.
dhruv.mittal → created an issue.
Sorry @renatog for removing the AJAX URL by mistake.
I have added that back and working fine for me please review.
I've raised the MR for the same please review.
previously I added ' { } ' instead of ' [ ] ' . Kindly review now.
Kindly review
I was getting below error after login/register
Fatal error: Declaration of Drupal\flag_anon\FlagAnonLinkBuilder::build($entity_type_id, $entity_id, $flag_id) must be compatible with Drupal\flag\FlagLinkBuilder::build($entity_type_id, $entity_id, $flag_id, $view_mode = null) in /app/web/modules/contrib/flag_anon/src/FlagAnonLinkBuilder.php on line 73
I have raised MR for the same,and now it works.
Please review
Kindly review.
I have resolved merge conflicts and rebased it please have a look.
kindly review
I have created MR that is solving the issue.
Also I noticed that if once a registration form is generated a error then it's status will be in pending status and when I try to delete the event series related to registrant it produces same error.
And the given MR solves this too. Please review and let me know if any assistance requires.
Thank you.
I've also added display config in settings.php still not getting any error. can you please attach any screenshot of error for better understanding.
Thank you
I have raised MR that is solving the error that is occurring while opening the preview page in edit mode kindly review it.
Let me know if further assistance required.
Thanks
I've created MR for the given patch please review.
Hey @thaoquang,
I have tried to reproduce the error by following the steps that you provided with the same version that you have given.
But I couldn't able to do so.I'm attaching the screenshot for your reference. let me know if I'm missing something.
I've tried to rebase but couldn't able to do. I think the reason of it is ,the issue was created before the branch 3.0.x was released so I think we need to create a new ticket for the same. Let me know if i'm missing something.
I have tried to reproduce the error by following the steps given in the issue summary
but i could not able to reproduce. please let me know if i am missing something.
Thanks
I've also faced the issue and the solution is fixing the error. and created a MR from the given patch as MR is easy to review.
Thanks
dhruv.mittal → changed the visibility of the branch 3508999-parameter-as-nullable-is-deprecated to hidden.
dhruv.mittal → changed the visibility of the branch 3.0.x to active.
dhruv.mittal → changed the visibility of the branch 3.0.x to hidden.
Please review
I've removed flex property and left that empty, allowing default display behaviour. Kindly review
The issue related to missing alternative text for the Font Awesome icon used as an external link indicator has been addressed. Specifically, added an aria-label attribute to the icon element if one was not already present, which ensures better accessibility for screen readers.
.This resolves the accessibility error where screen readers were unable to interpret the icon due to the lack of an alternative text attribute.
So moving it to RTBC.
Since test cases are required, it is being moved back to 'Needs Work'.
Hey @sayan_k_dutta,
It seems that the recent changes you've made are causing failures of PHPStan and upgrade status. Could you please address these issues?
I have changed the file name please review now
I checked the module's repo, In WorkflowTransitionViewsData.php file the deprecated views_field_default_views_data is already removed for D11.2.0 and higher version.
Please let me know if I'm missing something.
Added the provided file in schema directory. please review and let me know for further assistance.
@pinesso as MR is merged and resolving all the threads, could you please move it to 'FIXED' state.
I have changed the title name as per your requirement please review
No I'm not able to see any comments from you.
Thanks for appreciation pinesso. but I'm not able to see your changes.
logic is implemented to ensure that email notifications are only triggered when both the 'Authenticated user' role is selected in the allowed roles configuration and the 'Trigger email if users have the 'Authenticated user' as their only role' checkbox is checked. checks are present to prevent notifications from being sent if the 'Authenticated user' role is unchecked, even if the checkbox was previously selected. Tested various scenarios to confirm expected behaviour.
So moving it to RTBC.
Please review
The issue occurs when $data['invalidations'] doesn't have an element at index 0, causing the token replacement to fail. By using reset($data['invalidations']) instead of $data['invalidations'][0], we ensure the first element (or default value if the array is empty) is accessed correctly. This change resolves the issue and improves the robustness of the functionality.
So changes looks good to me so moving it to RTBC.
I have changed the name. please let me know if you need further assistance.
Thanks @pinesso for quick response !
The setting form link is already visible in admin toolbar, with the other name.
Let me know if there is need to change the name.
Thanks
Now the menu link is visible on configuration page. and Could you kindly clarify what you mean by 'adding a menu item to the toolbar'? I would appreciate a more detailed explanation.
Merge conflicts needs to be resolved
Kindly review
Kindly review now
I have done the requested changes please have a look on it
Please review
I have tried to reproduce this issue using the steps that you have provided but not able to reproduce it.
Can you tell me what am i missing or you can share more info about it.?
@richardgaunt thanks for merging the MR, could you please change the issue status to "FIXED".
Please review