Thank you @lawxen for quick merge, but I think you forgot to assign credits.
Thank you :)
Hey @ccjjmartin
Thank you for you contribution
But In Raised MR pipeline is failing, but in targeted branch it's all green.
So for the same reason putting it back to needs work
Reviewing it
Able to see the "Is all of" button after applying the MR
So moving it to RTBC
Thanks
Reviewing it
But in the targeted branch PHPunit tests are passing but in your Merge Request Phpunit tests are failing.
Please review
unit tests are failing
So moving it back to the Needs work\
Thanks
Thank you for approving the merge request but I think you forgot to assign credit :)
Please review
Hey @alberto56
I've tried to reproduce the issue and I got to know that delete button is already disabled if you click on delete button then it will redirect to confirmation page where you can easily see, delete button is disabled.
Thanks
I can confirm this issue persists with provided steps to reproduce
and patch is able to resolve the issue.
Thanks for your contribution @johnatas
Moving it to RTBC
Apologies assigned mistakenly
so unassigned myself
Indeed the use of curly braces {} for array or object access, which has been deprecated in PHP 7.4 and removed entirely in PHP 8.0.
so for the same moving it to RTBC
Reviewing it
Now I can confirm this issue persists and able to resolve the issue using the patch
Thank you
Please review
Working on it
Changes looks good to me so moving it to RTBC
Hey @karavkars
I tried to reproduce the error following the steps to reproduce
But could not able to do so I'm attaching the Video for your reference please have a look and Let me know If I'm missing something
Thank You
reviewing it
I'm able to reproduce the error and after applying the MR error is resolved. screenshots are attached FYR
So moving to the RTBC.
Reviewing it
Instead of changing the blacklist to blocklist, We can just make a cspell file in which we can ignore blacklist, blacklisted, blacklists, whitelist word
Let me know if this solution sounds good then I'll proceed.
Changes look good to me as use of \Drupal::service() is not ideal way.
So Moving it to RTBC+.
Thank you
please review
Added a configuration Form and Modal width configurable.
Changes looks good to me, so moving it to RTBC
Created MR as Remaining task suggested and moving it to needs review
Changes looks good to me, So moving it to RTBC
Reviewing it
Changes looks fine to me.
so moving it to RTBC
Reviewing it
I mistakenly rerolled onto 6.0.x branch so for the same I've created new clean branch
Apologies
dhruv.mittal → changed the visibility of the branch 3284318-valueerror-xmlreaderopen-argument to hidden.
Reviewing it
Changes looks good to me so moving it to RTBC.
Created MR as MR is easy to review and patch is deprecated and corrected the issue status.
Changes look good to me so moving it to RTBC
Reviewing it
Corrected the state and created a MR for easy review
Thanks
Kindly review
I've rerolled and created MR for easy review
Please review
Thanks
Reviewing this
Please review
Please review