Field description for value_map does not match actual behavior

Created on 14 February 2025, 5 months ago

Problem/Motivation

The value_map field, labeled Value conversions, states that "If this is left empty, the values from the IdP will be interpreted as machine names for Drupal roles."

However, if it is left empty, role mapping is skipped, with the logged message: "value_map is not configured; skipping role mapping."

Steps to reproduce

Configure idp to have SAML attribute with Drupal roles
Enable role mapping and set SAML attribute but leave Value conversions empty.
Login with SAML
See that mapping does not work and the above error message logged

Proposed resolution

Either implement the described feature OR remove it from description

🐛 Bug report

Status

Active

Version

3.0

Component

Code

Created by

🇫🇮Finland Laurie Lim Helsinki

Live updates comments and jobs are added and updated live.

Merge Requests

!32Field description for value_map does not match actual behavior
Open
dhruv.mittal
updated 8 days ago

Comments & Activities

Issue created by @Laurie Lim
Comment about 2 months ago →
isakfredriksson
Made a small patch that, if the config for value_map turns out empty, it'll fall back to roles machine names as the field description suggests.
Comment 9 days ago →
dhruv.mittal
Merge request !32Issue #3506668: Field description for value_map does not match actual behavior → (Open) created by dhruv.mittal
Comment 8 days ago →
dhruv.mittal
As patch has been deprecated and MR is easier to review so I raised MR.
Please Review
Pipeline finished with Success
8 days ago
Total: 195s
#539134

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024