Add 'lang' attribute option

Working on it.

Thank you so much @sayan_k_dutta.

Made the code changes required to display a option to enter lang attribute in the link form. But drupal ckeditor5 seems to filter out the attribute, as it is not being rendered in the link form. Someone please review the code changes.

@sayan_k_dutta. Could you upload a patch so we can test it out and help debug. Thanks.

Here is the patch attached.

You had two "console.log" statements in js/ckeditor5_plugins/editorAdvancedLink/src/editoradvancedlinkediting.js that were throwing console errors for me. I removed them in my testing and rebuilt editorAdvancedLink.js.

After I enabled the Language attribute in the text editor settings things are working. See the screenshot "ckeditor-settings-enable-language.png" for reference.

I'm seeing the Language option in the Advanced dropdown. See the screenshot "lang-attribute-in-advanced.png" for reference.

The lang attribute is showing up in the link markup. See the screenshot "lang-attribute-markup.png".

I think all you have to do is remove those two console.log lines and rebuild the JS.

Thanks @jdewit, overlooked it. Made the changes.

Hey @sayan_k_dutta,

It seems that the recent changes you've made are causing failures of PHPStan and upgrade status. Could you please address these issues?

keshav patel → made their first commit to this issue’s fork.

Fixed some Drupal coding standard issues, but I think there are 4 such issue which we've to live with or we can suppress them:

FILE: src/Plugin/CKEditor4To5Upgrade/AdvancedLink.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------
 30 | ERROR | Public method name "AdvancedLink::mapCKEditor4ToolbarButtonToCKEditor5ToolbarItem" is not in lowerCamel format
 37 | ERROR | Public method name "AdvancedLink::mapCKEditor4SettingsToCKEditor5Configuration" is not in lowerCamel format
 44 | ERROR | Public method name "AdvancedLink::computeCKEditor5PluginSubsetConfiguration" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------------
Reason: Core too uses naming in the same format. (@see Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginInterface)

FILE: /tests/src/Kernel/CKEditor4To5Upgrade/UpgradePathCompletenessTest.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 15 | ERROR | Class name doesn't match filename; expected "class UpgradePathCompletenessTest"
------------------------------------------------------------------------------------------------------------
Reason: Class exists with the same name (@see line:42), but there are multiple classes on the same file.