🇮🇳India @sayan_k_dutta

Reviewed the MR. The changes seem to resolve the issue. All the custom blocks created are now visible under blocks options in gutenberg editor. Attaching screenshots for the same and moving this to RTBC.

Applied the MR and it seems to resolve the issue. Attaching screencasts for reference and moving it to RTBC.

Cloned the repo and reviewed the MR. It seems that the MR solves the issue of PHP Fatal Error perfectly which was occuring during enabling the module. Attaching screencasts for reference and moving this to RTBC.

Cloned the repo and checked the MR. Before applying the MR, when checking for upgrade status, under deprecated api use, the error "Twig Filter "spaceless" is deprecated" was listed. Applied the MR and it seems to fix the issue as no "spaceless" decrecation error is listed now for the upgrade status of Seven theme.
The MR looks good to me and moving this to RTBC.

Installed the Provus distribution with Drupal 10.3.6. Checked the MR and verified that the title and body of the accordian sections are made required. Attaching a screencast for reference. Moving this to RTBC.

Reviewed the MR in Drupal Core 10.4.5. Steps followed for testing the MR.

1. Cloned the repo and checked out the branch 3361765-footer-menus-overlapping.
2. Installed the Kite theme from Appearance section.
3. Under Structure>Menus created 4 menus named Footer 1, Footer 2, Footer 3, Footer 4 in addition to the default footer menu present.
4. Added links under all the five menus.
5. Placed the menus under Footer Top, Footer First, Footer Second, Footer Third, Footer Fourth, with each menu in each footer.
6. Observed the changes in the footer region after creating any node page.

The changes looks good to me. Moving this to RTBC. Attaching screenshot for reference:

Added the change record https://www.drupal.org/node/3515272 →

@mrdalesmith, works perfectly and passing all tests. You can move it to RTBC.

The patch in #11 solves the problem. Both underscores and hyphens are now applied to menu machine names. By default, as a replacement underscores are applied, inline with the naming convention of other machine names. Created MR !11592 for the same.
The screenshots are attached below after testing on my local:

Need others to review.

Made the changes. Removed the 'fieldgroup' from #type and added it as a class attribute.

Working on it

Working on it.

Made the changes. Please review MR !218

Working further to convert the views_hooks in oop implementation.

sayan_k_dutta → changed the visibility of the branch 3489482-switch-to-oop to active.

sayan_k_dutta → changed the visibility of the branch 3489482-switch-to-oop to hidden.

Working on it.

Please review the changes. Then we can add the new parameter if all the hooks have been changed.

Working on the further changes.

Installed drupal on the branch drupal-3502094/'3502094-when-saving-the with the minimal profile.
Navigated to 'Role Settings' options and after confirming that the admin role was not created by default, created a new role named Administrator. The added the role in the Role Settings- confirmed that the status message 'The role settings have been updated.' is shown when clicked on Save Configuration button.
Attaching a screencast for the same and moving it to RTBC.

Added the tests. Please review.

Working on it.

Working on it.

Added the hook classes for the main modules. Adding for submodules as well.

Working on it.

Tested the MR. The key integration with the Graph mail module seems to work fine.
Created a key of type Graph Mail and configured the graph api mail settings to work to with the key created. Used dummy values for testing. All the comments on the MR also seems to be addressed. Attaching a video for reference and moving it to RTBC.

Tested the MR and configured the conditional fields with select2 widget. The select2 field widget is now working fine showing only the field whose dependency is added related to the value in list field. Attaching screencasts for the same and moving it to RTBC.

I checked the change password page. It is not accessible and the page throws error if the password policy module is enabled.
The MR fixes this and the page is accessible now. Moving this to RTBC.

Used drush en fullcalendar to install the module on the branch 3497050-warning-message-on. The warning message Route "admin/config/user-interface/fullcalendar" does not exist. does not appear anymore.
There is a phpstan error on pipeline but it does not seem to be related to code changes made for this issue. Hence moving it to RTBC.

Created MR 20 in-cooperating changes from the 3.0.x branch. Please review this MR.

Phpunit tests are still failing for some reason. If anyone can look into it.

Checking using FieldableEntityInterface seems to filter out the entity types without any fields from the source entities list. Created the MR !116 according to it.
I have not tried using the EntityUsageTrackBase as I am not clear of the idea of how to use it to check for entities without fields.

Working on it.

I was able to delete the custom tokens without any error. Can you provide the steps to reproduce the issue.

Made the changes requested. Please review.

Made the changes. Please review.

Made the code changes according to it, following @dom 's suggestions and reopened the MR !9.
I have reviewd from my end and it is working fine. Need others to confirm the review.

@dom.
I applied your patch and used the views bulk edit module with simplify. Seems to resolve the errors previously occuring. Thanks for the help.
Attaching the screencasts.

The pipeline is still failing for missing return types in the following files

core/lib/Drupal/Component/Annotation/Reflection/MockFileFinder.php
core/lib/Drupal/Component/Diff/DiffFormatter.php
core/lib/Drupal/Core/Diff/DiffFormatter.php

It has also some spell check errors.
Moving it to needs work. The pipeline needs to be fixed. Help from someone will be welcome.

Working on it.

Working on it.

Made the required changes. Please review MR !704.

Working on it.

Made the requested change. Please review.

All tests are now passing, warnings are resolved. Please review.

I have made the code changes to remove the empty rows whenever an entity is saved in the database. Also the empty rows are removed from being rendered on the webpage.
Please review MR !33.

Tested the changes in the MR 8. The dropdown menu is visible after the code changes.. Attaching screencasts before and after applying the patch for reference and moving it to RTBC.

Tested the MR and applied the theme. The changes seem to be fine and all the menu levels are now visible. Attaching a screenshot for reference and moving it to RTBC.

Reviewed the MR. The issue seems to be resolved if the image_autorotate plugin is removed.
Attaching a screencast for the same and moving to RTBC.

Checked again, works fine for me @koustav_mondal. Please check the branch once and the specific drupal version for it.

Made the changes. Please review.
Also the pipeline was failing as the tests module was incompatible with D11. Made the fix for it. Pipeline is green now.

Working on it.

Made the change. Please review.

Working on it.

Working on it.

Reviewed the MR. Checked all the changes made.
1. Checked that on submitting more than one empty components for the name field, all the "_none" values are replaced by empty strings.
2. Checked that the validation does not trigger if we give "_blank" or "_none" as input.
3. Checked all the tests written and all of them passed.

Hence moving it to RTBC.

Thanks @jdewit, overlooked it. Made the changes.

Here is the patch attached.

Made the changes and added tests. Please review.

Made the requested changes. Please review.

Working on it.

Ok @dcam, unassigning myself.

Working on it.

@yas changes done.

Made the changes. Please review.

Made the code changes required to display a option to enter lang attribute in the link form. But drupal ckeditor5 seems to filter out the attribute, as it is not being rendered in the link form. Someone please review the code changes.

Made the changes requested.

Made the changes. Verified working fine.
Please review.

Working on it.

Working on it.

Made the required changes, please review.
@niharika.s please make the MR 59 as ready.

sayan_k_dutta → changed the visibility of the branch 3498303-php-8.4-compatibility to active.

I have made the changes by removing the depricated options, please review.

Assigned mistakenly. But I want to highlight a point that adding the content type column is causing the table cell for the content upload time to shrink and it is not looking good in appearance. Maybe we can do something to restore the widths of the column.

Working on it.

Working on it.

Made the changes as requested. Please review.

Working on it.

Working on it.

@zenimagine, I have created MR !24 with the changes. Please check if it works.

We then have to modify the .module file to make the necessary changes. I am looking into it.

@prem suthar, thanks for the follow up, then I think the module works as designed.

Some specific case arise:

1. User registers for a new account but is pending approval from admin.
2. User registers for a new account but has not yet validated their email.
3. User registers for a new account but both admin approval and email validation is pending.

In these cases the user is still not logged in. So just after creating the account, will they be redirected to the set page?
Need others' thoughts.

The issue arises when the new account created needs to be validated through email or by admin. Seems like the redirection checking is bypassed if the user is not logged in. I am using version 2.x-dev@dev on drupal 10.3.10.

Working on it.

Seems like RestrictIpAcessTest.php is not correctly executing the test for Blacklisted paths. I don't have much knowledge about unit tests. Hence unassigning myself. Anyone please look into it to move it forward.

@maintainers, enabling the deprecated attributes is causing the ckeditor to function incorrectly. If for end users of the module it is meant not to use or enable those attributes, can those be removed from the config form?

Working on it.

Again tried to reproduce the error in Drupal 10.4.0, there seems to be no issue for 2.x branch of the modulew. On first time Tfa setup with TOTP, in Tfa configuration page if the "Redirect users on login to TFA Setup Page" option is enabled, the user is correctly redirected to the tfa overview form asking the user to set up tfa.

Reviewed the changes. Looks good. Attaching screenshot of the same and moving to RTBC.

@igorgoncalves yes, indeed the two strings of urls are different, that is what we need here. Do I need to make changes to test files, to remove the warnings. I don't have much knowledge of phpunit tests, but can look into it.

Reviewed the changes. Looks Good. Attaching screenshot of the same and moving to RTBC.

Looking into it.