Empty tables are being saved to the db if a tablefield is empty

I have applied changes in the TablefieldItem code to prevent saving empty tables by adding validation. This ensures empty rows and columns are not saved, reducing unnecessary database growth. Let me know if any further changes are required.

Sorry for taking a while to get to this. :)

It still applies cleanly to dev.

Tablefields still keeps adding empty tables every time I save an entity with a tablefield field with this patch. This happens with existing entities, new entities, entities with empty tablefields or ones with data.

This does clean up the following phpstan error:

------ -------------------------------------------------------------------------- 
  Line   modules/contrib/tablefield/src/Plugin/Field/FieldType/TablefieldItem.php  
 ------ -------------------------------------------------------------------------- 
  164    Cannot unset offset 'tablefield' on array<mixed, mixed>.                  
 ------ --------------------------------------------------------------------------

As per: https://www.drupal.org/project/tablefield/issues/3385030#comment-15228612 💬 After upgrade to D10, empty tablefield output is displaying in paragraph on node Active I rolled back /src/Element/TableField.php from the commit before https://git.drupalcode.org/project/tablefield/-/commit/26d63be6aa25d34d1... and "empty" tables stopped being saved. The interface still spawns an empty table below one with content in it, but as there are no spacers inserted into it it doesn't get saved as content.

This is a pretty brute force approach (and I'm sure there's been updates to that file after this that need to pulled in) but I personally have no need to drag tables but would prefer them not being created every time an entity is saved.

It seems like it'd be simpler to just not save any tables/cells that only have the spacer in them, but there could also just be a patch that rips out the drag and drop stuff and keeps up to date with current changes to the file.

Any updates on this? I’m using 3.x-dev along with this patch (https://git.drupalcode.org/project/tablefield/-/merge_requests/15.patch). On the frontend, all empty tables are gone with these two new options in field formatter to hide empty cells/rows, which is great. However, on the backend, every time I save a node, a new empty table is created. Over time, this results in thousands of empty tables in the database. Any ideas?

Working on it.

I have made the code changes to remove the empty rows whenever an entity is saved in the database. Also the empty rows are removed from being rendered on the webpage.
Please review MR !33.

Tests are failing. Please rebase on 3.0.x.

Phpunit tests are still failing for some reason. If anyone can look into it.

I note that the merge request changes some things back to how they are in 8.x-2.x.