- Issue created by @hockey2112
- ๐ฎ๐ณIndia deborahblessy
Hi @hockey2112,
I have checked the table field. The default column and row is set to 5/5. There is an option to rebuild the row and column in node pages, which is working fine. If column and row is default and if we are filling only two rows, the other cells remains empty which still makes sense.
Could you please elaborate do you face any specific issues other than that?
- Status changed to Needs review
over 1 year ago 3:13pm 4 September 2023 - ๐บ๐ธUnited States hockey2112
I have not added any data to this table field on this node, yet the coding for the table is showing up in the coding on the front end. This is not how it was working on the Drupal 8 version of my website. On the Drupal 8 version, I did not fill in any of the default rows and the table is recognized as empty and therefore did not display any empty table code.
- ๐ฎ๐ณIndia deborahblessy
Hi hockey2112 ,
If all the cells are empty or the values are not added on node, it shouldn't render the empty table structure of table field. If any one cell have values then the table structure should be rendered.
Is the requirement is understood right?
- ๐บ๐ธUnited States hockey2112
None of the cells have any data at all, the table cells are completely empty.
I set up a simplytest.me: https://master-tiz0pi5v343oqabxfiiubxfqazaldfkj.tugboatqa.com/user/login
Username and password are both "admin".You can view a page with a tablefield here: https://master-tiz0pi5v343oqabxfiiubxfqazaldfkj.tugboatqa.com/node/1
I did not add any content to the table field, yet its structure is still appearing on the page. I used CSS to make the tablefield TD red background.
- ๐ฎ๐ณIndia deborahblessy
We can work on the solution to create a template on table field module as patch to check whether none of the cells is empty, the table structure should not be rendered. If the approach is getting approved, I can work on it.
- ๐บ๐ฆUkraine Lysenko Ukraine, Lutsk
The issue with empty cells arises because of this pull request: https://git.drupalcode.org/project/tablefield/-/commit/26d63be6aa25d34d1...
- ๐จ๐ฆCanada gwvoigt London, ON ๐จ๐ฆ
Says it's in "Needs review" but there are no patches or MR information
- Status changed to Needs work
over 1 year ago 3:38pm 26 September 2023 - Assigned to Lysenko
- last update
about 1 year ago 1 pass, 2 fail - @lysenko opened merge request.
- last update
about 1 year ago 2 pass - ๐ฉ๐ชGermany Denis Waรmann
When will there be a patch for this problem? In my case, it's just a tablefield within a node (not in paragraphs) that displays the cells without any content.
- ๐บ๐ฆUkraine Lysenko Ukraine, Lutsk
Denis Waรmann,
This problem is caused by the fact that empty cells are stored in the field value.This merge request adds settings to the field`s formatter that allows to hide empty row or columns, I didn't change the status of the task in "Needs review" because I haven't finished adding tests for the new functionality, but the functionality itself is already working
I would be grateful if you try to install this patch on your website and give me feedback
- ๐ณ๐ฟNew Zealand stewest Wellington
Hi. I applied the patch https://git.drupalcode.org/project/tablefield/-/merge_requests/15.patch but the empty tables are still showing.
- ๐บ๐ฆUkraine Lysenko Ukraine, Lutsk
Hello @stewest,
Did you enable setting "Don't display empty rows" in the field`s formatter? - Status changed to RTBC
11 months ago 7:55pm 15 February 2024 - ๐ณ๐ฟNew Zealand stewest Wellington
Hi @Lysenko, I'm so embarrassed, I totally missed that! That works. Thank you!
- Issue was unassigned.
- Status changed to Needs work
8 months ago 9:26am 25 April 2024 - ๐ง๐ชBelgium BramDriesen Belgium ๐ง๐ช
The title and issue summary should reflect what is being changed/added in the merge request. I think the description on the merge request is more or less in line with what should be updated here.
Once that's done it can be set back to RTBC.
- ๐ง๐ชBelgium davidiio
On multivalue tablefield a new empty table is added avery time the node is updated making the edit form longer and longer and databse full with empty data if the user don't manually delete the table from the form.
- ๐บ๐ธUnited States erutan
This still applies cleanly to dev, but ticking those fields and clearing caches do not hide existing tables with dummy "spacer" content.