Cape Town
Account created on 15 June 2009, over 14 years ago
  • Frontend Developer, Site Builder, Team Lead at Amazee LabsΒ 
#

Merge Requests

More

Recent comments

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Hi @Lysenko, I'm so embarrassed, I totally missed that! That works. Thank you!

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Released in alpha10

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

An idea could be to rather add the BG colour to the parent and wrap that in a div before the field items.

OR, as it looks like you're wanting different button colours, add the colour choice to the button/link paragraph rather.

Something like

{% set bgColor = content.bgcolour["#markup"] %}

<button class="{{bgColor}}">

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Dear Aman

The Sector Social Follow module is part of the Starter Kit in Sector 10 Distribution, so you would need to have Sector 10 installed first and then the "block_class" would be available. You'd also need to create a block.block.sector_followus (block_class, sector_theme) template in your own custom theme most likely based off of the Sector Theme.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ made their first commit to this issue’s fork.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Tested by team

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town
πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Looks good, and tested

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

This has been reviewed and fixed

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

This has been tested and then merged to the latest 10.0.x-dev

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Duplicate of https://www.drupal.org/project/sector/issues/3403536 β†’ as this module is shipped in the Sector Distribution

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Uninstall actually works fine.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

The latest updates, fixing the sub theme generation solves the issues mentioned above.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

node_modules ingnored in the route

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Could we ammend .gitignore with node_modules

I see `pnpm install` when run, puts node_modules in the root of the workspace, even if we run the install from the theme folder.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

This works well and has been tested on a dev project using this feature.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

So the basic premise that we wanted to add body classes with certain information to it, is already covered. By default we get classes:
"node-2 node-type--sector-page" as per https://git.drupalcode.org/project/sector_theme/-/blob/1.0.x/includes/ht...

Update: Steps reproduce Sub theme errors.

When I run:

php core/scripts/drupal generate-theme --starterkit sector_starterkit NewSubTheme --path themes/custom

I get:

Directory themes/custom/NewSubTheme could not be created - so this needs to be done manually

So I created the custom folder manually and then the php script works. Updating DOCS. (or we could add a .gitkeep file in the folder to make it remain even when empty?)

Then, I install the theme, from the UI as it didn't want to run from
`drush en SUBTHEME_NAME -y; drush config-set system.theme default SUBTHEME_NAME -y`

Then I got this WSOD:

Drupal\sdc\Exception\InvalidComponentException: [id] Does not match the regex pattern ^[a-z]([a-zA-Z0-9_-]*[a-zA-Z0-9])*:[a-z]([a-zA-Z0-9_-]*[a-zA-Z0-9])*$ in Drupal\sdc\Component\ComponentValidator->validateDefinition() (line 119 of core/modules/sdc/src/Component/ComponentValidator.php).

I then removed this theme and recreated a new theme, using a lower case name, and then I get no errors. So sub theme documentation perhaps should refer to: SUBTHEME_NAME in lower case?

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Duplicate of https://www.drupal.org/project/sector_theme/issues/3401428 πŸ“Œ Subtheme: Update documentation around subtheming RTBC

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Is there a a way to add a different distribution to the build, in DrupalPod? Like Sector https://www.drupal.org/project/sector β†’ ?

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Thanks @chris-s will take a look

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Rather use Paragraphs with their collapsibile features. Closing this

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Yes that is great, thanks @rodrigoaguilera

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

We've added CKEditor5 "styles" for:

  • Buttons (colours: primary, dark, light)
  • Link with svg arrow (colours: dark, light)
  • "Callout" with border colours for "primary", "alert" and "notice". This is much like a block quote.
  • Highlighted text background colour
πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Hi, I can confirm #66 β†’ too, all data lost on original node (when another translation is deleted)

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

We're parked this temporarily in favour of the built in CKEditor 5 Table Of Contents

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

I'd like to open this up again as I can reproduce the issue.

We're using Drupal 9.5.5 with the Sector Distribution.

When I add a field as a block, like the subtitle or banner image field (all with translations enabled) and using Content language (instead of interface language), when I add a translation, I expect to see the translated content on the page, but I see the original languages content.

The patch at https://www.drupal.org/project/fieldblock/issues/3173729#comment-13840638 πŸ› getTranslatedFieldFromEntity should use the content language Active works for me.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ made their first commit to this issue’s fork.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

We're noticing that the comments from Line 68 web/core/modules/toolbar/toolbar.module are showing when logged out.
https://www.drupal.org/project/drupal/issues/3355381#comment-15106592 πŸ› Investigate better ways to add anti-flicker JS Fixed

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

We're noticing that the comments from Line 68 web/core/modules/toolbar/toolbar.module are showing when logged out.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Seems to be a permission issue, but if one disables /jsonapi/pathauto_pattern/pathauto_pattern the issue goes away and Gatsby is able to connect. So perhaps it is not such an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ created an issue.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Next steps (new issue):

1. Disable Gin Login in Sector Tonic. This will become opt in.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

This patch looks good. Ready to merge.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ made their first commit to this issue’s fork.

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

Looks good thanks @loopy1492

πŸ‡ΏπŸ‡¦South Africa stewest Cape Town

stewest β†’ made their first commit to this issue’s fork.

Production build https://api.contrib.social 0.61.6-2-g546bc20