- Issue created by @stewest
- 🇬🇧United Kingdom marcelovani London
The Config Pull Request GitLab Support module has different dependencies
See instructions in https://git.drupalcode.org/project/config_pr/-/tree/8.x-1.x/modules/conf...Dependencies
- m4tthumphrey/php-gitlab-api:^11Installation
- Use composer to make sure you will have all dependencies:composer require m4tthumphrey/php-gitlab-api:^11
Please let me know if that works.
- 🇳🇿New Zealand stewest Wellington
Thanks!
One thing I see is that we have our own private gitlab instance on our own url, so this wouldn't work, I don't think with a custom url like https://gitlab.ourdomain.com as the field input help text assumes we're only entering a user name and repo name:
Repo user name
Example: In https://github.com/marcelovani/captcha_keypad the repo user name is `marcelovani`Repo name
Example: In https://github.com/marcelovani/captcha_keypad the repo name is `captcha_keypad` - 🇬🇧United Kingdom marcelovani London
@stewest I think to use self hosted Gitlab, it could be done by extending the Gitlab class, like it was done here https://git.drupalcode.org/project/config_pr/-/blob/8.x-1.x/src/RepoCont...
- 🇬🇧United Kingdom marcelovani London
I found the reason for the original issue reported, I am working on a fix and will update soon
-
marcelovani →
committed f7894eba on 8.x-1.x
Resolve #3472233 "Fix gitlab module"
-
marcelovani →
committed f7894eba on 8.x-1.x
- 🇬🇧United Kingdom marcelovani London
I am pushing a fix to the dev branch, I tested it but it would be nice to have someone else to try
- 🇳🇿New Zealand stewest Wellington
I no longer got the original error message. So that is good.
I installed it, but I don't have standard gitlab access so couldn't 100% test it to completion for gitlab (I have a self hosted gitlab url)
I got these log warnings, but this is because:
1: I hadn't added a repo_url:
Warning: Undefined array key "repo_url" in Drupal\config_pr\Form\ConfigPrSettingsForm->buildForm() (line 101 of /var/www/html/web/modules/contrib/config_pr/src/Form/ConfigPrSettingsForm.php)2. I hadn't added a personal access token to my user yet.
TypeError: Drupal\config_pr\RepoControllers\GithubController::getAuthToken(): Return value must be of type string, null returned in Drupal\config_pr\RepoControllers\GithubController->getAuthToken() (line 156 of /var/www/html/web/modules/contrib/config_pr/src/RepoControllerTrait.php).With Github, I was able to post a PR.
- 🇬🇧United Kingdom marcelovani London
Hi Steve, thanks for confirming.
I have done something that you may help me to test https://www.drupal.org/project/config_pr/issues/3507408 ✨ Support Self Managed Gitlab Active
For now, I merged to dev branch only.
Thanks
Marcelo