London
Account created on 7 July 2010, almost 14 years ago
  • Technical Architect at Acquia 
#

Merge Requests

More

Recent comments

🇬🇧United Kingdom marcelovani London

Thanks @andypost, since the current beta release is causing a fatal error, do you think we should cut a new beta tag?

🇬🇧United Kingdom marcelovani London

I see an issue for similar functionality https://www.drupal.org/project/xhprof/issues/2592489 Allow to toggel xhprof using a cookie. Needs review
We probably could extend this to work with either query string or storing the secret in cookies to profile every single page, but this could be dangerous, if someone forgets to remove the cookie.

🇬🇧United Kingdom marcelovani London

This issue is for similar functionality https://www.drupal.org/project/xhprof/issues/3454210 Feature request: Ability to profile any page on demand Needs review

🇬🇧United Kingdom marcelovani London

Removing a left over comment

🇬🇧United Kingdom marcelovani London

BTW, there is a similar issue that should be possible to be closed too https://www.drupal.org/project/xhprof/issues/1758944

🇬🇧United Kingdom marcelovani London

Only issue I had with Drupal 10.2.6 was https://www.drupal.org/project/xhprof/issues/3330615 🐛 XHProfRequestMatcher::matches() should be compatible with RequestMatcherInterface::matches() RTBC .

🇬🇧United Kingdom marcelovani London

Patch #24 works, please merge.

🇬🇧United Kingdom marcelovani London

@andypost This patch is required for the module to work on Drupal 10.2.6, please merge if you can.

🇬🇧United Kingdom marcelovani London

Hi Nelo

The paragraphs_inline_entity_form beta3 has been tested on a new project using Drupal 10 and drupal/inline_entity_form 3 RC.

Can you try

composer require 'drupal/paragraphs_inline_entity_form:^1.1@beta'

Or even try composer require drupal/inline_entity_form:^3@rc First?

Probably it is good idea to remove ^1.0 from https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/blob/8.x-1.x/composer.json?ref_type=heads#L24

Please let me know how it goes and I will reomove this, if necessary

Regards
Marcelo

🇬🇧United Kingdom marcelovani London

Added Commerce example.
It will connect to a live feed and render the products into a slider

🇬🇧United Kingdom marcelovani London

marcelovani created an issue.

🇬🇧United Kingdom marcelovani London

Added Decoupled menus example. Need to work on product feed example.

🇬🇧United Kingdom marcelovani London

marcelovani created an issue.

🇬🇧United Kingdom marcelovani London

PR looks good, pls confirm that everything still works as expected and we can merge.

🇬🇧United Kingdom marcelovani London

I did the upgrade to Drupal 10 + PHP 8 + upgraded the Composer packages.
Github API is working fine, Gitlab needs more work.
Please help to test, if you can.
Thanks.

🇬🇧United Kingdom marcelovani London

Thanks for reporting, I updated the Composer requirements, please review.

🇬🇧United Kingdom marcelovani London

marcelovani changed the visibility of the branch 3406520-broken-dependency-on to hidden.

🇬🇧United Kingdom marcelovani London

marcelovani changed the visibility of the branch 8.x-1.x to hidden.

🇬🇧United Kingdom marcelovani London

marcelovani made their first commit to this issue’s fork.

🇬🇧United Kingdom marcelovani London

I have sent a message to Alan Sherry (current maintainer) to offer help and added link to this issue.

🇬🇧United Kingdom marcelovani London

marcelovani created an issue.

🇬🇧United Kingdom marcelovani London

+1 for a new release for Drupal 10.
Also, can we have a dev release available? It would make it easier to require the dev branch with Composer.

🇬🇧United Kingdom marcelovani London

I got stuck for 30min because of the same issue, glad I found your answer

🇬🇧United Kingdom marcelovani London

Uploaded a video on Youtube

Drupal 10 Demo Video

🇬🇧United Kingdom marcelovani London

Merged initial pull request to fix the Example module.
Still need to work on Functional Javascript tests.

🇬🇧United Kingdom marcelovani London

Thanks for checking @lexfunk and everyone that commented and tested this. I have just merged the PR https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/merge...
I will make a new release shortly.

🇬🇧United Kingdom marcelovani London

@Wim, in my case, the error was happening when creating new content. The entire toolbar was missing because of the js error.

🇬🇧United Kingdom marcelovani London

@ankithashetty, what is the current behaviour when change_pwd_page module is not enabled, but we have password_policy + social_auth only?

🇬🇧United Kingdom marcelovani London

Looks like the dependencies have been fixed, I will try to allocate some time to check this.

🇬🇧United Kingdom marcelovani London

That is correct, I may have typed it incorrectly by mistake on #13.
Fore reference https://git.drupalcode.org/project/fast_404/-/blob/8.x-2.x/README.txt

🇬🇧United Kingdom marcelovani London

This project is very simple, it basically provides a custom Entity embed form that works as a glue to embed Paragraphs.

It depends on https://www.drupal.org/project/entity_embed/issues/3272732 Drupal 10 & CKEditor 5 readiness Fixed , that depends on https://www.drupal.org/project/embed/issues/3309747 📌 Add CKEditor 5 compatibility and keep supporting CKEditor 4 RTBC

Looks like these two issues are getting close to be resolved, but we are not there yet.

🇬🇧United Kingdom marcelovani London

@catch I think you uploaded the wrong file

🇬🇧United Kingdom marcelovani London
+++ b/core/modules/big_pipe/tests/modules/big_pipe_test/src/BigPipePlaceholderTestCases.php
@@ -188,7 +189,63 @@ public static function cases(ContainerInterface $container = NULL, AccountInterf
+    $piggy->bigPipeNoJsPlaceholder = '<span data-big-pipe-nojs-placeholder-id="divpiggydiv</span>';

Looks like the span is missing the closing bracket. Is this intentional?

🇬🇧United Kingdom marcelovani London

If you go to https://git.drupalcode.org/project/paragraphs_inline_entity_form/-/merge... you will see the messages

Try to resolve on Gitlab itself by clicking the link on the message

🇬🇧United Kingdom marcelovani London

It looks like some extra work is required because of Ckeditor5 https://www.drupal.org/node/3308362

🇬🇧United Kingdom marcelovani London

@shivam_tiwari Thanks for the work on this, it will require some testing to validate the approach. Meanwhile, can you please rebase and update the pull request?

🇬🇧United Kingdom marcelovani London

Thanks for the patch, I missed this before because nobody marked as Tested & Reviewed by the Community.

🇬🇧United Kingdom marcelovani London

@miiimooo The implementation suggested would jeopardise the purpose of this module that allows the user to select the Embed type when they click on the Embed icon i.e.

The entity browser will open

To achieve what you are proposing, I suggest that you create new Entity Browser in /admin/config/content/entity_browser and configure the Widget for each Embed type

🇬🇧United Kingdom marcelovani London

Fixed in https://www.drupal.org/project/paragraphs_inline_entity_form/issues/3348890 Drupal 10 and CKEditor5 compatibility Needs work

🇬🇧United Kingdom marcelovani London

Thanks for the patches, but we are blocked by #3272732 https://www.drupal.org/project/entity_embed/issues/3272732 Drupal 10 & CKEditor 5 readiness Fixed

Production build 0.69.0 2024