🇬🇧United Kingdom @marcelovani

The permissions that I normally use are Api, Read/Write Repo.

Thanks for your help Stew.

Humm, I am not sure what is happening on your local setup.

Things that I would look:
1 - Make sure you pulled the latest dev code https://www.drupal.org/project/config_pr/releases/8.x-1.x-dev →
2 - Make sure you require the dependencies https://git.drupalcode.org/project/config_pr/-/blob/8.x-1.x/modules/conf...
3 - Clear caches

Also, you can try to uninstall and reinstall the module

The tokens are created on your repository, you need to check with them if there is any limit.

The Config Pull Request only needs one token per user and you can use the same token for many users if you want.

Hi Stew

I did some refactoring and also worked on automated tests, which is something that I wanted to do for a long time, the tests are all passing now https://git.drupalcode.org/project/config_pr/-/jobs/4416444

I believe that this ticket will pass manual testing now.

Kind Regards,
Marcelo

Had some issues merging the PR, I opened a new PR and it worked.
Thanks.

marcelovani → made their first commit to this issue’s fork.

Did some refactoring, moved some of the functionality to sub-module.
Needs testing

marcelovani → created an issue.

Hi Steve, thanks for confirming.

I have done something that you may help me to test https://www.drupal.org/project/config_pr/issues/3507408 ✨ Support Self Managed Gitlab Active

For now, I merged to dev branch only.

Thanks
Marcelo

marcelovani → created an issue.

Thanks for the explanation.

But on your use case, you are saying that people that log in as admin should not see the field. This is not a common pattern and people that log in as admin need to know what they are doing and will see a lot of configurations that may not make sense to non technical users.

I agree that the field should not be visible to users that do not have the permission to create pull requests. This makes sense and I committed the code for that.

If you want to hide the field from admin users, I recommend that you implement the same hook on a custom module.

function my_module_form_user_form_alter(&$form, FormStateInterface $form_state, $form_id) {
  $field_name = 'field_config_pr_auth_token';
  if (isset($form[$field_name])) {
    $form[$field_name]['#access'] = FALSE;
  }
}

marcelovani → made their first commit to this issue’s fork.

@eiriksm, now that I am reading this again, I have a different comment.

The access token is configured on the user's profile.
This tokens are not supposed to be shared between users, each user should generate their own access token on their repositories and save on their own user accounts.

The token can be scoped to specific repos and you can limit the permissions to allow only reading the repo and creating pull requests. There is no big danger.

What are your concerns?

I am pushing a fix to the dev branch, I tested it but it would be nice to have someone else to try

marcelovani → created an issue.

marcelovani → created an issue.

I found the reason for the original issue reported, I am working on a fix and will update soon

marcelovani → made their first commit to this issue’s fork.

Hi @nelo_drup

Thanks for reporting.

In order for me to debug this I need some information.

1 - Can you please provide detailed steps to reproduce?
2 - Are you using other modules that could be conflicting and causing this error?
3 - Can you try it on a fresh Drupal installation?

Done

marcelovani → created an issue.

Thanks for everyone that was involved, sorry for the delay. I merged the PR and will work on the Drupal 11 support https://www.drupal.org/project/config_token/issues/3505745 💬 Drupal 11 version Active

Hi Lee

I am not clear on what is happening.

Captcha Keypad is working for me as standalone and also with Captcha module.

I will create a release and see if there is any issues that will be affecting anyone else.

Thanks for helping to test this.

Marcelo

Thanks Lee

Lets wait until you find which module is causing the issue. I can install the same module on my side and see if there is anything we can do at Captcha Keypad.

Thanks
Marcelo

@Iee56 I tested it locally, with the steps you mentioned, but I did not get any issues.
Perhaps it is another module that is enabled and causing this, can you please check the list of enabled modules using drush pml command?

I have pushed more changes to the dev branch, please pull the latest changes first.

The automated tests are passing https://git.drupalcode.org/project/captcha_keypad/-/pipelines/414110

I pushed the fixes for Drupal 11.
If you could test the Dev branch and let me know if works, I will make a new release.
Thanks

marcelovani → made their first commit to this issue’s fork.

This is a very good idea, I will put in my list of todos.
If you want to contribute, feel free to send a PR and I will review.

Pushed latest changes and merged PR

Hi Maxilein, I believe this issue is not related to this project.

Can you please review and add more details to explain the problem?

Reopening to work on bugs

Fixed, thanks.

marcelovani → made their first commit to this issue’s fork.

marcelovani → made their first commit to this issue’s fork.

Merged

I commented in the PR. Feel free to do phpcs fixes

There are lots of changes in the MR, please review.

I fixed this on another ticket and gave you credit https://www.drupal.org/project/sharerich/issues/3289584#comment-15898445 📌 Automated Drupal 10 compatibility fixes Needs review
Can you please help to check latest tag 2.0.3 https://www.drupal.org/project/sharerich →

I pushed some fixes, need some help with testing

marcelovani → made their first commit to this issue’s fork.

marcelovani → made their first commit to this issue’s fork.

It has been merged, but needs to be tested and confirm that everything works before making a release

Thanks for reporting, can you please add screenshots with steps to reproduce?

vincenzo gambino → credited marcelovani → .

Thanks Ankit

Thanks, PR merged.

Merged, Thanks for fixing this.

I was wondering if it would be possible reinstate the original \Drupal\Component\Serialization\Yaml class, create a new service to decorate the current class. Basically, swap it.

See core.services.yml

serialization.yaml:
    class: Drupal\Component\Serialization\Yaml

The yaml_parser_class setting is deprecated and there is no replacement. It can be removed safely from your settings.php

See https://www.drupal.org/node/3415489 →

PR for schema update on SchemaStore https://github.com/SchemaStore/schemastore/pull/4187

marcelovani → created an issue.

There are people still using Drupal 7, the patch works, can someone merge this?

rajeevk → credited marcelovani → .