D11.2: update.theme_update and update.module_update no more exist

Patch attached for testing purposes

MR committed

Thanks!

Here's the core change record: https://www.drupal.org/node/3511861 →

I am setting the status back to NW. See my comments on the MR.

@benjifisher: perfect thought but why checking for Drupal version? isn't verifying the route existence enough?

why checking for Drupal version?

Just for consistency. If I were writing it from the start, I would only check for whether the route exists.

Drupal 11.2:
The patch helped me.

More elegant patch that should also work when the routes exist?

@uberhacker: MR162 has already been upatded in this way for backward compatibility.

When using a patch with MR, get it from here: (see attached capture).

Hey,

Patch #13 tested successfully on Drupal 11.2.2 with Admin Toolbar 3.6.1.

Thanks,

This is a serious issue that blocks database updates, after upgrading from Drupal 11.2.1 to 11.2.2

The patch #3 solved both problems : I was able to update the database, and I can edit my Admin Menu. Thanks!

Hi @mediameriquat,

I believe the issue you're describing is the one that was reported in the thread of MR !162.
Patch #13 includes a conditional that should address it.

On my side, I created a patch based on MR !162 that works as expected — I'm attaching it to this comment.

Thanks a lot everyone for reporting this issue and all the great help working on the code changes and tests.

Sorry for the late reply... But it's been a rough couple of weeks work-wise 😅

The changes from the merge request seem very reasonable and accurate to fix this bug.

I have just added a commit to refactor a bit the calls to version compare.
I have tested the changes locally on a D11.2 and a D10.5 sites and they seemed to work as expected 👌

I would greatly appreciate if you could please help testing and reviewing the merge request.

We don't currently have tests for this part of the module, so once we're good with these changes, we should be able to get them merged 👍

Any comments, reviews or testing feedback would be greatly appreciated.
Thanks in advance !

Not sure why though .... But I'm not seeing the update.module_install and update.theme_install links on D10.5...

I wanted to check whether my last refactoring commit changed the display order of the menu items, but I was unable to find the links Install new module or Install new theme added by the admin_toolbar module....

Would anyone have any feedback on that ?

Otherwise, I'll take a bit more time later to look into this.

Thanks in advance!

OK, so I've checked these with a colleague and it would seem the install routes were dropped in D10.4 according to the change record The feature to install a new extension from a URL via the Drupal UI has been removed → .

I understand better now, why I could not find the routes when testing with D10.4, D10.5 and D11.

So we should also probably update this compared version in the merge request as well.

I'll do a bit more tests to see if my latest commit changed the order of display of the links.

OK, I've tested this with D10.3.14 and the routes seem to be displaying in the same order before and after patch ✅
See screenshot below:

Upgraded to 10.4.8 and the install routes disappeared ✅

I didn't get any crash on the Edit admin menu page, since the existence of the routes is checked as well.

Therefore, I added an additional commit to update the version comparison for the install routes for 10.4, corresponding to change record The feature to install a new extension from a URL via the Drupal UI has been removed → .

I've tested the changes locally myself with D10.3, D10.4, D11.2.2 and they seemed to work as expected 👌

At this point, the merge request should be pretty much ready to get merged, but let's get some more testing feedback and reviews, if possible, before effectively merging it.
Thanks in advance!

Hi @dydave,
The latest version of the MR works as expected on my D11.2.2 project ❤️
Thanks for the work!

Thanks a lot Sylvain (@johnatas) for the prompt and positive feedback, it's greatly appreciated! 🙏

Following your confirmation, I did a few more manual tests locally and since all the jobs and automated tests for the merge request were passing 🟢 , I went ahead and merged the changes above at #25 🐛 D11.2: update.theme_update and update.module_update no more exist Active 🥳
Great job everyone! 👍

As a follow-up to this issue, I created feature request ✨ Provide extra links for the Automatic Updates module Active as an attempt to provide an "equivalent" to these extra links, which should most likely be supported by the Automatic Updates → contrib module from now on.

At this point, since I don't see anything else outstanding, this issue could probably be considered as Fixed for now.

Feel free to let us know if we missed anything or if you would encounter any issues with any of the latest code changes, we would surely be glad to hear your feedback.
Thanks again everyone for the great work and help on this issue! 🙂

dydave → credited tyb → .

Crediting my colleague @tYb for his help fixing the version compare for the install routes.