Make it possible to hide the token field by default

This is a very good idea, I will put in my list of todos.
If you want to contribute, feel free to send a PR and I will review.

@eiriksm, now that I am reading this again, I have a different comment.

The access token is configured on the user's profile.
This tokens are not supposed to be shared between users, each user should generate their own access token on their repositories and save on their own user accounts.

The token can be scoped to specific repos and you can limit the permissions to allow only reading the repo and creating pull requests. There is no big danger.

What are your concerns?

Oh my concerns are more towards usability and confusion.

If I have a colleague, for whom it will be faster to click a couple buttons on stage or prod and then get a PR out of it. Great. They can add a token to their user

The administrator of my client website however. They will see the words access token and think this looks like an error or is noisy. They don't have a GitHub user. Heck, they don't know what GitHub is

So it's rather easy for me to fix this in custom code, but I wanted to hear if this was a scenario the actual contrib project wanted to cater for directly 🤓

Thanks for the explanation.

But on your use case, you are saying that people that log in as admin should not see the field. This is not a common pattern and people that log in as admin need to know what they are doing and will see a lot of configurations that may not make sense to non technical users.

I agree that the field should not be visible to users that do not have the permission to create pull requests. This makes sense and I committed the code for that.

If you want to hide the field from admin users, I recommend that you implement the same hook on a custom module.

function my_module_form_user_form_alter(&$form, FormStateInterface $form_state, $form_id) {
  $field_name = 'field_config_pr_auth_token';
  if (isset($form[$field_name])) {
    $form[$field_name]['#access'] = FALSE;
  }
}

What you committed is more or less exactly what I have been implementing only in custom code. So this is actually perfect!

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.