- Issue created by @Laura Johnson
- Status changed to Needs review
6 months ago 1:44pm 28 March 2024 - πΊπΈUnited States codechefmarc
I was just trying out this patch and noticed that if there isn't a value passed to the
urldecode
function on line 220, it will give an error message about a required parameter. I suggest adding the following:
$value['uri'] = $uri ? urldecode($uri) : '';
or$value['uri'] = $uri ? urldecode($uri) : NULL;
- I haven't dug too deep into if the$value['uri]
needs to be an empty string or a NULL. - π¨π¦Canada TheDuke13
Here's a patch with the fix mentioned, encountered this issue with a site where we got a deprecation warning that passing NULL as parameter #1 to urldecode() triggers a deprecated warning, so checking to ensure it's not empty would be important.