πŸ‡ΊπŸ‡ΈUnited States @jeffam

Account created on 25 November 2008, over 15 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States jeffam

I cherry picked the commit from the merge request.

πŸ‡ΊπŸ‡ΈUnited States jeffam

I added the 3309324-single-day branch to create a patch against the dev version of this module.

Here's the URL for the patch from the one commit on that branch:

https://git.drupalcode.org/issue/date_range_formatter-3309324/-/commit/4...

This patch only works against the the 9.0.x dev version.

πŸ‡ΊπŸ‡ΈUnited States jeffam

jeffam β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jeffam

jeffam β†’ changed the visibility of the branch 2901412-pass-current-route-d10.1 to active.

πŸ‡ΊπŸ‡ΈUnited States jeffam

I ran across this error while working on some malformed custom queueworker plugins that worked in Drupal 9 but not in Drupal 10.

But perhaps the larger issue is that the warning wasn't logged by Drupal. Without any logs, we didn't know about the issue for some time.

Here's a small patch that logs an error when line 264 in Cron.php fails and sets $lease_time to null.

This can happen if $worker->getPluginDefinition() fails (as it did in my case) or if the 'time' key is missing from the plugin definition.

πŸ‡ΊπŸ‡ΈUnited States jeffam
πŸ‡ΊπŸ‡ΈUnited States jeffam

Merged into 3.x

πŸ‡ΊπŸ‡ΈUnited States jeffam

Thanks for catching that Twig spaceless tag!

πŸ‡ΊπŸ‡ΈUnited States jeffam

Closing since we'll only be supporting version 3.x for Drupal 10.

πŸ‡ΊπŸ‡ΈUnited States jeffam

jeffam β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jeffam

Applied the patch from the bot.

πŸ‡ΊπŸ‡ΈUnited States jeffam

Created branch 2979223-search-string-summary from 3.0.x and re-rolled the patch from https://www.drupal.org/project/facets/issues/2979223#comment-15146318 ✨ Add option to show current search string in facet summary Needs work

I'm not sure that I should change the version of this issue to 3.0.x-dev, though, so I'll leave that for others to decide.

πŸ‡ΊπŸ‡ΈUnited States jeffam

jeffam β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jeffam

Thanks for the offer and the reminder to update the module. I just released a version compatible with D10. Sorry for the long delay.

πŸ‡ΊπŸ‡ΈUnited States jeffam

The Summary Options module provides the following settings:

  • Show summary
  • Summary help text
  • Summary Placeholder

I guess the single setting provided by this module, to limit the length of the summary, is different enough to warrant a separate module.

πŸ‡ΊπŸ‡ΈUnited States jeffam

There's a patch in πŸ› Passing empty value to t() when same day + time for start and end date RTBC that prevents the error, but doesn't quite fix the formatting issue.

Production build 0.69.0 2024