🇺🇸United States @jeffam

jeffam → changed the visibility of the branch 3493921-sanitize-migrated-filenames to active.

jeffam → changed the visibility of the branch 3493921-sanitize-migrated-filenames to hidden.

jeffam → created an issue.

I ran into similar problems when users would paste URLs with spaces in them to PDFs in the file system.

With the core link widget, when pasted, a link like http://www.example.com/sites/default/files/file name.pdf would be stored as http://www.example.com/sites/default/files/file%20name.pdf. When viewed, such a link would work fine.

With the linkit widget, that same link would be stored as base:/sites/default/files/file%20name.pdf. When viewing, the links would be double-encoded, e.g. http://www.example.com/sites/default/files/file%2520name.pdf.

From that I assume that the base: and internal: link schemes must expect non-urlencoded paths.

Here's a patch that applies to 6.1.x and targets only the base: and internal: links.

I cherry picked the commit from the merge request.

jeffam → created an issue.

I added the 3309324-single-day branch to create a patch against the dev version of this module.

Here's the URL for the patch from the one commit on that branch:

https://git.drupalcode.org/issue/date_range_formatter-3309324/-/commit/4...

This patch only works against the the 9.0.x dev version.

jeffam → made their first commit to this issue’s fork.

jeffam → changed the visibility of the branch 2901412-pass-current-route-d10.1 to active.

I ran across this error while working on some malformed custom queueworker plugins that worked in Drupal 9 but not in Drupal 10.

But perhaps the larger issue is that the warning wasn't logged by Drupal. Without any logs, we didn't know about the issue for some time.

Here's a small patch that logs an error when line 264 in Cron.php fails and sets $lease_time to null.

This can happen if $worker->getPluginDefinition() fails (as it did in my case) or if the 'time' key is missing from the plugin definition.

jeffam → created an issue.

jeffam → created an issue.

Merged into 3.x

Thanks for catching that Twig spaceless tag!

Closing since we'll only be supporting version 3.x for Drupal 10.

jeffam → created an issue.

jeffam → created an issue.

Applied the patch from the bot.

Created branch 2979223-search-string-summary from 3.0.x and re-rolled the patch from https://www.drupal.org/project/facets/issues/2979223#comment-15146318 ✨ Add option to show current search string in facet summary Needs work

I'm not sure that I should change the version of this issue to 3.0.x-dev, though, so I'll leave that for others to decide.

jeffam → made their first commit to this issue’s fork.

jeffam → created an issue.

jeffam → created an issue.

Thanks for the offer and the reminder to update the module. I just released a version compatible with D10. Sorry for the long delay.

The Summary Options module provides the following settings:

• Show summary
• Summary help text
• Summary Placeholder

I guess the single setting provided by this module, to limit the length of the summary, is different enough to warrant a separate module.

There's a patch in 🐛 Passing empty value to t() when same day + time for start and end date RTBC that prevents the error, but doesn't quite fix the formatting issue.