The Needs Review Queue Bot β tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- last update
about 1 year ago 29,469 pass - @claudiucristea opened merge request.
- Status changed to Needs review
about 1 year ago 11:11am 14 August 2023 - Status changed to RTBC
about 1 year ago 3:37pm 15 August 2023 - π§π¬Bulgaria pfrenssen Sofia
Looking good, patch has been updated to work with D10, tests are passing.
- last update
about 1 year ago 29,469 pass - last update
about 1 year ago 29,473 pass - last update
about 1 year ago 29,473 pass - last update
about 1 year ago 29,473 pass - last update
about 1 year ago 29,473 pass - last update
about 1 year ago 29,473 pass - last update
about 1 year ago 29,473 pass - Status changed to Needs work
about 1 year ago 5:43am 30 August 2023 - π³πΏNew Zealand quietone New Zealand
I'm triaging RTBC issues β . I re-read the IS and the comments. I didn't find any unanswered questions.
I read the patch (not a review) and found that the version numbers for the deprecation message are incorrect. I am setting to NW for that. The same is true for the Change record. I was thinking the title should have more details. More like this, "\Drupal\views\Plugin\views\field\BulkForm::__construct now requires \Drupal\Core\Routing\ResettableStackedRouteMatchInterface" Although, PHPStorm is complaining that
ResettableStackedRouteMatchInterface does not match the declaration.The diff applies to 11.x but there is no MR against 11.x. So, we should get it testing on 11.x.
I added the standard template to the IS in case it was needed. Setting to NW for the above.
- π³πΏNew Zealand quietone New Zealand
I think add is better, since this is adding a new argument.
- last update
about 1 year ago 29,474 pass - last update
about 1 year ago 29,474 pass - last update
about 1 year ago 29,474 pass - last update
about 1 year ago 30,102 pass - Status changed to RTBC
about 1 year ago 8:00am 30 August 2023 - π·π΄Romania claudiu.cristea Arad π·π΄
Thank you:
- I've opened a new MR against 11.x: https://git.drupalcode.org/project/drupal/-/merge_requests/4671. Still keeping the old MR for sites currently on Drupal 10.1
- I've updated the CR's branch & version but I don't think the title should contain such full-namespaced method names because it would make it hard to read. But if the core committer disagrees, they can fix this when they publish the CR.
-
I think add is better, since this is adding a new argument.
The main scope of this issue is not to add a new argument to that constructor but to forward/pass the bulk form route parameters to the confirmation form. However, I think using "add" would not make any difference.
Moving back to RTBC.
- last update
about 1 year ago 30,138 pass - last update
about 1 year ago 30,139 pass - last update
about 1 year ago 30,140 pass - last update
about 1 year ago 30,140 pass - last update
12 months ago 30,150 pass - last update
12 months ago 30,150 pass - last update
12 months ago 30,154 pass - last update
12 months ago 30,162 pass - last update
12 months ago 30,163 pass, 2 fail - last update
12 months ago 30,172 pass - last update
12 months ago 30,172 pass - last update
12 months ago 30,209 pass - last update
12 months ago 30,212 pass - last update
12 months ago 30,366 pass - last update
11 months ago 30,364 pass - last update
11 months ago 30,364 pass - last update
11 months ago 30,375 pass - last update
11 months ago 30,381 pass 58:02 57:14 Running- last update
11 months ago 30,388 pass - last update
11 months ago 30,397 pass - last update
11 months ago 30,401 pass - last update
11 months ago 30,414 pass - last update
11 months ago 30,419 pass - last update
11 months ago 30,424 pass - last update
11 months ago 30,430 pass - last update
11 months ago 30,438 pass - last update
11 months ago 30,442 pass - last update
11 months ago 30,460 pass - last update
10 months ago 30,476 pass - last update
10 months ago 30,487 pass - last update
10 months ago 30,490 pass - last update
10 months ago 30,490 pass - last update
10 months ago 30,492 pass - last update
10 months ago 30,516 pass - last update
10 months ago 30,523 pass - last update
10 months ago 30,534 pass - last update
10 months ago 30,556 pass - last update
10 months ago 30,606 pass - last update
10 months ago 30,607 pass - last update
10 months ago 30,609 pass - last update
10 months ago 30,671 pass - last update
10 months ago 30,679 pass - last update
9 months ago 30,683 pass - last update
9 months ago 30,688 pass - last update
9 months ago 30,692 pass - last update
9 months ago 30,692 pass - last update
9 months ago 30,692 pass - last update
9 months ago 30,700 pass - last update
9 months ago 30,702 pass - First commit to issue fork.
- π¬π§United Kingdom alexpott πͺπΊπ
alexpott β changed the visibility of the branch 2901412-pass-current-route-9.1.x to hidden.
- π¬π§United Kingdom alexpott πͺπΊπ
alexpott β changed the visibility of the branch 2901412-pass-current-route-d10 to hidden.
- π¬π§United Kingdom alexpott πͺπΊπ
alexpott β changed the visibility of the branch 2901412-pass-current-route to hidden.
- π¬π§United Kingdom alexpott πͺπΊπ
alexpott β changed the visibility of the branch 2901412-pass-current-route-d10.1 to hidden.
- π¬π§United Kingdom alexpott πͺπΊπ
I've changed the deprecation to be 10.3.0 as this has missed 10.2
- Status changed to Fixed
9 months ago 11:38pm 10 December 2023 -
alexpott β
committed 79a07a4e on 11.x
Issue #2901412 by claudiu.cristea, pfrenssen, grathbone, ravi.shankar,...
-
alexpott β
committed 79a07a4e on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.
- πΊπΈUnited States jeffam
jeffam β changed the visibility of the branch 2901412-pass-current-route-d10.1 to active.