Add current route parameters to the confirmation form route

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Looking good, patch has been updated to work with D10, tests are passing.

I'm triaging RTBC issues → . I re-read the IS and the comments. I didn't find any unanswered questions.

I read the patch (not a review) and found that the version numbers for the deprecation message are incorrect. I am setting to NW for that. The same is true for the Change record. I was thinking the title should have more details. More like this, "\Drupal\views\Plugin\views\field\BulkForm::__construct now requires \Drupal\Core\Routing\ResettableStackedRouteMatchInterface" Although, PHPStorm is complaining that
ResettableStackedRouteMatchInterface does not match the declaration.

The diff applies to 11.x but there is no MR against 11.x. So, we should get it testing on 11.x.

I added the standard template to the IS in case it was needed. Setting to NW for the above.

I think add is better, since this is adding a new argument.

Thank you:

• I've opened a new MR against 11.x: https://git.drupalcode.org/project/drupal/-/merge_requests/4671. Still keeping the old MR for sites currently on Drupal 10.1
• I've updated the CR's branch & version but I don't think the title should contain such full-namespaced method names because it would make it hard to read. But if the core committer disagrees, they can fix this when they publish the CR.

• I think add is better, since this is adding a new argument.

  The main scope of this issue is not to add a new argument to that constructor but to forward/pass the bulk form route parameters to the confirmation form. However, I think using "add" would not make any difference.

Moving back to RTBC.

alexpott → changed the visibility of the branch 2901412-pass-current-route-9.1.x to hidden.

alexpott → changed the visibility of the branch 2901412-pass-current-route-d10 to hidden.

alexpott → changed the visibility of the branch 2901412-pass-current-route to hidden.

alexpott → changed the visibility of the branch 2901412-pass-current-route-d10.1 to hidden.

I've changed the deprecation to be 10.3.0 as this has missed 10.2

Fixing issue credit

Committed 79a07a4 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

jeffam → changed the visibility of the branch 2901412-pass-current-route-d10.1 to active.