Failsafe conversion of block_classes_stored

Nice catch. Thanks for the MR

Added thread above there

Addressed feedback on the MR

Just a note to the initial issue description: it is quite risky to run drush config:import before drush up.

If you deploy changes the best practice order is https://www.drush.org/12.x/deploycommand/ or the corresponding documented individual commands.

Thanks a lot Stephan (@szeidler) for the very helpful feedback!

Unrelated with this ticket, but just by curiosity:
To deploy/build a project, do you usually like using the drush deploy command or rather each one of the commands separately?

drush updb
drush cr
drush cim
drush cr

along with hook_install

I've seen projects use a lot hook_deploy, along with drush deploy, but personally, I'm not a big fan...

Would be glad to hear if you have any thoughts on that.
Thanks in advance!

Thanks @szeidler for making this clear.
We have a typical scenario where we need to migrate fields from one type to another (e.g. plaintext to formatted text), so we first import configuration to add the new field, then run updates to copy the field values over through HOOK_update_N(). Doing it the other way around would not work, since the new field does not exist when the hook is run.
Wasn't aware of HOOK_deploy_NAME(), which seems to improve things a lot. Will look deeper into it.

Nevertheless, I still think that update script should not fail if for whatever reason the setting has already been updated.

This patch works to now now allow database updates to run

block_class 20017 hook_update_n 20017 - Convert block_classes_stored from JSON to a sequence.

https://git.drupalcode.org/project/block_class/-/merge_requests/52.diff

I can also confirm the patch works as needed, database updates run just fine now.

+1 RTBC

If you already run database update. You can run below command to re-execute the database update.
Make sure you already applied the patch.

drush ev "\Drupal::service('update.update_hook_registry')->setInstalledVersion('block_class', 20016);";
drush updb;

Thanks for this. The patch works. Updating to the 4.x branch as the 2.x is now deprecated. +1 for RTBC

+1 RTBC

Thank you for the good work!

Hi everyone,

This morning I faced this issues. By applying the MR patch, I was able to run drush updb properly! Great work!

I was also getting
// Do you wish to run the specified pending updates?: yes.

> [notice] Update started: block_class_update_20017
> [error] json_decode(): Argument #1 ($json) must be of type string, array given
> [error] Update failed: block_class_update_20017

when upgrading to v4.0.0 on Drupal 10.4.4. Confirmed that current dif: https://git.drupalcode.org/project/block_class/-/merge_requests/52.diff fixed the problem.

Moved to the dev branch

Thanks everyone

Automatically closed - issue fixed for 2 weeks with no activity.

Thank you for this fix.
Hoping for a tag release