Contrib.social

Storing block_classes_stored as a string value leads to poor developer experience

Open on Drupal.org →
Created on 3 February 2023, almost 2 years ago
Updated 29 May 2023, over 1 year ago

Problem/Motivation

The configuration property block_classes_stored is a string, which contains a list of classes encoded as JSON.

I can not find in the code why this needed to be stored as JSON rather than a sequence of strings.

When multiple developers are working in the early stages of a project this can lead to some really frustrating merge conflicts when developers are adding blocks with different / new classes in parallel.

It would make the merges and rebasing changes easier if the block_classes_stored property was a sequence of strings rather than a single string.

Steps to reproduce

n/a

Proposed resolution

Covert block_classes_stored from string to a sequence of strings

Remaining tasks

  1. ✅
  2. Implement changes

User interface changes

N/A

API changes

N/A

Data model changes

Change in configuration storage.

Before

block_classes_stored: '{"navigation":"navigation","promotion":"promotion"}'

After

block_classes_stored: 
  - navigation
  - promotion
✨ Feature request
Status

Fixed

Version

2.0

Component

Code

Created by

🇳🇿New Zealand ericgsmith

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024