piridium → created an issue.
While we're at it, we should also name the second field formatter correctly. We have also opted for a slightly different capitalization than ... because the meaning is clearer.
piridium → made their first commit to this issue’s fork.
We just released imagelightbox 2.2.5 → which includes the fix for this issue. Thanks @prudloff for reporting it.
piridium → changed the visibility of the branch 3518704-xss-vulnerability-in to active.
piridium → changed the visibility of the branch 3518704-xss-vulnerability-in to hidden.
piridium → made their first commit to this issue’s fork.
Thank you @mudasirweb and @sandip-poddar for taking care of further adjustments. However, I think it would be primarily important to get the original patch into a release, as the bug blocks the use of multivalued fields. We already have a confirmation for RTBC in #14. @saschaeggi could you please include this in a release?
Further adjustments like the centered drag handles and the title should imho be discussed in a separate issue.
dan2k3k4 → credited piridium → .
dan2k3k4 → credited piridium → .
@christosgeorgiadis Thanks for the merge request. However, I think you have not implemented the original patch correctly. The 'table' itself has the class '.table-file-multiple-widget' and its child td should be set to 'height: auto'.
Your solution works, but only because the table in question is a child of another table. I can imagine that there may be situations in which this is not the case.
piridium → created an issue.
piridium → created an issue.
+1 from me
+1 RTBC
Thank you for the good work!
dan2k3k4 → credited piridium → .
dan2k3k4 → credited piridium → .
dan2k3k4 → credited piridium → .
dan2k3k4 → credited piridium → .
Added troubleshooting section. While the first three points are relatively straightforward, the last one took me a while to realize.
dan2k3k4 → credited piridium → .
This still seems to be an issue. Patch #2 works for me.
Has there been any progress on this? I think it would generally make sense if we could correctly assign the 'Enter' key to the appropriate submit action on a global, drupal wide level.
Thanks @sander-wemagine!
I can confirm that this updated patch works.
dan2k3k4 → credited piridium → .
dan2k3k4 → credited piridium → .
piridium → created an issue.
I understand the consideration that the review process aims to understand the competencies of the applicant. However, solely focusing on the commit count strikes me as somewhat superficial. For the past 28 months, nearly all commits have been made by the applicant, and during this time, a significant portion of the module has been rewritten. Is there a possibility for the code and contributions of the applicant to be evaluated?
piridium → created an issue.
Application is filed: https://www.drupal.org/project/projectapplications/issues/3432783 →
piridium → created an issue.
This is a first attempt at implementing Drupal behaviors. Please thoroughly test it and provide feedback on whether it works with Ajax reloading.
2.2.4 released
piridium → created an issue.
piridium → created an issue. See original summary → .
- Released 1.0.2
- Leave the issue open to accept new rector patches
piridium → created an issue.
dan2k3k4 → credited piridium → .
dan2k3k4 → credited piridium → .
dan2k3k4 → credited piridium → .
@j-lee There are absolutely no difference in the changes between my patch and your merge request. The only difference is some patch metadata which, I guess, relates to the information added to info.yml files by the packaging script.
Your merge request is still totally valid and up to date.
I provided a patch here.
https://www.drupal.org/project/gin/issues/3349440#comment-15341546
🐛
[VBO] Actions as buttons shows actions element twice
Needs review
Please review and test.
I provided a patch here.
https://www.drupal.org/project/gin/issues/3349440#comment-15341546
🐛
[VBO] Actions as buttons shows actions element twice
Needs review
Please review and test.
Please excue, I was not aware that I replaced a related issue instead of adding one.
I am reopening this issue because I think we are better off solving this from gins side instead of vbos.
Gin changes the form display to flex and introduces order properties. In particular, the edit header gets order: 99, which causes it to be positioned at the end.
I suggest that this order parameter is removed.
In addition, I would remove the parameter justify-content: flex-end for the form-actions, because this causes the buttons in the header to be aligned to the right in contrast to the footer.
Please refer to the attached patch.
dan2k3k4 → credited piridium → .
piridium → created an issue.
I have a custom daterange field for the relations user <-> group and node <-> group. A custom module only grants access to group nodes if both dateranges include todays date. Like this, we can provide time restricted access to dynamic content.
I was using a hook_content_info_alter to add a custom access handler class. For 2.0 compatibility, I had to change that and after a lot of headache, I got it running with a service decorator like described here: https://gist.github.com/adamfranco/5814eba660cbda3c93b5253b28b325ab
I am only changing the access handler for the 'view' operation. Everything else is handled via the existing functionality (roles etc.).
Am I right that in this case, a decoration like the example in the link above is the correct way to go?
Patch #5 did not apply to the composer installed version 2.0.0. There seems to be an issue with the .info.yml files.
I guess this is caused by the information added by Drupal.org packaging script. Can someone with more knowledge about patching tell if that's what's going on?
This new patch should work for the version 2.0.0 installed with composer.
dan2k3k4 → credited piridium → .
Thank you @losewn for the provided alternative using hooks. I did use this implementation in the end, because the class SiteInformationForm is marked as @internal and thus should not be extended.
However, there is a minor typo in your code on line 13. It's missing a trailing ' before closing the bracket.
#8 fixed the issue for me. Thanks @tarik.cipix
piridium → created an issue.
piridium → created an issue.
I ran phpcs and phpcbf and committed the coding style fixes without the additional changes out of scope of this issue.
Please note, that we are switching to 2.x-dev for further development as we figured it is the recommended way of not having dev-versions for every minor version.
Thank you for the effort, but your changes raised a new bug. Please test your changes before committing.
Visit /admin/structure/types/manage/BUNDLENAME/display
Fatal error: Declaration of Drupal\imagelightbox\Plugin\Field\FieldFormatter\ImagelightboxFormatter::create(Drupal\imagelightbox\Plugin\Field\FieldFormatter\ContainerInterface $container) must be compatible with Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) in [...]/web/modules/contrib/imagelightbox/src/Plugin/Field/FieldFormatter/ImagelightboxFormatter.php on line 43
Next try: shorten issue summary.
#8 did not work as expected... :-)
Shorten issue description.
The patch provided in #5 resolves the error but opens a new one:
When trying to change the field formatter to ImageLightBox (/admin/structure/types/manage/BUNDLENAME/display) the ajax call does not finish.
Thank you for the valuable hint. We could use some help with adjusting to Drupal behaviors. Would you be willing to assist us?
Thank you!
There is a problem with the declaration of the method 'create':
Fatal error: Could not check compatibility between Drupal\imagelightbox\Plugin\Field\FieldFormatter\MediaImagelightboxFormatter::create(Drupal\imagelightbox\Plugin\Field\FieldFormatter\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) and Drupal\Core\Field\FormatterBase::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition), because class Drupal\imagelightbox\Plugin\Field\FieldFormatter\ContainerInterface is not available in /Users/pi/Sites/D10/d10/web/modules/contrib/imagelightbox/src/Plugin/Field/FieldFormatter/MediaImagelightboxFormatter.php on line 60
Fixed in 2.2.1
Thank you!
Fixed in 2.2.x
Thank you!
Fixed in 2.2.x
Thank you!
piridium → created an issue.
Just realized, that it's just removing the trailing separator, but not the separator(s) between slots. Please consider this new patch, which first unsets all empty comments and then joins the remaining ones together.
Patch was the wrong way around. *omg*
piridium → created an issue.