- 🇩🇪Germany J-Lee 🇩🇪🇪🇺
Patches from bot looks good.
The changes to the info files could be done on commit:
contact_permissions.info.yml
tests/modules/contact_permissions_test/contact_permissions_test.info.ymlValue of core_version_requirement: ^8 || ^9 is not compatible with the next major version of Drupal core. See https://drupal.org/node/3070687.
- last update
almost 2 years ago 1 pass - 🇪🇸Spain plopesc Valladolid
Patch updated to inclde .info.yml files changes
- Status changed to RTBC
over 1 year ago 9:18am 25 August 2023 - last update
over 1 year ago 2 fail - last update
over 1 year ago Composer require failure - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago Composer require failure - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - 🇨🇭Switzerland piridium
Patch #5 did not apply to the composer installed version 2.0.0. There seems to be an issue with the .info.yml files.
I guess this is caused by the information added by Drupal.org packaging script. Can someone with more knowledge about patching tell if that's what's going on?
This new patch should work for the version 2.0.0 installed with composer.
- 🇩🇪Germany J-Lee 🇩🇪🇪🇺
@piridium can you please add your changes to the merge request?
- Assigned to AstonVictor
- Status changed to Needs work
about 1 year ago 7:25am 1 December 2023 - 🇺🇦Ukraine AstonVictor
It still needs some work.
e.g. we need to removecore: 8.x
from the info file.Also, we need to add default files such as composer.json, Readme.md and implement
hook_help()
- 🇨🇭Switzerland piridium
@j-lee There are absolutely no difference in the changes between my patch and your merge request. The only difference is some patch metadata which, I guess, relates to the information added to info.yml files by the packaging script.
Your merge request is still totally valid and up to date. - last update
about 1 year ago 1 pass - last update
about 1 year ago 1 pass - Status changed to Needs review
about 1 year ago 9:31am 1 December 2023 - Issue was unassigned.
- Status changed to Needs work
about 1 year ago 7:49pm 12 December 2023 - Status changed to Needs review
about 1 year ago 8:27pm 12 December 2023 -
Manuel Garcia →
committed df2aac4d on 3.0.x authored by
J-Lee →
'Issue #3296873 by AstonVictor, J-Lee, piridium, plopesc, Manuel Garcia...
-
Manuel Garcia →
committed df2aac4d on 3.0.x authored by
J-Lee →
- Status changed to Fixed
about 1 year ago 6:56am 16 December 2023 - 🇪🇸Spain manuel garcia
Thank you everyone who helped with this, I've now comitted the changes and cut a new 3.0.0 release: https://www.drupal.org/project/contact_permissions/releases/3.0.0 →
Automatically closed - issue fixed for 2 weeks with no activity.